Geert Uytterhoeven
7e55003b57
serial: sh-sci: Fix TX DMA buffer flushing and workqueue races ...
[ Upstream commit 8493eab02608b0e82f67b892aa72882e510c31d0 ]
When uart_flush_buffer() is called, the .flush_buffer() callback zeroes
the tx_dma_len field. This may race with the work queue function
handling transmit DMA requests:
1. If the buffer is flushed before the first DMA API call,
dmaengine_prep_slave_single() may be called with a zero length,
causing the DMA request to never complete, leading to messages
like:
rcar-dmac e7300000.dma-controller: Channel Address Error happen
and, with debug enabled:
sh-sci e6e88000.serial: sci_dma_tx_work_fn: ffff800639b55000: 0...0, cookie 126
and DMA timeouts.
2. If the buffer is flushed after the first DMA API call, but before
the second, dma_sync_single_for_device() may be called with a zero
length, causing the transmit data not to be flushed to RAM, and
leading to stale data being output.
Fix this by:
1. Letting sci_dma_tx_work_fn() return immediately if the transmit
buffer is empty,
2. Extending the critical section to cover all DMA preparational work,
so tx_dma_len stays consistent for all of it,
3. Using local copies of circ_buf.head and circ_buf.tail, to make sure
they match the actual operation above.
Reported-by: Eugeniu Rosca <erosca@de.adit-jv.com>
Suggested-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Reviewed-by: Eugeniu Rosca <erosca@de.adit-jv.com>
Tested-by: Eugeniu Rosca <erosca@de.adit-jv.com>
Link: https://lore.kernel.org/r/20190624123540.20629-2-geert+renesas@glider.be
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
2019-08-04 09:33:40 +02:00
x86/cpu: Sanitize FAM6_ATOM naming
2019-05-14 19:19:34 +02:00
ARM: amba: Don't read past the end of sysfs "driver_override" buffer
2018-05-01 15:13:08 -07:00
binder: replace "%p" with "%pK"
2019-06-11 12:22:44 +02:00
libata: don't request sense data on !ZAC ATA devices
2019-08-04 09:33:22 +02:00
atm: he: fix sign-extension overflow on large shift
2019-02-27 10:06:59 +01:00
regmap: fix bulk writes on paged registers
2019-08-04 09:33:19 +02:00
floppy: fix out-of-bounds read in copy_buffer
2019-08-04 09:33:29 +02:00
Bluetooth: hci_bcsp: Fix memory leak in rx_skb
2019-08-04 09:33:24 +02:00
bus: arm-cci: remove unnecessary unreachable()
2018-12-05 19:42:41 +01:00
cdrom: Fix race condition in cdrom_sysctl_register
2019-04-05 22:29:12 +02:00
virtio_console: initialize vtermno value for ports
2019-05-31 06:48:29 -07:00
clk: sunxi: fix uninitialized access
2019-07-10 09:55:44 +02:00
clocksource/drivers/exynos_mct: Increase priority over ARM arch timer
2019-08-04 09:33:22 +02:00
cpufreq: pmac32: fix possible object reference leak
2019-05-31 06:48:27 -07:00
cpuidle: big.LITTLE: fix refcount leak
2019-02-12 19:44:55 +01:00
crypto: caam - limit output IV to CBC to work around CTR mode DMA issue
2019-08-04 09:33:30 +02:00
dmaengine: imx-sdma: fix use-after-free on probe error path
2019-08-04 09:33:14 +02:00
dma-buf: remove redundant initialization of sg_table
2018-06-06 16:44:33 +02:00
EDAC: Fix global-out-of-bounds write when setting edac_mc_poll_msec
2019-08-04 09:33:23 +02:00
extcon: arizona: Disable mic detect if running when driver is removed
2019-05-31 06:48:26 -07:00
firewire-ohci: work around oversized DMA reads on JMicron controllers
2018-05-30 07:50:18 +02:00
efi/libstub: Unify command line param parsing
2019-06-11 12:22:45 +02:00
gpiolib: Fix references to gpiod_[gs]et_*value_cansleep() variants
2019-08-04 09:33:24 +02:00
drm/rockchip: Properly adjust to a true clock in adjusted_mode
2019-08-04 09:33:38 +02:00
HID: core: move Usage Page concatenation to Main item
2019-05-31 06:48:29 -07:00
Drivers: hv: vmbus: Return -EINVAL for the sys files for unopened channels
2018-12-29 13:40:15 +01:00
hwmon: (pmbus/core) Treat parameters as paged if on multiple pages
2019-07-10 09:55:32 +02:00
intel_th: msu: Fix single mode with disabled IOMMU
2019-08-04 09:33:31 +02:00
i2c: dev: fix potential memory leak in i2cdev_ioctl_rdwr
2019-06-22 08:17:23 +02:00
ide: pmac: add of_node_put()
2018-12-21 14:11:37 +01:00
x86/cpu: Sanitize FAM6_ATOM naming
2019-05-14 19:19:34 +02:00
iio: common: ssp_sensors: Initialize calculated_time in ssp_common_process_data
2019-05-31 06:48:27 -07:00
RDMA/i40iw: Set queue pair state when being queried
2019-08-04 09:33:39 +02:00
Input: gtco - bounds check collection indent level
2019-08-04 09:33:26 +02:00
iommu/vt-d: Set intel_iommu_gfx_mapped correctly
2019-06-22 08:17:14 +02:00
Revert "MIPS: perf: ath79: Fix perfcount IRQ assignment"
2019-06-11 12:22:48 +02:00
mISDN: make sure device name is NUL terminated
2019-06-22 08:17:22 +02:00
leds: pca9532: fix a potential NULL pointer dereference
2019-05-04 08:49:10 +02:00
macintosh/rack-meter: Convert cputime64_t use to u64
2018-10-20 09:51:32 +02:00
mailbox: xgene-slimpro: Fix potential NULL pointer dereference
2018-09-09 20:01:19 +02:00
dm bufio: fix deadlock with loop device
2019-08-04 09:33:32 +02:00
media: coda: Remove unbalanced and unneeded mutex unlock
2019-08-04 09:33:27 +02:00
memory: tegra: Fix integer overflow on tick value calculation
2019-05-25 18:26:49 +02:00
memstick: Fix error cleanup path of memstick_init
2019-08-04 09:33:37 +02:00
scsi: mptfusion: Add bounds check in mptctl_hp_targetinfo()
2018-05-25 16:13:06 +02:00
mfd: hi655x-pmic: Fix missing return value check for devm_regmap_init_mmio_clk
2019-08-04 09:33:39 +02:00
VMCI: Fix integer overflow in VMCI handle arrays
2019-07-21 09:06:03 +02:00
mmc: sdhci-of-esdhc: add erratum eSDHC-A001 and A-008358 support
2019-05-31 06:48:25 -07:00
mtd: rawnand: gpmi: fix MX28 bus master lockup problem
2019-02-15 08:07:37 +01:00
bonding: validate ip header before check IPPROTO_IGMP
2019-08-04 09:33:35 +02:00
spi: ST ST95HF NFC: declare missing of table
2019-05-16 19:43:43 +02:00
ntb_transport: Fix bug with max_mw_size parameter
2018-05-30 07:50:22 +02:00
libnvdimm/pfn: fix fsdax-mode namespace info-block zero-fields
2019-08-04 09:33:29 +02:00
nvme: Fix u32 overflow in the number of namespace list calculation
2019-07-10 09:55:32 +02:00
nvmem: core: fix read buffer in place
2019-06-22 08:17:15 +02:00
of: add helper to lookup compatible child node
2018-12-01 09:44:21 +01:00
parisc: Use implicit space register selection for loading the coherence index of I/O pdirs
2019-06-11 12:22:47 +02:00
parport: Fix mem leak in parport_register_dev_model
2019-07-10 09:55:29 +02:00
PCI: xilinx-nwl: Fix Multi MSI data programming
2019-08-04 09:33:38 +02:00
pcmcia: Implement CLKRUN protocol disabling for Ricoh bridges
2018-11-13 11:16:46 -08:00
phy: renesas: rcar-gen2: Fix memory leak at error paths
2019-08-04 09:33:37 +02:00
pinctrl: rockchip: fix leaked of_node references
2019-08-04 09:33:36 +02:00
platform/x86: intel_pmc_ipc: adding error handling
2019-06-22 08:17:16 +02:00
power: supply: sysfs: prevent endless uevent loop with CONFIG_POWER_SUPPLY_DEBUG
2019-05-25 18:26:56 +02:00
x86/cpu: Sanitize FAM6_ATOM naming
2019-05-14 19:19:34 +02:00
ptp: check gettime64 return code in PTP_SYS_OFFSET ioctl
2019-02-12 19:44:52 +01:00
pwm: Fix deadlock warning when removing PWM device
2019-06-22 08:17:17 +02:00
rapidio: fix a NULL pointer dereference when create_workqueue() fails
2019-06-22 08:17:11 +02:00
regulator: s2mps11: Fix buck7 and buck8 wrong voltages
2019-08-04 09:33:26 +02:00
reset: make device_reset_optional() really optional
2018-12-08 13:05:08 +01:00
rpmsg: smd: fix memory leak on channel create
2018-11-13 11:17:03 -08:00
rtc: pcf8523: don't return invalid date when battery is low
2019-06-22 08:17:21 +02:00
s390/qdio: handle PENDING state for QEBSM devices
2019-08-04 09:33:18 +02:00
drivers/sbus/char: add of_node_put()
2018-12-21 14:11:36 +01:00
scsi: mac_scsi: Increase PIO/PDMA transfer length threshold
2019-08-04 09:33:25 +02:00
soc: mediatek: pwrap: Zero initialize rdata in pwrap_init_cipher
2019-06-22 08:17:15 +02:00
spi: bitbang: Fix NULL pointer dereference in spi_unregister_master
2019-07-10 09:55:43 +02:00
ssb: Fix possible NULL pointer dereference in ssb_host_pcmcia_exit
2019-05-31 06:48:12 -07:00
media: staging: media: davinci_vpfe: - Fix for memory leak if decoder initialization fails.
2019-08-04 09:33:17 +02:00
scsi: target/iscsi: Avoid iscsit_release_commands_from_conn() deadlock
2019-03-23 13:19:47 +01:00
TC: Set DMA masks for devices
2018-11-13 11:17:02 -08:00
drivers: thermal: tsens: Don't print error message on -EPROBE_DEFER
2019-06-22 08:17:13 +02:00
serial: sh-sci: Fix TX DMA buffer flushing and workqueue races
2019-08-04 09:33:40 +02:00
uio: Fix an Oops on load
2018-11-27 16:09:41 +01:00
usb: gadget: Zero ffs_io_data
2019-08-04 09:33:38 +02:00
uwb: hwa-rc: fix memory leak at probe
2018-10-03 17:01:42 -07:00
vfio/pci: use correct format characters
2019-05-08 07:19:10 +02:00
vhost_net: disable zerocopy by default
2019-08-04 09:33:20 +02:00
video: imsttfb: fix potential NULL pointer dereferences
2019-06-22 08:17:17 +02:00
drivers/virt/fsl_hypervisor.c: prevent integer overflow in ioctl
2019-05-16 19:43:47 +02:00
virtio: Honour 'may_reduce_num' in vring_create_virtqueue
2019-04-17 08:36:47 +02:00
w1: fix the resume command API
2019-05-31 06:48:15 -07:00
watchdog: fix compile time error of pretimeout governors
2019-06-22 08:17:14 +02:00
xen: let alloc_xenballooned_pages() fail if not enough memory free
2019-08-04 09:33:25 +02:00
zorro: Set up z->dev.dma_mask for the DMA API
2018-05-30 07:50:44 +02:00
7e55003b57