Arnaldo Carvalho de Melo
a9948a7e15
[TCP]: Fix minisock tcp_create_openreq_child() typo. ...
On 2/28/07, KOVACS Krisztian <hidden@balabit.hu> wrote:
>
> Hi,
>
> While reading TCP minisock code I've found this suspiciously looking
> code fragment:
>
> - 8< -
> struct sock *tcp_create_openreq_child(struct sock *sk, struct request_sock *req, struct sk_buff *skb)
> {
> struct sock *newsk = inet_csk_clone(sk, req, GFP_ATOMIC);
>
> if (newsk != NULL) {
> const struct inet_request_sock *ireq = inet_rsk(req);
> struct tcp_request_sock *treq = tcp_rsk(req);
> struct inet_connection_sock *newicsk = inet_csk(sk);
> struct tcp_sock *newtp;
> - 8< -
>
> The above code initializes newicsk to inet_csk(sk), isn't that supposed
> to be inet_csk(newsk)? As far as I can tell this might leave
> icsk_ack.last_seg_size zero even if we do have received data.
Good catch!
David, please apply the attached patch.
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
2007-02-28 11:05:56 -08:00
[PATCH] remove many unneeded #includes of sched.h
2007-02-14 08:09:54 -08:00
[PATCH] mark struct file_operations const 7
2007-02-12 09:48:46 -08:00
[PATCH] sysctl: remove insert_at_head from register_sysctl
2007-02-14 08:09:59 -08:00
[PATCH] remove many unneeded #includes of sched.h
2007-02-14 08:09:54 -08:00
[PATCH] sysctl: remove insert_at_head from register_sysctl
2007-02-14 08:09:59 -08:00
[Bluetooth] Make use of device_move() for RFCOMM TTY devices
2007-02-26 11:42:41 -08:00
[BRIDGE]: Fix locking of set path cost.
2007-02-28 09:42:12 -08:00
[NET]: Fix kfree(skb)
2007-02-28 09:42:14 -08:00
[NET]: Fix kfree(skb)
2007-02-28 09:42:14 -08:00
[PATCH] sysctl: remove the proc_dir_entry member for the sysctl tables
2007-02-14 08:10:00 -08:00
[PATCH] remove many unneeded #includes of sched.h
2007-02-14 08:09:54 -08:00
[PATCH] remove many unneeded #includes of sched.h
2007-02-14 08:09:54 -08:00
Merge branch 'upstream' into upstream-jgarzik
2007-02-17 18:26:09 -05:00
[TCP]: Fix minisock tcp_create_openreq_child() typo.
2007-02-28 11:05:56 -08:00
[IPV6]: /proc/net/anycast6 unbalanced inet6_dev refcnt
2007-02-28 09:42:10 -08:00
[IPX]: Remove ancient changelog
2007-02-28 09:42:06 -08:00
[IRDA] net/irda/: proper prototypes
2007-02-26 11:42:43 -08:00
[S390]: Add AF_IUCV socket support
2007-02-08 13:51:54 -08:00
[XFRM]: Fix OOPSes in xfrm_audit_log().
2007-02-12 13:53:54 -08:00
[PATCH] remove many unneeded #includes of sched.h
2007-02-14 08:09:54 -08:00
[PATCH] sysctl: remove insert_at_head from register_sysctl
2007-02-14 08:09:59 -08:00
[NET]: Handle disabled preemption in gfp_any()
2007-02-28 09:42:13 -08:00
[NET]: Fix kfree(skb)
2007-02-28 09:42:14 -08:00
[PATCH] mark struct file_operations const 8
2007-02-12 09:48:46 -08:00
[PATCH] sysctl: remove insert_at_head from register_sysctl
2007-02-14 08:09:59 -08:00
[AF_PACKET]: Remove unnecessary casts.
2007-02-26 11:42:45 -08:00
[PATCH] sysctl: remove insert_at_head from register_sysctl
2007-02-14 08:09:59 -08:00
[PATCH] sysctl: remove insert_at_head from register_sysctl
2007-02-14 08:09:59 -08:00
[PATCH] remove many unneeded #includes of sched.h
2007-02-14 08:09:54 -08:00
[SCTP]: Strike the transport before updating rto.
2007-02-26 11:42:50 -08:00
[PATCH] Convert highest_possible_processor_id to nr_cpu_ids
2007-02-20 17:10:13 -08:00
[NET] TIPC: Fix whitespace errors.
2007-02-10 23:20:15 -08:00
[PATCH] sysctl: remove insert_at_head from register_sysctl
2007-02-14 08:09:59 -08:00
[PATCH] mark struct file_operations const 8
2007-02-12 09:48:46 -08:00
[PATCH] sysctl: remove insert_at_head from register_sysctl
2007-02-14 08:09:59 -08:00
[NET]: Fix kfree(skb)
2007-02-28 09:42:14 -08:00
[PATCH] remove many unneeded #includes of sched.h
2007-02-14 08:09:54 -08:00
[S390]: Rewrite of the IUCV base code, part 2
2007-02-08 13:37:42 -08:00
[S390]: Rewrite of the IUCV base code, part 2
2007-02-08 13:37:42 -08:00
[PATCH] Make most file operations structs in fs/ const
2006-03-28 09:16:06 -08:00
[PATCH] AUDIT_FD_PAIR
2007-02-17 21:30:15 -05:00
Remove obsolete #include <linux/config.h>
2006-06-30 19:25:36 +02:00
Linux-2.6.12-rc2
2005-04-16 15:20:36 -07:00
a9948a7e15