Linus Torvalds
ac2111753c
blk-mq: initialize 'struct request' and associated data to zero ...
Jan Engelhardt reports a strange oops with an invalid ->sense_buffer
pointer in scsi_init_cmd_errh() with the blk-mq code.
The sense_buffer pointer should have been initialized by the call to
scsi_init_request() from blk_mq_init_rq_map(), but there seems to be
some non-repeatable memory corruptor.
This patch makes sure we initialize the whole struct request allocation
(and the associated 'struct scsi_cmnd' for the SCSI case) to zero, by
using __GFP_ZERO in the allocation. The old code initialized a couple
of individual fields, leaving the rest undefined (although many of them
are then initialized in later phases, like blk_mq_rq_ctx_init() etc.
It's not entirely clear why this matters, but it's the rigth thing to do
regardless, and with 4.0 imminent this is the defensive "let's just make
sure everything is initialized properly" patch.
Tested-by: Jan Engelhardt <jengelh@inai.de>
Acked-by: Jens Axboe <axboe@kernel.dk>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2015-04-11 13:42:16 -07:00
Merge branch 'for-3.20/core' of git://git.kernel.dk/linux-block
2015-02-12 14:13:23 -08:00
block: fix regression where bio_integrity_process uses wrong bio_vec iterator
2014-12-02 08:15:21 -07:00
block: rewrite and split __bio_copy_iov()
2015-02-05 09:30:44 -07:00
blkcg: remove blkcg->id
2014-09-08 09:55:37 -06:00
blkcg: remove blkcg->id
2014-09-08 09:55:37 -06:00
Merge branch 'for-3.20/core' of git://git.kernel.dk/linux-block
2015-02-12 14:13:23 -08:00
blk-mq: avoid infinite recursion with the FUA flag
2014-09-22 11:55:19 -06:00
blk-mq: support per-distpatch_queue flush machinery
2014-09-25 15:22:45 -06:00
block: Don't merge requests if integrity flags differ
2014-09-27 09:14:57 -06:00
block: Substitute rcu_access_pointer() for rcu_dereference_raw()
2014-02-18 12:21:26 -08:00
Merge branch 'locking-core-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip into next
2014-06-03 12:57:53 -07:00
block: Quiesce zeroout wrapper
2015-02-05 10:14:54 -07:00
block: handle the null_mapped flag correctly in blk_rq_map_user_iov
2015-02-11 11:24:12 -07:00
Fix bug in blk_rq_merge_ok
2015-03-20 08:50:41 -06:00
blk-mq: add file comments and update copyright notices
2014-05-28 10:15:41 -06:00
blk-mq: Use all available hardware queues
2014-12-09 09:08:21 -07:00
Revert "blk-mq: fix hctx/ctx kobject use-after-free"
2015-01-29 08:30:49 -08:00
blkmq: Fix NULL pointer deref when all reserved tags in
2015-03-18 17:06:18 -06:00
blk-mq: add tag allocation policy
2015-01-23 14:18:00 -07:00
blk-mq: initialize 'struct request' and associated data to zero
2015-04-11 13:42:16 -07:00
blk-mq: release mq's kobjects in blk_release_queue()
2015-01-29 08:30:51 -08:00
block: fix blk_stack_limits() regression due to lcm() change
2015-03-31 09:45:50 -06:00
block: fix regression with block enabled tagging
2014-04-09 21:54:06 -06:00
blk-mq: release mq's kobjects in blk_release_queue()
2015-01-29 08:30:51 -08:00
block: support different tag allocation policy
2015-01-23 14:15:46 -07:00
blk-throttle: check stats_cpu before reading it from sysfs
2015-02-20 22:11:58 -08:00
blk-mq: Allow requests to never expire
2015-01-08 08:59:01 -07:00
blk-mq: support per-distpatch_queue flush machinery
2014-09-25 15:22:45 -06:00
mm: convert some level-less printks to pr_*
2014-06-06 16:08:18 -07:00
bsg: Remove unused function bsg_goose_queue()
2012-12-06 14:33:02 +01:00
block: Simplify bsg complete all
2015-02-04 09:57:52 -07:00
cfq-iosched: handle failure of cfq group allocation
2015-02-09 10:22:39 -07:00
block: remove unrelated header files and export symbol
2014-01-21 20:18:26 -08:00
block, bdi: an active gendisk always has a request_queue associated with it
2014-09-08 10:00:35 -06:00
block: Stop abusing csd.list for fifo_time
2014-02-24 14:46:32 -08:00
block / PM: Replace CONFIG_PM_RUNTIME with CONFIG_PM
2014-12-04 01:00:23 +01:00
genhd: check for int overflow in disk_expand_part_tbl()
2014-11-19 13:09:07 -07:00
block: Add discard flag to blkdev_issue_zeroout() function
2015-01-21 10:41:46 -07:00
block: Fix computation of merged request priority
2014-10-31 08:30:43 -06:00
block: Add T10 Protection Information functions
2014-09-27 09:14:59 -06:00
blkcg: make CONFIG_BLK_CGROUP bool
2012-03-06 21:27:21 +01:00
block: Add T10 Protection Information functions
2014-09-27 09:14:59 -06:00
elevator: Fix a race in elevator switching
2013-07-03 13:25:24 +02:00
block: Fix dev_t minor allocation lifetime
2014-09-03 15:01:02 -06:00
block: pass iov_iter to the BLOCK_PC mapping functions
2015-02-05 09:30:40 -07:00
block: Add T10 Protection Information functions
2014-09-27 09:14:59 -06:00
ac2111753c