Peter Xu
fe5f83b163
mm/hugetlb: fix calculation of adjust_range_if_pmd_sharing_possible ...
commit 75802ca66354a39ab8e35822747cd08b3384a99a upstream.
This is found by code observation only.
Firstly, the worst case scenario should assume the whole range was covered
by pmd sharing. The old algorithm might not work as expected for ranges
like (1g-2m, 1g+2m), where the adjusted range should be (0, 1g+2m) but the
expected range should be (0, 2g).
Since at it, remove the loop since it should not be required. With that,
the new code should be faster too when the invalidating range is huge.
Mike said:
: With range (1g-2m, 1g+2m) within a vma (0, 2g) the existing code will only
: adjust to (0, 1g+2m) which is incorrect.
:
: We should cc stable. The original reason for adjusting the range was to
: prevent data corruption (getting wrong page). Since the range is not
: always adjusted correctly, the potential for corruption still exists.
:
: However, I am fairly confident that adjust_range_if_pmd_sharing_possible
: is only gong to be called in two cases:
:
: 1) for a single page
: 2) for range == entire vma
:
: In those cases, the current code should produce the correct results.
:
: To be safe, let's just cc stable.
Fixes: 017b1660df89 ("mm: migration: fix migration of huge PMD shared pages")
Signed-off-by: Peter Xu <peterx@redhat.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Reviewed-by: Mike Kravetz <mike.kravetz@oracle.com>
Cc: Andrea Arcangeli <aarcange@redhat.com>
Cc: Matthew Wilcox <willy@infradead.org>
Cc: <stable@vger.kernel.org>
Link: http://lkml.kernel.org/r/20200730201636.74778-1-peterx@redhat.com
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Mike Kravetz <mike.kravetz@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2020-08-26 10:29:06 +02:00
kasan: avoid -Wmaybe-uninitialized warning
2019-05-08 07:19:07 +02:00
writeback: synchronize sync(2) against cgroup writeback membership switches
2019-05-21 18:49:01 +02:00
mm: balloon: use general non-lru movable page feature
2016-07-26 16:19:19 -07:00
mm: kmemleak: avoid using __va() on addresses that don't have a lowmem mapping
2016-10-11 15:06:33 -07:00
cleancache: constify cleancache_ops structure
2016-01-27 09:09:57 -05:00
mm/cma.c: fail if fixed declaration can't be honored
2019-08-06 18:29:37 +02:00
mm/cma_debug.c: fix the break condition in cma_maxchunk_get()
2019-06-22 08:17:12 +02:00
mm, compaction: fix NR_ISOLATED_* stats for pfn based migration
2017-01-12 11:39:32 +01:00
mm: get rid of vmacache_flush_all() entirely
2018-09-19 22:47:17 +02:00
mm/page_ref: add tracepoint to track down page reference manipulation
2016-03-17 15:09:34 -07:00
mm: convert printk(KERN_<LEVEL> to pr_<level>
2016-03-17 15:09:34 -07:00
mm/early_ioremap: Fix boot hang with earlyprintk=efi,keep
2018-02-25 11:05:49 +01:00
mm/fadvise.c: fix signed overflow UBSAN complaint
2018-09-15 09:42:57 +02:00
mm: fault-inject take over bootstrap kmem_cache check
2016-03-15 16:55:16 -07:00
mm/filemap.c: don't initiate writeback if mapping has no dirty pages
2019-11-12 19:16:10 +01:00
mm/frame_vector.c: release a semaphore in 'get_vaddr_frames()'
2018-11-10 07:42:52 -08:00
mm, frontswap: convert frontswap_enabled to static key
2016-07-26 16:19:19 -07:00
mm: prevent get_user_pages() from overflowing page refcount
2019-06-11 12:22:45 +02:00
mm/highmem: make nr_free_highpages() handles all highmem zones by itself
2016-05-19 19:12:14 -07:00
mm: thp: make the THP mapcount atomic against __split_huge_pmd_locked()
2020-06-20 10:24:19 +02:00
mm/hugetlb: fix calculation of adjust_range_if_pmd_sharing_possible
2020-08-26 10:29:06 +02:00
mm: hugetlb: switch to css_tryget() in hugetlb_cgroup_charge_cgroup()
2019-11-25 09:51:58 +01:00
mm: Add a user_ns owner to mm_struct and fix ptrace permission checks
2017-01-06 10:40:13 +01:00
vmscan: return NODE_RECLAIM_NOSCAN in node_reclaim() when CONFIG_NUMA is n
2019-12-05 15:35:02 +01:00
mm: don't allow deferred pages with NEED_PER_CPU_KM
2018-05-22 16:57:57 +02:00
PM / Hibernate: allow hibernation with PAGE_POISONING_ZERO
2016-09-13 02:35:27 +02:00
khugepaged: adjust VM_BUG_ON_MM() in __khugepaged_enter()
2020-08-26 10:29:03 +02:00
mm: convert printk(KERN_<LEVEL> to pr_<level>
2016-03-17 15:09:34 -07:00
mm: convert printk(KERN_<LEVEL> to pr_<level>
2016-03-17 15:09:34 -07:00
mm/kmemleak.c: fix check for softirq context
2019-08-04 09:33:41 +02:00
mm/ksm.c: don't WARN if page is still mapped in remove_stable_node()
2019-11-28 18:28:09 +01:00
mm/list_lru.c: fix memory leak in __memcg_init_list_lru_node
2019-06-22 08:17:18 +02:00
x86: remove more uaccess_32.h complexity
2016-05-22 17:21:27 -07:00
mm: madvise(MADV_DODUMP): allow hugetlbfs pages
2018-10-10 08:53:20 +02:00
Disable the __builtin_return_address() warning globally after all
2016-10-12 10:23:41 -07:00
mm/memblock.c: reversed logic in memblock_discard()
2017-08-30 10:21:47 +02:00
mm/memcg: fix refcount error while moving and swapping
2020-07-31 16:44:05 +02:00
mm: hwpoison: fix thp split handing in soft_offline_in_use_page()
2019-03-23 13:19:49 +01:00
mm: stop leaking PageTables
2019-02-20 10:18:34 +01:00
mm: Avoid calling build_all_zonelists_init under hotplug context
2020-08-21 11:02:11 +02:00
mm: mempolicy: require at least one nodeid for MPOL_PREFERRED
2020-04-13 10:32:54 +02:00
Revert "mm, mempool: only set __GFP_NOMEMALLOC if there are free elements"
2016-07-28 16:07:41 -07:00
hugetlbfs: fix races and page leaks during migration
2019-03-13 14:04:54 -07:00
mm/mincore.c: make mincore() more conservative
2019-05-21 18:48:58 +02:00
mm/mlock.c: change count_mm_mlocked_page_nr return type
2019-07-10 09:55:43 +02:00
mm: convert printk(KERN_<LEVEL> to pr_<level>
2016-03-17 15:09:34 -07:00
mm/mmap.c: Add cond_resched() for exit_mmap() CPU stalls
2020-08-21 11:01:58 +02:00
mm/mmu_context, sched/core: Fix mmu_context.h assumption
2016-04-28 11:44:19 +02:00
mm/mmu_notifier: use hlist_add_head_rcu()
2019-08-04 09:33:42 +02:00
mm, page_alloc: inline the fast path of the zonelist iterator
2016-05-19 19:12:14 -07:00
x86/speculation/l1tf: Disallow non privileged high MMIO PROT_NONE mappings
2018-08-15 18:14:45 +02:00
mm: Fix mremap not considering huge pmd devmap
2020-06-11 09:22:20 +02:00
mm: discard memblock data later
2017-08-24 17:12:19 -07:00
x86/mm: split vmalloc_sync_all()
2020-04-02 17:20:26 +02:00
oom, oom_reaper: do not enqueue same task twice
2019-02-12 19:45:02 +01:00
mm/page-writeback.c: avoid potential division by zero in wb_min_max_ratio()
2020-01-23 08:19:40 +01:00
mm, page_alloc: fix core hung in free_pcppages_bulk()
2020-08-26 10:29:04 +02:00
mm/page_ext.c: fix an imbalance with kmemleak
2019-04-05 22:29:06 +02:00
mm/page_idle.c: fix oops because end_pfn is larger than max_pfn
2019-07-10 09:55:38 +02:00
mm/page_io.c: replace some BUG_ON()s with VM_BUG_ON_PAGE()
2016-10-07 18:46:29 -07:00
mm/page_isolation: fix typo: "paes" -> "pages"
2016-10-07 18:46:29 -07:00
mm/page_owner: don't define fields on struct page_ext by hard-coding
2016-10-07 18:46:27 -07:00
mm: check the return value of lookup_page_ext for all call sites
2016-06-03 15:06:22 -07:00
mm/pagewalk.c: report holes in hugetlb ranges
2017-11-24 08:33:42 +01:00
mm: percpu: use pr_fmt to prefix output
2016-03-17 15:09:34 -07:00
percpu: stop printing kernel addresses
2019-04-27 09:34:47 +02:00
mm/thp/migration: switch from flush_tlb_range to flush_pmd_tlb_range
2016-03-17 15:09:34 -07:00
mm: remove write/force parameters from __get_user_pages_unlocked()
2016-10-18 14:13:37 -07:00
fix Christoph's email addresses
2016-03-17 15:09:34 -07:00
mm: silently skip readahead for DAX inodes
2016-08-26 17:39:35 -07:00
mm: migration: fix migration of huge PMD shared pages
2018-11-21 09:26:03 +01:00
shmem: fix possible deadlocks on shmlock_user_lock
2020-05-20 08:15:33 +02:00
mm/slab.c: fix an infinite loop in leaks_show()
2019-06-22 08:17:13 +02:00
slub: move synchronize_sched out of slab_mutex on shrink
2017-03-22 12:43:38 +01:00
mm/slab: use memzero_explicit() in kzfree()
2020-06-30 15:38:44 -04:00
slub: move synchronize_sched out of slab_mutex on shrink
2017-03-22 12:43:38 +01:00
mm/slub: fix stack overruns with SLUB_STATS
2020-07-09 09:35:55 +02:00
treewide: replace obsolete _refok by __ref
2016-08-02 17:31:41 -04:00
mm/memory_hotplug: set magic number to page->freelist instead of page->lru.next
2017-10-21 17:21:36 +02:00
thp: reduce usage of huge zero page's atomic counter
2016-10-07 18:46:28 -07:00
mm, swap_cgroup: reschedule when neeed in swap_cgroup_swapoff()
2017-07-05 14:40:17 +02:00
mm: fix swap cache node allocation mask
2020-07-09 09:35:54 +02:00
x86/speculation/l1tf: Limit swap file size to MAX_PA/2
2018-08-15 18:14:45 +02:00
mm: cleancache: fix corruption on missed inode invalidation
2018-12-08 13:05:09 +01:00
usercopy: Avoid HIGHMEM pfn warning
2019-10-17 13:42:06 -07:00
mm, fs: get rid of PAGE_CACHE_* and page_cache_{get,release} macros
2016-04-04 10:41:08 -07:00
mm: page_mapped: don't assume compound page is huge or THP
2019-01-16 22:12:32 +01:00
mm: get rid of vmacache_flush_all() entirely
2018-09-19 22:47:17 +02:00
mm/vmalloc.c: don't dereference possible NULL pointer in __vunmap()
2020-06-03 08:16:47 +02:00
mm: vmpressure: fix sending wrong events on underflow
2017-03-12 06:41:43 +01:00
mm: remove seemingly spurious reclaimability check from laptop_mode gating
2018-09-19 22:47:12 +02:00
mm, vmstat: hide /proc/pagetypeinfo from normal users
2019-11-12 19:15:43 +01:00
mm: workingset: fix premature shadow node shrinking with cgroups
2017-04-08 09:30:36 +02:00
mm/z3fold.c: avoid modifying HEADLESS page and minor cleanup
2016-06-03 16:02:55 -07:00
mm/zsmalloc.c: fix the migrated zspage statistics.
2020-01-12 11:24:13 +01:00
zswap: re-check zswap_is_full() after do zswap_shrink()
2018-09-05 09:20:02 +02:00
fe5f83b163