Steven Rostedt (VMware)
2e584b1a02
tracing: Check length before giving out the filter buffer
...
commit b220c049d5196dd94d992dd2dc8cba1a5e6123bf upstream.
When filters are used by trace events, a page is allocated on each CPU and
used to copy the trace event fields to this page before writing to the ring
buffer. The reason to use the filter and not write directly into the ring
buffer is because a filter may discard the event and there's more overhead
on discarding from the ring buffer than the extra copy.
The problem here is that there is no check against the size being allocated
when using this page. If an event asks for more than a page size while being
filtered, it will get only a page, leading to the caller writing more that
what was allocated.
Check the length of the request, and if it is more than PAGE_SIZE minus the
header default back to allocating from the ring buffer directly. The ring
buffer may reject the event if its too big anyway, but it wont overflow.
Link: https://lore.kernel.org/ath10k/1612839593-2308-1-git-send-email-wgong@codeaurora.org/
Cc: stable@vger.kernel.org
Fixes: 0fc1b09ff1 ("tracing: Use temp buffer when filtering events")
Reported-by: Wen Gong <wgong@codeaurora.org>
Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2021-02-23 13:59:15 +01:00
..
blktrace.c
blktrace: break out of blktrace setup on concurrent calls
2020-06-30 15:38:43 -04:00
bpf_trace.c
bpf: fix check of allowed specifiers in bpf_trace_printk
2018-12-17 09:38:33 +01:00
ftrace.c
fgraph: Initialize tracing_graph_pause at task creation
2021-02-23 13:59:14 +01:00
Kconfig
Stop the ad-hoc games with -Wno-maybe-initialized
2020-05-20 08:15:37 +02:00
Makefile
Disable the __builtin_return_address() warning globally after all
2016-10-12 10:23:41 -07:00
power-traces.c
cpufreq: schedutil: New governor based on scheduler utilization data
2016-04-02 01:09:12 +02:00
ring_buffer.c
tracing: Fix race in trace_open and buffer resize call
2021-01-30 13:27:16 +01:00
ring_buffer_benchmark.c
ring_buffer: Remove unneeded smp_wmb() before wakeup of reader benchmark
2015-11-03 16:19:02 -05:00
rpm-traces.c
trace.c
tracing: Check length before giving out the filter buffer
2021-02-23 13:59:15 +01:00
trace.h
tracing: Fix userstacktrace option for instances
2020-12-11 13:38:01 +01:00
trace_benchmark.c
tracing: Only benchmark the time tracepoints take if tracing is on
2015-11-02 13:34:58 -05:00
trace_benchmark.h
trace_branch.c
trace_clock.c
trace_entries.h
tracing: Set kernel_stack's caller size properly
2020-10-01 20:40:05 +02:00
trace_event_perf.c
Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next
2016-05-17 16:26:30 -07:00
trace_events.c
tracing: Do not count ftrace events in top level enable output
2021-02-23 13:59:15 +01:00
trace_events_filter.c
tracing: Fix regex_match_front() to not over compare the test string
2018-05-16 10:08:43 +02:00
trace_events_filter_test.h
trace_events_hist.c
tracing: Use strncpy instead of memcpy for string keys in hist triggers
2019-03-23 13:19:45 +01:00
trace_events_trigger.c
tracing: Fix event trigger to accept redundant spaces
2020-06-30 15:38:45 -04:00
trace_export.c
tracing: ftrace_event_is_function() can return boolean
2015-11-02 14:28:05 -05:00
trace_functions.c
ftrace: Have set_ftrace_pid use the bitmap like events do
2016-06-20 09:54:19 -04:00
trace_functions_graph.c
tracing: Fix missing return symbol in function_graph output
2018-07-11 16:26:43 +02:00
trace_hwlat.c
tracing/hwlat: Honor the tracing_cpumask
2020-08-26 10:29:03 +02:00
trace_irqsoff.c
tracing: Remove redundant reset per-CPU buff in irqsoff tracer
2016-03-18 16:39:11 -04:00
trace_kdb.c
tracing: Silence GCC 9 array bounds warning
2019-07-10 09:55:28 +02:00
trace_kprobe.c
tracing: Quiet gcc warning about maybe unused link variable
2018-08-03 07:55:12 +02:00
trace_mmiotrace.c
tracing: Expose CPU physical addresses (resource values) for PCI devices
2016-06-20 09:54:22 -04:00
trace_nop.c
tracing: Fix typoes in code comment and printk in trace_nop.c
2016-03-08 11:23:57 -05:00
trace_output.c
tracing: Add NMI tracing in hwlat detector
2016-09-02 12:47:55 -04:00
trace_output.h
trace_printk.c
tracing: Handle NULL formats in hold_module_trace_bprintk_format()
2016-06-20 09:46:12 -04:00
trace_probe.c
tracing: probeevent: Fix to support minus offset from symbol
2018-03-28 18:39:23 +02:00
trace_probe.h
tracing: probeevent: Fix to support minus offset from symbol
2018-03-28 18:39:23 +02:00
trace_sched_switch.c
trace_sched_wakeup.c
kernel/trace: Fix do not unregister tracepoints when register sched_migrate_task fail
2020-01-14 20:04:26 +01:00
trace_selftest.c
ftrace: Handle tracing when switching between context
2020-11-10 10:24:02 +01:00
trace_selftest_dynamic.c
trace_seq.c
trace_stack.c
tracing: Have stack tracer compile when MCOUNT_INSN_SIZE is not defined
2020-01-14 20:04:26 +01:00
trace_stat.c
tracing: Fix very unlikely race of registering two stat tracers
2020-02-28 15:42:21 +01:00
trace_stat.h
trace_syscalls.c
tracing/syscalls: fix multiline in error message text
2016-09-29 10:25:23 +02:00
trace_uprobe.c
tracing/uprobes: Fix output for multiple string arguments
2019-02-20 10:18:32 +01:00
tracing_map.c
tracing: Have the histogram compare functions convert to u64 first
2020-01-12 11:24:14 +01:00
tracing_map.h
tracing: Update some tracing_map constants and comments
2016-04-19 12:16:06 -04:00