Laurent Dufour
a495f72f8a
mm/cgroup: avoid panic when init with low memory ...
[ Upstream commit bfc7228b9a9647e1c353e50b40297a2929801759 ]
The system may panic when initialisation is done when almost all the
memory is assigned to the huge pages using the kernel command line
parameter hugepage=xxxx. Panic may occur like this:
Unable to handle kernel paging request for data at address 0x00000000
Faulting instruction address: 0xc000000000302b88
Oops: Kernel access of bad area, sig: 11 [#1 ]
SMP NR_CPUS=2048 [ 0.082424] NUMA
pSeries
Modules linked in:
CPU: 0 PID: 1 Comm: swapper/0 Not tainted 4.9.0-15-generic #16-Ubuntu
task: c00000021ed01600 task.stack: c00000010d108000
NIP: c000000000302b88 LR: c000000000270e04 CTR: c00000000016cfd0
REGS: c00000010d10b2c0 TRAP: 0300 Not tainted (4.9.0-15-generic)
MSR: 8000000002009033 <SF,VEC,EE,ME,IR,DR,RI,LE>[ 0.082770] CR: 28424422 XER: 00000000
CFAR: c0000000003d28b8 DAR: 0000000000000000 DSISR: 40000000 SOFTE: 1
GPR00: c000000000270e04 c00000010d10b540 c00000000141a300 c00000010fff6300
GPR04: 0000000000000000 00000000026012c0 c00000010d10b630 0000000487ab0000
GPR08: 000000010ee90000 c000000001454fd8 0000000000000000 0000000000000000
GPR12: 0000000000004400 c00000000fb80000 00000000026012c0 00000000026012c0
GPR16: 00000000026012c0 0000000000000000 0000000000000000 0000000000000002
GPR20: 000000000000000c 0000000000000000 0000000000000000 00000000024200c0
GPR24: c0000000016eef48 0000000000000000 c00000010fff7d00 00000000026012c0
GPR28: 0000000000000000 c00000010fff7d00 c00000010fff6300 c00000010d10b6d0
NIP mem_cgroup_soft_limit_reclaim+0xf8/0x4f0
LR do_try_to_free_pages+0x1b4/0x450
Call Trace:
do_try_to_free_pages+0x1b4/0x450
try_to_free_pages+0xf8/0x270
__alloc_pages_nodemask+0x7a8/0xff0
new_slab+0x104/0x8e0
___slab_alloc+0x620/0x700
__slab_alloc+0x34/0x60
kmem_cache_alloc_node_trace+0xdc/0x310
mem_cgroup_init+0x158/0x1c8
do_one_initcall+0x68/0x1d0
kernel_init_freeable+0x278/0x360
kernel_init+0x24/0x170
ret_from_kernel_thread+0x5c/0x74
Instruction dump:
eb81ffe0 eba1ffe8 ebc1fff0 ebe1fff8 4e800020 3d230001 e9499a42 3d220004
3929acd8 794a1f24 7d295214 eac90100 <e9360000> 2fa90000 419eff74 3b200000
---[ end trace 342f5208b00d01b6 ]---
This is a chicken and egg issue where the kernel try to get free memory
when allocating per node data in mem_cgroup_init(), but in that path
mem_cgroup_soft_limit_reclaim() is called which assumes that these data
are allocated.
As mem_cgroup_soft_limit_reclaim() is best effort, it should return when
these data are not yet allocated.
This patch also fixes potential null pointer access in
mem_cgroup_remove_from_trees() and mem_cgroup_update_tree().
Link: http://lkml.kernel.org/r/1487856999-16581-2-git-send-email-ldufour@linux.vnet.ibm.com
Signed-off-by: Laurent Dufour <ldufour@linux.vnet.ibm.com>
Acked-by: Michal Hocko <mhocko@suse.com>
Acked-by: Johannes Weiner <hannes@cmpxchg.org>
Acked-by: Balbir Singh <bsingharora@gmail.com>
Cc: Vladimir Davydov <vdavydov.dev@gmail.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Sasha Levin <alexander.levin@verizon.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2017-10-08 10:26:10 +02:00
kasan: respect /proc/sys/kernel/traceoff_on_warning
2017-06-17 06:41:51 +02:00
block: fix double-free in the failure path of cgwb_bdi_init()
2017-02-26 11:10:52 +01:00
mm: balloon: use general non-lru movable page feature
2016-07-26 16:19:19 -07:00
mm: kmemleak: avoid using __va() on addresses that don't have a lowmem mapping
2016-10-11 15:06:33 -07:00
cleancache: constify cleancache_ops structure
2016-01-27 09:09:57 -05:00
mm/cma.c: check the max limit for cma allocation
2016-11-11 08:12:37 -08:00
mm: cma: mark cma_bitmap_maxno() inline in header
2015-08-14 15:56:32 -07:00
mm/cma_debug: correct size input to bitmap function
2015-07-17 16:39:54 -07:00
mm, compaction: fix NR_ISOLATED_* stats for pfn based migration
2017-01-12 11:39:32 +01:00
mm: clarify why we avoid page_mapcount() for slab pages in dump_page()
2016-10-07 18:46:29 -07:00
mm/page_ref: add tracepoint to track down page reference manipulation
2016-03-17 15:09:34 -07:00
mm: convert printk(KERN_<LEVEL> to pr_<level>
2016-03-17 15:09:34 -07:00
mm/early_ioremap: use offset_in_page macro
2015-11-05 19:34:48 -08:00
mm/fadvise.c: do not discard partial pages with POSIX_FADV_DONTNEED
2016-06-09 14:23:11 -07:00
mm: fault-inject take over bootstrap kmem_cache check
2016-03-15 16:55:16 -07:00
mm: do not access page->mapping directly on page_endio
2017-03-12 06:41:43 +01:00
mm: replace get_vaddr_frames() write/force parameters with gup_flags
2016-10-19 08:11:24 -07:00
mm, frontswap: convert frontswap_enabled to static key
2016-07-26 16:19:19 -07:00
mm: larger stack guard gap, between vmas
2017-06-24 07:11:18 +02:00
mm/highmem: make nr_free_highpages() handles all highmem zones by itself
2016-05-19 19:12:14 -07:00
thp, mm: fix crash due race in MADV_FREE handling
2017-07-21 07:42:21 +02:00
mm, hugetlb: use pte_present() instead of pmd_present() in follow_huge_pmd()
2017-04-08 09:30:35 +02:00
mm, hugetlb_cgroup: round limit_in_bytes down to hugepage size
2016-05-20 17:58:30 -07:00
hwpoison: use page_cgroup_ino for filtering by memcg
2015-09-10 13:29:01 -07:00
mm: Add a user_ns owner to mm_struct and fix ptrace permission checks
2017-01-06 10:40:13 +01:00
mm, mprotect: flush TLB if potentially racing with a parallel reclaim leaving stale TLB entries
2017-08-11 08:49:29 -07:00
Allow KASAN and HOTPLUG_MEMORY to co-exist when doing build testing
2016-10-27 16:23:01 -07:00
PM / Hibernate: allow hibernation with PAGE_POISONING_ZERO
2016-09-13 02:35:27 +02:00
mm: khugepaged: fix radix tree node leak in shmem collapse error path
2017-01-12 11:39:32 +01:00
mm: convert printk(KERN_<LEVEL> to pr_<level>
2016-03-17 15:09:34 -07:00
mm: convert printk(KERN_<LEVEL> to pr_<level>
2016-03-17 15:09:34 -07:00
mm: kmemleak: scan .data.ro_after_init
2016-11-11 08:12:37 -08:00
ksm: prevent crash after write_protect_page fails
2017-06-07 12:07:49 +02:00
mm/list_lru.c: fix list_lru_count_node() to be race free
2017-07-21 07:42:21 +02:00
x86: remove more uaccess_32.h complexity
2016-05-22 17:21:27 -07:00
mm, madvise: ensure poisoned pages are removed from per-cpu lists
2017-09-07 08:35:39 +02:00
Disable the __builtin_return_address() warning globally after all
2016-10-12 10:23:41 -07:00
mm/memblock.c: reversed logic in memblock_discard()
2017-08-30 10:21:47 +02:00
mm/cgroup: avoid panic when init with low memory
2017-10-08 10:26:10 +02:00
mm/memory-failure.c: use compound_head() flags for huge pages
2017-06-24 07:11:16 +02:00
mm/memory.c: fix mem_cgroup_oom_disable() call missing
2017-09-13 14:13:36 -07:00
base/memory, hotplug: fix a kernel oops in show_valid_zones()
2017-02-09 08:08:28 +01:00
mm/mempolicy: fix use after free when calling get_mempolicy
2017-08-24 17:12:20 -07:00
Revert "mm, mempool: only set __GFP_NOMEMALLOC if there are free elements"
2016-07-28 16:07:41 -07:00
memtest: remove unused header files
2015-09-08 15:35:28 -07:00
Sanitize 'move_pages()' permission checks
2017-08-24 17:12:21 -07:00
mm, swap: use offset of swap entry as key of swap cache
2016-10-07 18:46:28 -07:00
mlock: fix mlock count can not decrease in race condition
2017-06-07 12:07:49 +02:00
mm: convert printk(KERN_<LEVEL> to pr_<level>
2016-03-17 15:09:34 -07:00
mm: fix overflow check in expand_upwards()
2017-07-21 07:42:22 +02:00
mm/mmu_context, sched/core: Fix mmu_context.h assumption
2016-04-28 11:44:19 +02:00
fix Christoph's email addresses
2016-03-17 15:09:34 -07:00
mm, page_alloc: inline the fast path of the zonelist iterator
2016-05-19 19:12:14 -07:00
mm, mprotect: flush TLB if potentially racing with a parallel reclaim leaving stale TLB entries
2017-08-11 08:49:29 -07:00
mm, mprotect: flush TLB if potentially racing with a parallel reclaim leaving stale TLB entries
2017-08-11 08:49:29 -07:00
mm/msync: use offset_in_page macro
2015-11-05 19:34:48 -08:00
mm: discard memblock data later
2017-08-24 17:12:19 -07:00
ptrace: Don't allow accessing an undumpable mm
2017-01-06 10:40:13 +01:00
oom: print nodemask in the oom report
2016-10-07 18:46:29 -07:00
mm: don't use radix tree writeback tags for pages in swap cache
2016-10-07 18:46:28 -07:00
mm: prevent double decrease of nr_reserved_highatomic
2017-09-27 14:39:18 +02:00
mm: page_counter: let page_counter_try_charge() return bool
2015-11-05 19:34:48 -08:00
mm/page_ext: support extra space allocation by page_ext user
2016-10-07 18:46:27 -07:00
mm, vmscan: move lru_lock to the node
2016-07-28 16:07:41 -07:00
mm/page_io.c: replace some BUG_ON()s with VM_BUG_ON_PAGE()
2016-10-07 18:46:29 -07:00
mm/page_isolation: fix typo: "paes" -> "pages"
2016-10-07 18:46:29 -07:00
mm/page_owner: don't define fields on struct page_ext by hard-coding
2016-10-07 18:46:27 -07:00
mm: check the return value of lookup_page_ext for all call sites
2016-06-03 15:06:22 -07:00
thp: rename split_huge_page_pmd() to split_huge_pmd()
2016-01-15 17:56:32 -08:00
mm: percpu: use pr_fmt to prefix output
2016-03-17 15:09:34 -07:00
percpu: acquire pcpu_lock when updating pcpu_nr_empty_pop_pages
2017-03-26 13:05:58 +02:00
mm/thp/migration: switch from flush_tlb_range to flush_pmd_tlb_range
2016-03-17 15:09:34 -07:00
mm: remove write/force parameters from __get_user_pages_unlocked()
2016-10-18 14:13:37 -07:00
fix Christoph's email addresses
2016-03-17 15:09:34 -07:00
mm: silently skip readahead for DAX inodes
2016-08-26 17:39:35 -07:00
mm, mprotect: flush TLB if potentially racing with a parallel reclaim leaving stale TLB entries
2017-08-11 08:49:29 -07:00
mm, shmem: fix handling /sys/kernel/mm/transparent_hugepage/shmem_enabled
2017-08-30 10:21:46 +02:00
slub: move synchronize_sched out of slab_mutex on shrink
2017-03-22 12:43:38 +01:00
slub: move synchronize_sched out of slab_mutex on shrink
2017-03-22 12:43:38 +01:00
slub: move synchronize_sched out of slab_mutex on shrink
2017-03-22 12:43:38 +01:00
slub: move synchronize_sched out of slab_mutex on shrink
2017-03-22 12:43:38 +01:00
mm/slub.c: trace free objects at KERN_INFO
2017-06-07 12:07:49 +02:00
treewide: replace obsolete _refok by __ref
2016-08-02 17:31:41 -04:00
treewide: replace obsolete _refok by __ref
2016-08-02 17:31:41 -04:00
thp: reduce usage of huge zero page's atomic counter
2016-10-07 18:46:28 -07:00
mm, swap_cgroup: reschedule when neeed in swap_cgroup_swapoff()
2017-07-05 14:40:17 +02:00
mm, swap: use offset of swap entry as key of swap cache
2016-10-07 18:46:28 -07:00
mm: support anonymous stable page
2017-01-19 20:17:59 +01:00
fs: add i_blocksize()
2017-06-14 15:06:00 +02:00
mm: usercopy: Check for module addresses
2016-09-20 16:07:39 -07:00
mm, fs: get rid of PAGE_CACHE_* and page_cache_{get,release} macros
2016-04-04 10:41:08 -07:00
Merge branch 'mm-urgent-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip
2016-10-22 09:39:10 -07:00
mm: unrig VMA cache hit ratio
2016-10-07 18:46:27 -07:00
mm/vmalloc.c: huge-vmap: fail gracefully on unexpected huge vmap mappings
2017-07-05 14:40:28 +02:00
mm: vmpressure: fix sending wrong events on underflow
2017-03-12 06:41:43 +01:00
mm, vmscan: consider eligible zones in get_scan_count
2017-03-12 06:41:44 +01:00
seq/proc: modify seq_put_decimal_[u]ll to take a const char *, not char
2016-10-07 18:46:30 -07:00
mm: workingset: fix premature shadow node shrinking with cgroups
2017-04-08 09:30:36 +02:00
mm/z3fold.c: avoid modifying HEADLESS page and minor cleanup
2016-06-03 16:02:55 -07:00
mm/zbud.c: use list_last_entry() instead of list_tail_entry()
2016-01-15 11:40:52 -08:00
mm: zsmalloc: constify struct zs_pool name
2015-11-06 17:50:42 -08:00
zsmalloc: expand class bit
2017-04-21 09:31:19 +02:00
zswap: disable changing params if init fails
2017-02-09 08:08:27 +01:00
a495f72f8a