Tetsuo Handa
2595f213a4
hfsplus: stop workqueue when fill_super() failed ...
commit 66072c29328717072fd84aaff3e070e3f008ba77 upstream.
syzbot is reporting ODEBUG messages at hfsplus_fill_super() [1]. This
is because hfsplus_fill_super() forgot to call cancel_delayed_work_sync().
As far as I can see, it is hfsplus_mark_mdb_dirty() from
hfsplus_new_inode() in hfsplus_fill_super() that calls
queue_delayed_work(). Therefore, I assume that hfsplus_new_inode() does
not fail if queue_delayed_work() was called, and the out_put_hidden_dir
label is the appropriate location to call cancel_delayed_work_sync().
[1] https://syzkaller.appspot.com/bug?id=a66f45e96fdbeb76b796bf46eb25ea878c42a6c9
Link: http://lkml.kernel.org/r/964a8b27-cd69-357c-fe78-76b066056201@I-love.SAKURA.ne.jp
Signed-off-by: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Reported-by: syzbot <syzbot+4f2e5f086147d543ab03@syzkaller.appspotmail.com>
Cc: Al Viro <viro@zeniv.linux.org.uk>
Cc: David Howells <dhowells@redhat.com>
Cc: Ernesto A. Fernandez <ernesto.mnd.fernandez@gmail.com>
Cc: Vyacheslav Dubeyko <slava@dubeyko.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2018-05-25 16:12:59 +02:00
fs/9p: Compare qid.path in v9fs_test_inode
2017-11-30 08:39:05 +00:00
Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs
2016-10-10 20:16:43 -07:00
Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs
2016-10-10 20:16:43 -07:00
afs: Fix abort on signal while waiting for call completion
2017-12-20 10:07:25 +01:00
autofs: mount point create should honour passed in mode
2018-04-24 09:34:18 +02:00
befs fixes for 4.9-rc1
2016-10-15 12:09:13 -07:00
Merge remote-tracking branch 'ovl/rename2' into for-linus
2016-10-10 23:02:51 -04:00
btrfs: fix reading stale metadata blocks after degraded raid1 mounts
2018-05-22 16:57:59 +02:00
Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs
2016-10-10 20:16:43 -07:00
ceph: only dirty ITER_IOVEC pages for direct read
2018-04-08 12:12:42 +02:00
cifs: do not allow creating sockets except with SMB1 posix exensions
2018-04-29 11:31:55 +02:00
coda: fix 'kernel memory exposure attempt' in fsync
2017-11-24 08:33:42 +01:00
configfs: Fix race between create_link and configfs_rmdir
2017-06-24 07:11:12 +02:00
fscrypt: use ENOTDIR when setting encryption policy on nondirectory
2017-11-30 08:39:11 +00:00
dentry name snapshots
2017-08-06 18:59:43 -07:00
Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs
2016-10-10 20:16:43 -07:00
dlm: avoid double-free on error path in dlm_device_{register,unregister}
2017-09-09 17:39:40 +02:00
eCryptfs: use after free in ecryptfs_release_messaging()
2017-11-30 08:39:03 +00:00
Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs
2016-10-10 20:16:43 -07:00
fs: exofs: print a hex number after a 0x prefix
2016-10-27 18:43:43 -07:00
exportfs: be careful to only return expected errors.
2016-10-06 09:07:44 -04:00
ext2: fix a block leak
2018-05-25 16:12:56 +02:00
ext4: fix bitmap position validation
2018-05-01 15:13:03 -07:00
f2fs: fix a dead loop in f2fs_fiemap()
2018-05-16 10:08:42 +02:00
fat: fix using uninitialized fields of fat_inode/fsinfo_inode
2017-03-15 10:02:52 +08:00
FS-Cache: fix dereference of NULL user_key_payload
2017-10-27 10:38:11 +02:00
fuse: fix READDIRPLUS skipping an entry
2017-11-02 09:49:13 +01:00
GFS2: Take inode off order_write list when setting jdata flag
2017-12-20 10:07:30 +01:00
Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs
2016-10-10 20:16:43 -07:00
hfsplus: stop workqueue when fill_super() failed
2018-05-25 16:12:59 +02:00
Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs
2016-10-10 20:16:43 -07:00
Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs
2016-10-10 20:16:43 -07:00
hugetlbfs: initialize shared policy as part of inode allocation
2017-10-08 10:26:09 +02:00
isofs: fix timestamps beyond 2027
2017-11-30 08:39:04 +00:00
ext4: set h_journal if there is a failure starting a reserved handle
2018-05-01 15:13:03 -07:00
jffs2_kill_sb(): deal with failed allocations
2018-04-24 09:34:17 +02:00
jfs: Don't clear SGID when inheriting ACLs
2017-08-06 18:59:39 -07:00
kernfs: fix regression in kernfs_fop_write caused by wrong type
2018-02-17 13:21:15 +01:00
lockd: lost rollback of set_grace_period() in lockd_down_net()
2018-05-19 10:27:00 +02:00
Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs
2016-10-10 20:16:43 -07:00
Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs
2016-10-10 20:16:43 -07:00
staging: ncpfs: memory corruption in ncp_read_kernel()
2018-03-28 18:39:23 +02:00
pNFS/flexfiles: missing error code in ff_layout_alloc_lseg()
2018-04-13 19:48:05 +02:00
lockd: fix "list_add double add" caused by legacy signal interface
2018-02-03 17:05:38 +01:00
nfsd: remove blocked locks on client teardown
2018-03-28 18:39:21 +02:00
nilfs2: fix race condition that causes file system corruption
2017-11-30 08:39:03 +00:00
fanotify: fix logic of events on child
2018-04-24 09:34:18 +02:00
fs: remove the never implemented aio_fsync file operation
2016-10-30 13:09:42 -04:00
ocfs2: try a blocking lock before return AOP_TRUNCATED_PAGE
2018-02-22 15:43:52 +01:00
Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs
2016-10-10 20:16:43 -07:00
fs: Replace CURRENT_TIME with current_time() for inode timestamps
2016-09-27 21:06:21 -04:00
orangefs_kill_sb(): deal with allocation failures
2018-04-24 09:34:17 +02:00
ovl: filter trusted xattr for non-admin
2018-04-13 19:48:12 +02:00
proc: Use underscores for SSBD in 'status'
2018-05-22 16:58:02 +02:00
pstore: Use dynamic spinlock initializer
2017-08-06 18:59:43 -07:00
quota: Check for register_shrinker() failure.
2018-02-03 17:05:39 +01:00
Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs
2016-10-10 20:16:43 -07:00
fs/reiserfs/journal.c: add missing resierfs_warning() arg
2018-04-24 09:34:09 +02:00
romfs: use different way to generate fsid for BLOCK or MTD
2017-06-17 06:41:56 +02:00
vfs: Remove {get,set,remove}xattr inode operations
2016-10-07 21:48:36 -04:00
sysfs: be careful of error returns from ops->show()
2017-04-12 12:41:11 +02:00
Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs
2016-10-10 20:16:43 -07:00
fs: Replace CURRENT_TIME with current_time() for inode timestamps
2016-09-27 21:06:21 -04:00
ubifs: Check ubifs_wbuf_sync() return code
2018-04-24 09:34:08 +02:00
udf: Fix leak of UTF-16 surrogates into encoded strings
2018-04-24 09:34:17 +02:00
ufs_getfrag_block(): we only grab ->truncate_mutex on block creation path
2017-06-14 15:06:01 +02:00
xfs: prevent creating negative-sized file via INSERT_RANGE
2018-05-09 09:50:21 +02:00
fs/aio: Use RCU accessors for kioctx_table->table[]
2018-03-22 09:18:00 +01:00
Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs
2016-10-10 20:16:43 -07:00
bad_inode: add missing i_op initializers
2017-01-09 08:32:24 +01:00
binfmt_elf: use ELF_ET_DYN_BASE only for PIE
2017-07-21 07:42:21 +02:00
elf_fdpic_transfer_args_to_stack(): make it generic
2016-07-25 16:51:49 +10:00
fs/binfmt_em86.c: fix incompatible pointer type
2016-08-02 19:35:15 -04:00
binfmt_flat: allow compressed flat binary format to work on MMU systems
2016-07-28 13:29:12 +10:00
fs: Replace current_fs_time() with current_time()
2016-09-27 21:06:22 -04:00
fs/mpage.c: fix mpage_writepage() for pages with buffers
2017-10-18 09:35:39 +02:00
fs: add i_blocksize()
2017-06-14 15:06:00 +02:00
dax: define a unified inode/address_space for device-dax mappings
2016-08-23 22:58:51 -07:00
compat: remove compat_printk()
2016-09-27 21:20:53 -04:00
binfmt_elf: compat: avoid unused function warning
2018-02-25 11:05:55 +01:00
fs: compat: Remove warning from COMPATIBLE_IOCTL
2018-04-08 12:12:44 +02:00
coredump: Ensure proper size of sparse core files
2017-07-05 14:40:26 +02:00
fs/dax.c: fix inefficiency in dax_writeback_mapping_range()
2018-02-28 10:18:33 +01:00
VFS: close race between getcwd() and d_move()
2018-04-13 19:48:09 +02:00
direct-io: Prevent NULL pointer access in submit_page_section
2017-10-18 09:35:41 +02:00
epoll: fix race between ep_poll_callback(POLLFREE) and ep_free()/ep_remove()
2017-09-07 08:35:41 +02:00
exec: Limit arg stack to at most 75% of _STK_LIM
2017-07-21 07:42:22 +02:00
fs/fcntl: f_setown, avoid undefined behaviour
2018-01-31 12:55:52 +01:00
fs/file: more unsigned file descriptors
2016-09-27 18:47:38 -04:00
bdi: Fix oops in wb_workfn()
2018-05-16 10:08:42 +02:00
xfs: evict all inodes involved with log redo item
2017-09-20 08:20:01 +02:00
xfs: evict all inodes involved with log redo item
2017-09-20 08:20:01 +02:00
vfs: cap dedupe request structure size at PAGE_SIZE
2016-09-15 13:29:52 -07:00
iomap: fix integer truncation issues in the zeroing and dirtying helpers
2017-09-20 08:19:59 +02:00
mm/hugetlb: introduce ARCH_HAS_GIGANTIC_PAGE
2016-10-07 18:46:29 -07:00
ARM: 8594/1: enable binfmt_flat on systems with an MMU
2016-08-12 16:47:05 +01:00
libfs: Modify mount_pseudo_xattr to be clear it is not a userspace mount
2017-12-09 22:01:51 +01:00
locking, fs/locks: Add missing file_sem locks
2016-10-18 12:21:28 +02:00
mbcache: initialize entry->e_referenced in mb_cache_entry_create()
2018-02-22 15:43:48 +01:00
mnt: In propgate_umount handle visiting mounts in any order
2017-07-21 07:42:22 +02:00
fs/mpage.c: fix mpage_writepage() for pages with buffers
2017-10-18 09:35:39 +02:00
getname_kernel() needs to make sure that ->name != ->iname in long case
2018-04-20 08:21:07 +02:00
Don't leak MNT_INTERNAL away from internal mounts
2018-04-24 09:34:18 +02:00
nsfs: mark dentry with DCACHE_RCUACCESS
2018-02-17 13:21:15 +01:00
fs: completely ignore unknown open flags
2017-07-12 15:01:02 +02:00
pipe: fix off-by-one error when checking buffer limits
2018-02-17 13:21:18 +01:00
mnt: Make propagate_umount less slow for overlapping mount propagation trees
2017-07-21 07:42:22 +02:00
mnt: Tuck mounts under others instead of creating shadow/side mounts.
2017-03-15 10:02:43 +08:00
tmpfs: clear S_ISGID when setting posix ACLs
2017-01-26 08:24:37 +01:00
vfs: deny copy_file_range() for non regular files
2017-10-12 11:51:26 +02:00
fs/select: add vmalloc fallback for select(2)
2016-10-11 15:06:30 -07:00
seq/proc: modify seq_put_decimal_[u]ll to take a const char *, not char
2016-10-07 18:46:30 -07:00
vfs: fix uninitialized flags in splice_to_pipe()
2017-02-23 17:44:35 +01:00
ufs: restore maintaining ->i_blocks
2017-06-14 15:06:01 +02:00
sget(): handle failures of register_shrinker()
2018-03-03 10:23:21 +01:00
timerfd: Protect the might cancel mechanism proper
2017-05-08 07:47:54 +02:00
userfaultfd: shmem: __do_fault requires VM_FAULT_NOPAGE
2017-12-20 10:07:18 +01:00
Merge remote-tracking branch 'jk/vfs' into work.misc
2016-10-08 11:06:08 -04:00
lsm: fix smack_inode_removexattr and xattr_getsecurity memleak
2017-10-12 11:51:19 +02:00
2595f213a4