Paul Blakey
952d01d70a
openvswitch: Fix setting ipv6 fields causing hw csum failure
commit d9b5ae5c1b241b91480aa30408be12fe91af834a upstream.
Ipv6 ttl, label and tos fields are modified without first
pulling/pushing the ipv6 header, which would have updated
the hw csum (if available). This might cause csum validation
when sending the packet to the stack, as can be seen in
the trace below.
Fix this by updating skb->csum if available.
Trace resulted by ipv6 ttl dec and then sending packet
to conntrack [actions: set(ipv6(hlimit=63)),ct(zone=99)]:
[295241.900063] s_pf0vf2: hw csum failure
[295241.923191] Call Trace:
[295241.925728] <IRQ>
[295241.927836] dump_stack+0x5c/0x80
[295241.931240] __skb_checksum_complete+0xac/0xc0
[295241.935778] nf_conntrack_tcp_packet+0x398/0xba0 [nf_conntrack]
[295241.953030] nf_conntrack_in+0x498/0x5e0 [nf_conntrack]
[295241.958344] __ovs_ct_lookup+0xac/0x860 [openvswitch]
[295241.968532] ovs_ct_execute+0x4a7/0x7c0 [openvswitch]
[295241.979167] do_execute_actions+0x54a/0xaa0 [openvswitch]
[295242.001482] ovs_execute_actions+0x48/0x100 [openvswitch]
[295242.006966] ovs_dp_process_packet+0x96/0x1d0 [openvswitch]
[295242.012626] ovs_vport_receive+0x6c/0xc0 [openvswitch]
[295242.028763] netdev_frame_hook+0xc0/0x180 [openvswitch]
[295242.034074] __netif_receive_skb_core+0x2ca/0xcb0
[295242.047498] netif_receive_skb_internal+0x3e/0xc0
[295242.052291] napi_gro_receive+0xba/0xe0
[295242.056231] mlx5e_handle_rx_cqe_mpwrq_rep+0x12b/0x250 [mlx5_core]
[295242.062513] mlx5e_poll_rx_cq+0xa0f/0xa30 [mlx5_core]
[295242.067669] mlx5e_napi_poll+0xe1/0x6b0 [mlx5_core]
[295242.077958] net_rx_action+0x149/0x3b0
[295242.086762] __do_softirq+0xd7/0x2d6
[295242.090427] irq_exit+0xf7/0x100
[295242.093748] do_IRQ+0x7f/0xd0
[295242.096806] common_interrupt+0xf/0xf
[295242.100559] </IRQ>
[295242.102750] RIP: 0033:0x7f9022e88cbd
[295242.125246] RSP: 002b:00007f9022282b20 EFLAGS: 00000246 ORIG_RAX: ffffffffffffffda
[295242.132900] RAX: 0000000000000005 RBX: 0000000000000010 RCX: 0000000000000000
[295242.140120] RDX: 00007f9022282ba8 RSI: 00007f9022282a30 RDI: 00007f9014005c30
[295242.147337] RBP: 00007f9014014d60 R08: 0000000000000020 R09: 00007f90254a8340
[295242.154557] R10: 00007f9022282a28 R11: 0000000000000246 R12: 0000000000000000
[295242.161775] R13: 00007f902308c000 R14: 000000000000002b R15: 00007f9022b71f40
Fixes: 3fdbd1ce11 ("openvswitch: add ipv6 'set' action")
Signed-off-by: Paul Blakey <paulb@nvidia.com>
Link: https://lore.kernel.org/r/20220223163416.24096-1-paulb@nvidia.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
2022-03-02 11:32:02 +01:00 |
| .. |
|
acpi
|
ACPI: scan: Use unique number for instance_no
|
2021-03-30 14:41:41 +02:00 |
|
asm-generic
|
hugetlbfs: flush TLBs correctly after huge_pmd_unshare
|
2021-12-08 08:45:03 +01:00 |
|
clocksource
|
|
|
|
crypto
|
crypto: public_key: fix overflow during implicit conversion
|
2021-09-22 11:43:03 +02:00 |
|
drm
|
drm: mst: Fix query_payload ack reply struct
|
2020-01-04 13:39:00 +01:00 |
|
dt-bindings
|
dt-bindings: reset: meson8b: fix duplicate reset IDs
|
2020-01-23 08:19:38 +01:00 |
|
keys
|
KEYS: user: Align the payload buffer
|
2019-02-27 10:07:00 +01:00 |
|
kvm
|
arm/arm64: KVM: Add PSCI version selection API
|
2018-05-09 09:50:19 +02:00 |
|
linux
|
net: fix information leakage in /proc/net/ptype
|
2022-02-08 18:15:27 +01:00 |
|
math-emu
|
math-emu/soft-fp.h: (_FP_ROUND_ZERO) cast 0 to void to fix warning
|
2019-12-21 10:41:02 +01:00 |
|
media
|
media: v4l2-device.h: Explicitly compare grp{id,mask} to zero in v4l2_device macros
|
2020-02-28 15:42:24 +01:00 |
|
memory
|
|
|
|
misc
|
|
|
|
net
|
openvswitch: Fix setting ipv6 fields causing hw csum failure
|
2022-03-02 11:32:02 +01:00 |
|
pcmcia
|
|
|
|
ras
|
|
|
|
rdma
|
IB/cma: Fix reference count leak when no ipv4 addresses are set
|
2020-06-03 08:16:33 +02:00 |
|
rxrpc
|
|
|
|
scsi
|
scsi: iscsi: Add iscsi_cls_conn refcount helpers
|
2021-07-20 16:21:11 +02:00 |
|
soc
|
irqchip/eznps: Fix build error for !ARC700 builds
|
2020-09-23 08:46:10 +02:00 |
|
sound
|
ALSA: compress: fix partial_drain completion state
|
2020-07-22 09:10:45 +02:00 |
|
target
|
scsi: target: Fix ordered tag handling
|
2021-11-26 11:48:41 +01:00 |
|
trace
|
memcg: fix a crash in wb_workfn when a device disappears
|
2021-02-23 13:59:15 +01:00 |
|
uapi
|
uapi: fix linux/nfc.h userspace compilation errors
|
2022-01-05 12:31:25 +01:00 |
|
video
|
udlfb: set optimal write delay
|
2018-09-09 20:01:25 +02:00 |
|
xen
|
xen: sync include/xen/interface/io/ring.h with Xen's newest version
|
2021-12-08 08:45:04 +01:00 |
|
Kbuild
|
|
|