Arnd Bergmann
8769315769
ethernet: s2io: fix setting mac address during resume ...
commit 40507e7aada8422c38aafa0c8a1a09e4623c712a upstream.
After recent cleanups, gcc started warning about a suspicious
memcpy() call during the s2io_io_resume() function:
In function '__dev_addr_set',
inlined from 'eth_hw_addr_set' at include/linux/etherdevice.h:318:2,
inlined from 's2io_set_mac_addr' at drivers/net/ethernet/neterion/s2io.c:5205:2,
inlined from 's2io_io_resume' at drivers/net/ethernet/neterion/s2io.c:8569:7:
arch/x86/include/asm/string_32.h:182:25: error: '__builtin_memcpy' accessing 6 bytes at offsets 0 and 2 overlaps 4 bytes at offset 2 [-Werror=restrict]
182 | #define memcpy(t, f, n) __builtin_memcpy(t, f, n)
| ^~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/netdevice.h:4648:9: note: in expansion of macro 'memcpy'
4648 | memcpy(dev->dev_addr, addr, len);
| ^~~~~~
What apparently happened is that an old cleanup changed the calling
conventions for s2io_set_mac_addr() from taking an ethernet address
as a character array to taking a struct sockaddr, but one of the
callers was not changed at the same time.
Change it to instead call the low-level do_s2io_prog_unicast() function
that still takes the old argument type.
Fixes: 2fd3768845https://lore.kernel.org/r/20211013143613.2049096-1-arnd@kernel.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2021-10-27 09:33:58 +02:00
ACPI: NFIT: Fix support for virtual SPA ranges
2021-08-26 08:37:22 -04:00
amba: Fix resource leak for drivers without .remove
2021-03-03 17:44:38 +01:00
binder: Prevent context manager from incrementing ref 0
2020-08-21 11:01:55 +02:00
libata: Add ATA_HORKAGE_NO_NCQ_ON_ATI for Samsung 860 and 870 SSD.
2021-10-09 13:25:59 +02:00
atm: nicstar: register the interrupt handler in the right place
2021-07-20 16:21:08 +02:00
PM / wakeirq: Fix unbalanced IRQ enable for wakeirq
2021-09-26 13:36:17 +02:00
bcma: Fix memory leak for internally-handled cores
2021-09-22 11:43:02 +02:00
cryptoloop: add a deprecation warning
2021-09-22 11:42:55 +02:00
Bluetooth: btusb: fix bt fiwmare downloading failure issue for qca btsoc.
2021-07-20 16:21:08 +02:00
bus: qcom: Put child node before return
2021-05-22 10:40:23 +02:00
cdrom: gdrom: initialize global variable at init time
2021-05-26 11:29:07 +02:00
virtio_console: Assure used length from device is limited
2021-07-20 16:21:14 +02:00
clk: kirkwood: Fix a clocking boot regression
2021-09-22 11:43:02 +02:00
clocksource/drivers/mxs_timer: Add missing semicolon when DEBUG is defined
2021-03-03 17:44:37 +01:00
cpufreq: schedutil: Destroy mutex before kobject_put() frees the memory
2021-10-06 10:23:41 +02:00
cpuidle: Fix three reference count leaks
2020-06-20 10:24:18 +02:00
crypto: talitos - fix max key size for sha384 and sha512
2021-09-26 13:36:17 +02:00
PM / devfreq: tegra30: Fix integer overflow on CPU's freq max out
2020-10-01 20:40:02 +02:00
dmaengine: xilinx_dma: Set DMA mask for coherent APIs
2021-09-26 13:36:18 +02:00
EDAC/synopsys: Fix wrong value type assignment for edac_mode
2021-10-06 10:23:42 +02:00
extcon: max8997: Add missing modalias string
2021-07-20 16:21:05 +02:00
firewire: nosy: Fix a use-after-free bug in nosy_ioctl()
2021-04-07 12:05:40 +02:00
efi: Change down_interruptible() in virt_efi_reset_system() to down_trylock()
2021-10-27 09:33:57 +02:00
gpio: zynq: Check return value of pm_runtime_get_sync
2021-07-20 16:21:12 +02:00
drm/nouveau/debugfs: fix file release memory leak
2021-10-17 10:05:39 +02:00
HID: apple: Fix logical maximum and usage maximum of Magic Keyboard JIS
2021-10-17 10:05:40 +02:00
HSI: core: fix resource leaks in hsi_add_client_from_dt()
2021-05-22 10:40:26 +02:00
Drivers: hv: vmbus: Increase wait time for VMbus unload
2021-05-22 10:40:24 +02:00
hwmon: (tmp421) fix rounding for negative values
2021-10-06 10:23:41 +02:00
intel_th: Consistency and off-by-one fix
2021-05-22 10:40:16 +02:00
i2c: mt65xx: fix IRQ check
2021-09-22 11:43:02 +02:00
block: Move SECTOR_SIZE and SECTOR_SHIFT definitions into <linux/blkdev.h>
2020-09-12 11:47:36 +02:00
iio: ssp_sensors: fix error code in ssp_print_mcu_debug()
2021-10-27 09:33:58 +02:00
IB/hfi1: Fix possible null-pointer dereference in _extend_sdma_tx_descs()
2021-09-03 09:44:40 +02:00
Input: xpad - add support for another USB ID of Nacon GC-100
2021-10-27 09:33:57 +02:00
iommu/amd: Fix backport of 140456f994195b568ecd7fc2287a34eadffef3ca
2021-08-04 11:58:01 +02:00
ipack: ipoctal: fix module reference leak
2021-10-06 10:23:42 +02:00
irqchip/alpine-msi: Fix freeing of interrupts on allocation error path
2020-12-29 13:45:00 +01:00
mISDN: fix possible use-after-free in HFC_cleanup()
2021-07-20 16:21:06 +02:00
leds: ktd2692: Fix an error handling path
2021-07-20 16:21:05 +02:00
drivers/macintosh: Fix memleak in windfarm_pm112 driver
2020-06-20 10:24:21 +02:00
mcb: fix error handling in mcb_alloc_bus()
2021-10-06 10:23:39 +02:00
dm btree remove: assign new_root only when removal succeeds
2021-07-20 16:21:10 +02:00
media: rc-loopback: return number of emitters rather than error
2021-09-22 11:43:03 +02:00
memory: fsl_ifc: fix leak of private memory on probe failure
2021-07-20 16:21:15 +02:00
memstick: r592: Fix error return in r592_probe()
2020-12-29 13:44:58 +01:00
scsi: mptfusion: Fix null pointer dereferences in mptscsih_remove()
2020-11-10 10:23:57 +01:00
mfd: Don't use irq_create_mapping() to resolve a mapping
2021-09-22 11:43:10 +02:00
cb710: avoid NULL pointer subtraction
2021-10-27 09:33:57 +02:00
mmc: rtsx_pci: Fix long reads when clock is prescaled
2021-09-22 11:43:07 +02:00
mtd: rawnand: cafe: Fix a resource leak in the error handling path of 'cafe_nand_probe()'
2021-09-22 11:43:10 +02:00
ethernet: s2io: fix setting mac address during resume
2021-10-27 09:33:58 +02:00
nfc: nfcsim: fix use after free during module unload
2021-08-04 11:58:03 +02:00
NTB: hw: amd: fix an issue about leak system resources
2020-10-29 09:05:41 +01:00
libnvdimm/dimm: Avoid race between probe and available_slots_show()
2021-03-03 17:44:44 +01:00
nvme-pci: Fix an error handling path in 'nvme_probe()'
2021-09-22 11:42:57 +02:00
nvmem: Fix shift-out-of-bound (UBSAN) with byte size cells
2021-10-27 09:33:58 +02:00
of: Fix truncation of memory sizes on 32-bit platforms
2021-07-20 16:21:05 +02:00
parisc: Move pci_dev_is_behind_card_dino to where it is used
2021-09-26 13:36:18 +02:00
parport: remove non-zero check on count
2021-09-22 11:43:07 +02:00
PCI: Use pci_update_current_state() in pci_enable_device_flags()
2021-09-22 11:43:04 +02:00
pcmcia: i82092: fix a null pointer dereference bug
2021-08-15 13:01:03 +02:00
phy: ti: dm816x: Fix the error handling path in 'dm816x_usb_phy_probe()
2021-07-20 16:21:05 +02:00
pinctrl: single: Fix error return code in pcs_parse_bits_in_pinctrl_entry()
2021-09-22 11:43:04 +02:00
platform/chrome: cros_ec_proto: Send command again when timeout occurs
2021-09-22 11:43:08 +02:00
power: supply: max17042: handle fails of reading status register
2021-09-22 11:43:03 +02:00
powercap: restrict energy meter to root access
2020-11-10 21:04:57 +01:00
powerpc/ps3: use dma_mapping_error()
2020-12-29 13:45:00 +01:00
ptp_pch: Load module automatically if ID matches
2021-10-17 10:05:39 +02:00
pwm: lpc32xx: Don't modify HW state in .probe() after the PWM chip was registered
2021-09-26 13:36:18 +02:00
rapidio: handle create_workqueue() failure
2021-05-26 11:29:06 +02:00
regulator: da9052: Ensure enough delay time for .set_voltage_time_sel
2021-07-20 16:20:59 +02:00
remoteproc: qcom_q6v5_mss: Validate MBA firmware size before load
2021-02-23 13:59:14 +01:00
reset: ti-syscon: fix to_ti_syscon_reset_data macro
2021-07-28 09:14:24 +02:00
rtc: tps65910: Correct driver module alias
2021-09-22 11:43:02 +02:00
s390/sclp_vt220: fix console name to match device
2021-07-20 16:21:11 +02:00
scsi: virtio_scsi: Fix spelling mistake "Unsupport" -> "Unsupported"
2021-10-17 10:05:40 +02:00
soc: qcom: smsm: Fix missed interrupts if state changes while masked
2021-09-22 11:43:00 +02:00
spi: Fix tegra20 build with CONFIG_PM=n
2021-10-06 10:23:40 +02:00
ssb: sdio: Don't overwrite const buffer if block_write fails
2021-07-20 16:20:57 +02:00
staging: greybus: uart: fix tty use after free
2021-10-06 10:23:39 +02:00
scsi: target: Fix protect handling in WRITE SAME(32)
2021-07-28 09:14:27 +02:00
thermal/drivers/exynos: Fix an error code in exynos_tmu_probe()
2021-09-26 13:36:18 +02:00
tty: Fix out-of-bound vmalloc access in imageblit
2021-10-06 10:23:41 +02:00
uio_pdrv_genirq: fix use without device tree and no interrupt
2020-07-22 09:10:53 +02:00
USB: serial: option: add Telit LE910Cx composition 0x1204
2021-10-27 09:33:58 +02:00
vfio: Use config not menuconfig for VFIO_NOIOMMU
2021-09-22 11:43:04 +02:00
vringh: Use wiov->used to check for read/write desc order
2021-09-03 09:44:40 +02:00
video: fbdev: riva: Error out if 'pixclock' equals zero
2021-09-22 11:43:05 +02:00
drivers/virt/fsl_hypervisor: Fix error handling path
2020-10-29 09:05:35 +01:00
virtio: Improve vq->broken access to avoid any compiler optimization
2021-09-03 09:44:40 +02:00
vme: bridges: reduce stack usage
2020-02-28 15:42:33 +01:00
w1: mxc_w1: Fix timeout resolution problem leading to bus error
2020-11-10 10:23:57 +01:00
watchdog: aspeed: fix hardware timeout calculation
2021-07-20 16:21:14 +02:00
xen/events: Fix race in set_evtchn_to_irq
2021-08-26 08:37:23 -04:00
8769315769