android_kernel_sony_sdm845/arch/x86/kernel/apic
Repository files (latest commit first)
Filename Latest commit message Latest commit date
Nicolai Stange 8574df1a87 x86: Don't include linux/irq.h from asm/hardirq.h
commit 447ae316670230d7d29430e2cbf1f5db4f49d14c upstream

The next patch in this series will have to make the definition of
irq_cpustat_t available to entering_irq().

Inclusion of asm/hardirq.h into asm/apic.h would cause circular header
dependencies like

  asm/smp.h
    asm/apic.h
      asm/hardirq.h
        linux/irq.h
          linux/topology.h
            linux/smp.h
              asm/smp.h

or

  linux/gfp.h
    linux/mmzone.h
      asm/mmzone.h
        asm/mmzone_64.h
          asm/smp.h
            asm/apic.h
              asm/hardirq.h
                linux/irq.h
                  linux/irqdesc.h
                    linux/kobject.h
                      linux/sysfs.h
                        linux/kernfs.h
                          linux/idr.h
                            linux/gfp.h

and others.

This causes compilation errors because of the header guards becoming
effective in the second inclusion: symbols/macros that had been defined
before wouldn't be available to intermediate headers in the #include chain
anymore.

A possible workaround would be to move the definition of irq_cpustat_t
into its own header and include that from both, asm/hardirq.h and
asm/apic.h.

However, this wouldn't solve the real problem, namely asm/harirq.h
unnecessarily pulling in all the linux/irq.h cruft: nothing in
asm/hardirq.h itself requires it. Also, note that there are some other
archs, like e.g. arm64, which don't have that #include in their
asm/hardirq.h.

Remove the linux/irq.h #include from x86' asm/hardirq.h.

Fix resulting compilation errors by adding appropriate #includes to *.c
files as needed.

Note that some of these *.c files could be cleaned up a bit wrt. to their
set of #includes, but that should better be done from separate patches, if
at all.

Signed-off-by: Nicolai Stange <nstange@suse.de>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
[dwmw2: More fixes for EFI and Xen in 4.9]
Signed-off-by: David Woodhouse <dwmw@amazon.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2018-08-15 18:14:52 +02:00
..
apic.c x86: Don't include linux/irq.h from asm/hardirq.h 2018-08-15 18:14:52 +02:00
apic_flat_64.c Merge branch 'x86-cleanups-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip 2016-10-03 17:18:52 -07:00
apic_noop.c x86: Apply more __ro_after_init and const 2016-08-10 14:55:05 +02:00
apic_numachip.c x86: Clean up various simple wrapper functions 2016-09-13 20:42:58 +02:00
bigsmp_32.c x86: Apply more __ro_after_init and const 2016-08-10 14:55:05 +02:00
htirq.c x86: Don't include linux/irq.h from asm/hardirq.h 2018-08-15 18:14:52 +02:00
hw_nmi.c nmi_backtrace: add more trigger_*_cpu_backtrace() methods 2016-10-07 18:46:30 -07:00
io_apic.c x86: Don't include linux/irq.h from asm/hardirq.h 2018-08-15 18:14:52 +02:00
ipi.c x86/kernel: Audit and remove any unnecessary uses of module.h 2016-07-14 15:06:41 +02:00
Makefile kernel: add kcov code coverage 2016-03-22 15:36:02 -07:00
msi.c x86: Don't include linux/irq.h from asm/hardirq.h 2018-08-15 18:14:52 +02:00
probe_32.c Merge branch 'x86-asm-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip 2016-10-03 16:13:28 -07:00
probe_64.c x86/apic: Remove duplicated include from probe_64.c 2016-07-19 16:02:31 +02:00
vector.c x86: Don't include linux/irq.h from asm/hardirq.h 2018-08-15 18:14:52 +02:00
x2apic_cluster.c Merge branch 'x86/mm' into x86/asm, to unify the two branches for simplicity 2016-09-08 08:41:52 +02:00
x2apic_phys.c x86: Apply more __ro_after_init and const 2016-08-10 14:55:05 +02:00
x2apic_uv_x.c x86/apic/uv: Silence a shift wrapping warning 2016-11-24 06:01:05 +01:00