Namhyung Kim
de65c300c7
perf diff: Fix segfault on 'perf diff -o N' option
...
commit 8381cdd0e32dd748bd34ca3ace476949948bd793 upstream.
The -o/--order option is to select column number to sort a diff result.
It does the job by adding a hpp field at the beginning of the sort list.
But it should not be added to the output field list as it has no
callbacks required by a output field.
During the setup_sorting(), the perf_hpp__setup_output_field() appends
the given sort keys to the output field if it's not there already.
Originally it was checked by fmt->list being non-empty. But commit
3f931f2c42 ("perf hists: Make hpp setup function generic") changed it
to check the ->equal callback.
Anyways, we don't need to add the pseudo hpp field to the output field
list since it won't be used for output. So just skip fields if they
have no ->color or ->entry callbacks.
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
Acked-by: Jiri Olsa <jolsa@kernel.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Fixes: 3f931f2c42 ("perf hists: Make hpp setup function generic")
Link: http://lkml.kernel.org/r/20170118051457.30946-1-namhyung@kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2017-02-14 15:25:42 -08:00
..
arch
perf uretprobe ppc64le: Fix probe location
2016-10-05 08:14:22 -03:00
bench
perf bench futex: Use NSEC_PER_USEC
2016-08-23 15:37:33 -03:00
Documentation
perf top/report: Add tips about a list option
2016-10-05 19:51:53 -03:00
jvmti
perf jit: Fix build issue on Ubuntu
2016-10-17 11:25:34 -03:00
pmu-events
perf jevents: Fix Intel JSON fixed counter conversions
2016-10-05 18:41:06 -03:00
python
perf python: Add tracepoint example
2016-07-12 16:23:35 -03:00
scripts
perf/core improvements and fixes:
2016-08-04 11:02:38 +02:00
tests
perf tests: Add dwarf unwind test for powerpc
2016-09-29 11:18:21 -03:00
trace
perf trace: Check if MAP_32BIT is defined (again)
2017-01-26 08:24:36 +01:00
ui
perf diff: Fix segfault on 'perf diff -o N' option
2017-02-14 15:25:42 -08:00
util
perf diff: Fix -o/--order option behavior (again)
2017-02-14 15:25:42 -08:00
.gitignore
perf tools: Add arch/*/include/generated/ to .gitignore
2016-05-30 12:41:46 -03:00
Build
perf tools: Set and pass DOCDIR to builtin-report.c
2016-01-12 12:42:07 -03:00
builtin-annotate.c
perf annotate: Add branch stack / basic block
2016-09-08 13:44:03 -03:00
builtin-bench.c
perf subcmd: Create subcmd library
2015-12-17 14:27:14 -03:00
builtin-buildid-cache.c
tools: Introduce str_error_r()
2016-07-12 15:19:47 -03:00
builtin-buildid-list.c
perf subcmd: Create subcmd library
2015-12-17 14:27:14 -03:00
builtin-config.c
perf config: Reimplement show_config() using config_set__for_each
2016-06-23 17:23:00 -03:00
builtin-data.c
perf data ctf: Add '--all' option for 'perf data convert'
2016-06-28 10:54:57 -03:00
builtin-diff.c
perf diff: Fix -o/--order option behavior (again)
2017-02-14 15:25:42 -08:00
builtin-evlist.c
perf evlist: Rename for_each() macros to for_each_entry()
2016-06-23 11:26:15 -03:00
builtin-help.c
tools: Introduce str_error_r()
2016-07-12 15:19:47 -03:00
builtin-inject.c
perf symbols: Remove symbol_filter_t machinery
2016-09-05 11:14:50 -03:00
builtin-kmem.c
perf symbols: Remove symbol_filter_t machinery
2016-09-05 11:14:50 -03:00
builtin-kvm.c
perf kvm: Use NSEC_PER_USEC
2016-08-23 15:37:33 -03:00
builtin-list.c
perf list: Support long jevents descriptions
2016-10-03 21:35:47 -03:00
builtin-lock.c
perf subcmd: Create subcmd library
2015-12-17 14:27:14 -03:00
builtin-mem.c
perf mem: Fix --all-user/--all-kernel options
2017-01-26 08:24:35 +01:00
builtin-probe.c
perf probe: Ignore vmlinux Build-id when offline vmlinux given
2016-09-01 12:42:22 -03:00
builtin-record.c
perf record: Add support for using symbols in address filters
2016-09-29 11:17:02 -03:00
builtin-report.c
perf report: Enable group view with hierarchy
2016-09-13 16:43:41 -03:00
builtin-sched.c
perf sched: Use linux/time64.h
2016-08-23 15:37:33 -03:00
builtin-script.c
perf symbols: Remove symbol_filter_t machinery
2016-09-05 11:14:50 -03:00
builtin-stat.c
perf tools: Add PMU configuration to tools
2016-09-22 13:07:36 -03:00
builtin-timechart.c
perf timechart: Use NSEC_PER_U?SEC
2016-08-23 15:37:33 -03:00
builtin-top.c
perf tools: Add PMU configuration to tools
2016-09-22 13:07:36 -03:00
builtin-trace.c
perf trace: Use the syscall raw_syscalls:sys_enter timestamp
2017-01-26 08:24:35 +01:00
builtin-version.c
perf tools: Move cmd_version() to builtin-version.c
2015-12-09 13:42:03 -03:00
builtin.h
perf tools: Remove needless 'extern' from function prototypes
2016-03-23 15:06:35 -03:00
command-list.txt
perf tools: Do not show trace command if it's not compiled in
2016-01-08 12:46:17 -03:00
CREDITS
design.txt
Makefile
perf build tests: Do parallell builds with 'build-test'
2016-02-04 15:57:00 -03:00
Makefile.config
perf jit: Enable jitdump support without dwarf
2017-01-26 08:24:36 +01:00
Makefile.perf
perf jevents: Program to convert JSON file
2016-10-03 19:55:55 -03:00
MANIFEST
tools include: Add uapi mman.h for each architecture
2016-09-13 15:26:08 -03:00
perf-archive.sh
perf-completion.sh
perf tools: Avoid confusion with preloaded bash function for perf bash completion
2015-03-19 13:53:27 -03:00
perf-read-vdso.c
perf tools: Build programs to copy 32-bit compatibility
2014-10-29 10:32:48 -02:00
perf-sys.h
perf powerpc: Fix build-test failure
2016-09-08 13:44:07 -03:00
perf-with-kcore.sh
perf tools: Fix perf-with-kcore handling of arguments containing spaces
2015-08-06 16:48:27 -03:00
perf.c
perf tools: Just pr_debug() about not being able to read cacheline_size
2016-07-15 10:08:29 -03:00
perf.h
tools: Introduce tools/include/linux/time64.h for *SEC_PER_*SEC macros
2016-08-23 15:37:33 -03:00