Andrew Morton
795d45b22c
x86: fix RTC lockdep warning: potential hardirq recursion
After disabling both CONFIG_DEBUG_LOCKING_API_SELFTESTS and netconsole
(using current mainline) I get a login prompt, and also...
[ 5.181668] SELinux: policy loaded with handle_unknown=deny
[ 5.183315] type=1403 audit(1202100038.157:3): policy loaded auid=4294967295 ses=4294967295
[ 5.822073] SELinux: initialized (dev usbfs, type usbfs), uses genfs_contexts
[ 7.819146] ------------[ cut here ]------------
[ 7.819146] WARNING: at kernel/lockdep.c:2033 trace_hardirqs_on+0x9b/0x10d()
[ 7.819146] Modules linked in: generic ext3 jbd ide_disk ide_core
[ 7.819146] Pid: 399, comm: hwclock Not tainted 2.6.24 #4
[ 7.819146] [<c011d140>] warn_on_slowpath+0x41/0x51
[ 7.819146] [<c01364a9>] ? lock_release_holdtime+0x50/0x56
[ 7.819146] [<c013770c>] ? check_usage_forwards+0x19/0x3b
[ 7.819146] [<c01390c4>] ? __lock_acquire+0xac3/0xb0b
[ 7.819146] [<c0108c98>] ? native_sched_clock+0x8b/0x9f
[ 7.819146] [<c01364a9>] ? lock_release_holdtime+0x50/0x56
[ 7.819146] [<c030ca6c>] ? _spin_unlock_irq+0x22/0x42
[ 7.819146] [<c013848b>] trace_hardirqs_on+0x9b/0x10d
[ 7.819146] [<c030ca6c>] _spin_unlock_irq+0x22/0x42
[ 7.819146] [<c011481e>] hpet_rtc_interrupt+0xdf/0x290
[ 7.819146] [<c014ea90>] handle_IRQ_event+0x1a/0x46
[ 7.819146] [<c014f8ea>] handle_edge_irq+0xbe/0xff
[ 7.819146] [<c0106e08>] do_IRQ+0x6d/0x84
[ 7.819146] [<c0105596>] common_interrupt+0x2e/0x34
[ 7.819146] [<c013007b>] ? ktime_get_ts+0x8/0x3f
[ 7.819146] [<c0139420>] ? lock_release+0x167/0x16f
[ 7.819146] [<c017974a>] ? core_sys_select+0x2c/0x327
[ 7.819146] [<c0179792>] core_sys_select+0x74/0x327
[ 7.819146] [<c0108c98>] ? native_sched_clock+0x8b/0x9f
[ 7.819146] [<c01364a9>] ? lock_release_holdtime+0x50/0x56
[ 7.819146] [<c030ca6c>] ? _spin_unlock_irq+0x22/0x42
[ 7.819146] [<c01384d6>] ? trace_hardirqs_on+0xe6/0x10d
[ 7.819146] [<c030ca77>] ? _spin_unlock_irq+0x2d/0x42
[ 7.819146] [<c023b437>] ? rtc_do_ioctl+0x11b/0x677
[ 7.819146] [<c01c487e>] ? inode_has_perm+0x5e/0x68
[ 7.819146] [<c01364a9>] ? lock_release_holdtime+0x50/0x56
[ 7.819146] [<c0108c98>] ? native_sched_clock+0x8b/0x9f
[ 7.819146] [<c01c490b>] ? file_has_perm+0x83/0x8c
[ 7.819146] [<c023ba08>] ? rtc_ioctl+0xf/0x11
[ 7.819146] [<c017898d>] ? do_ioctl+0x55/0x67
[ 7.819146] [<c0179d15>] sys_select+0x93/0x163
[ 7.819146] [<c0104b39>] ? sysenter_past_esp+0x9a/0xa5
[ 7.819146] [<c0104afe>] sysenter_past_esp+0x5f/0xa5
[ 7.819146] =======================
[ 7.819146] ---[ end trace 96540ca301ffb84c ]---
[ 7.819210] rtc: lost 6 interrupts
[ 7.870668] type=1400 audit(1202128840.794:4): avc: denied { audit_write } for pid=399 comm="hwclock" capability=29 scontext=system_u:system_r:hwclock_t:s0 tcontext=system_u:system_r:hwclock_t:s0 tclass=capability
[ 9.538866] input: PC Speaker as /class/input/input5
Because hpet_rtc_interrupt()'s call to get_rtc_time() ends up
resolving to include/asm-generic/rtc.h's (hilariously inlined)
get_rtc_time(), which does spin_unlock_irq() from hard IRQ context.
The obvious patch fixes it.
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
|
2008-02-04 16:48:10 +01:00 |
| .. |
|
bitops
|
ext4: Add ext4_find_next_bit()
|
2008-01-28 23:58:27 -05:00 |
|
4level-fixup.h
|
[PATCH] Standardize pxx_page macros
|
2006-09-26 08:48:51 -07:00 |
|
atomic.h
|
atomic.h: atomic_add_unless as inline. Remove system.h atomic.h circular dependency
|
2007-05-08 11:15:20 -07:00 |
|
audit_change_attr.h
|
[PATCH] fix missing ifdefs in syscall classes hookup for generic targets
|
2006-09-22 17:48:56 -07:00 |
|
audit_dir_write.h
|
[PATCH] fix missing ifdefs in syscall classes hookup for generic targets
|
2006-09-22 17:48:56 -07:00 |
|
audit_read.h
|
[PATCH] audit: more syscall classes added
|
2006-09-11 13:32:27 -04:00 |
|
audit_signal.h
|
[PATCH] add SIGNAL syscall class (v3)
|
2007-05-11 05:38:25 -04:00 |
|
audit_write.h
|
[PATCH] audit: more syscall classes added
|
2006-09-11 13:32:27 -04:00 |
|
bitops.h
|
forbid asm/bitops.h direct inclusion
|
2007-10-19 11:53:41 -07:00 |
|
bug.h
|
debug: move WARN_ON() out of line
|
2008-01-30 13:32:50 +01:00 |
|
cputime.h
|
[CPUFREQ] Remove slowdown from ondemand sampling path.
|
2006-06-30 01:29:47 -04:00 |
|
device.h
|
Driver core: add dev_archdata to struct device
|
2006-12-01 14:52:01 -08:00 |
|
div64.h
|
[NET]: div64_64 consolidate (rev3)
|
2007-04-25 22:23:33 -07:00 |
|
dma-mapping-broken.h
|
dma-mapping: prevent dma dependent code from linking on !HAS_DMA archs
|
2007-07-16 09:05:45 -07:00 |
|
dma-mapping.h
|
[PATCH] Pass struct dev pointer to dma_cache_sync()
|
2006-12-07 08:39:41 -08:00 |
|
emergency-restart.h
|
[PATCH] Add emergency_restart()
|
2005-07-26 14:35:41 -07:00 |
|
errno-base.h
|
Linux-2.6.12-rc2
|
2005-04-16 15:20:36 -07:00 |
|
errno.h
|
[PATCH] add EOWNERDEAD and ENOTRECOVERABLE version 2
|
2005-05-01 08:59:06 -07:00 |
|
fcntl.h
|
Introduce O_CLOEXEC
|
2007-07-16 09:05:45 -07:00 |
|
futex.h
|
[PATCH] mm: pagefault_{disable,enable}()
|
2006-12-07 08:39:21 -08:00 |
|
gpio.h
|
[PATCH] GPIO core
|
2007-02-12 09:48:34 -08:00 |
|
ide_iops.h
|
Linux-2.6.12-rc2
|
2005-04-16 15:20:36 -07:00 |
|
ioctl.h
|
[PATCH] Generic ioctl.h
|
2006-01-10 08:01:34 -08:00 |
|
iomap.h
|
[PATCH] add Big Endian variants of ioread/iowrite
|
2005-04-16 15:25:54 -07:00 |
|
irq_regs.h
|
IRQ: Maintain regs pointer globally rather than passing to IRQ handlers
|
2006-10-05 15:10:12 +01:00 |
|
Kbuild
|
remove include/asm-*/ipc.h
|
2007-10-17 08:42:55 -07:00 |
|
Kbuild.asm
|
unexport asm/shmparam.h
|
2007-10-17 08:42:47 -07:00 |
|
kdebug.h
|
move die notifier handling to common code
|
2007-05-08 11:15:04 -07:00 |
|
libata-portmap.h
|
libata-portmap: Remove unused definitions
|
2007-10-12 14:55:37 -04:00 |
|
local.h
|
local_t: architecture independent extension
|
2007-05-08 11:15:20 -07:00 |
|
memory_model.h
|
Generic Virtual Memmap support for SPARSEMEM
|
2007-10-16 09:42:51 -07:00 |
|
mm_hooks.h
|
[PATCH] x86: PARAVIRT: add hooks to intercept mm creation and destruction
|
2007-05-02 19:27:14 +02:00 |
|
mman.h
|
[PATCH] Remove final references to deprecated "MAP_ANON" page protection flag
|
2007-02-11 10:51:17 -08:00 |
|
mutex-dec.h
|
fix file specification in comments
|
2006-10-03 23:01:26 +02:00 |
|
mutex-null.h
|
fix file specification in comments
|
2006-10-03 23:01:26 +02:00 |
|
mutex-xchg.h
|
fix file specification in comments
|
2006-10-03 23:01:26 +02:00 |
|
page.h
|
Revert "[PATCH] LOG2: Alter get_order() so that it can make use of ilog2() on a constant"
|
2007-03-06 19:38:01 -08:00 |
|
pci-dma-compat.h
|
Linux-2.6.12-rc2
|
2005-04-16 15:20:36 -07:00 |
|
pci.h
|
[PATCH] Make sparc64 use setup-res.c
|
2005-09-08 14:57:25 -07:00 |
|
percpu.h
|
x86/non-x86: percpu, node ids, apic ids x86.git fixup
|
2008-01-30 13:33:32 +01:00 |
|
pgtable-nopmd.h
|
[PATCH] Standardize pxx_page macros
|
2006-09-26 08:48:51 -07:00 |
|
pgtable-nopud.h
|
[PATCH] Standardize pxx_page macros
|
2006-09-26 08:48:51 -07:00 |
|
pgtable.h
|
flush icache before set_pte() on ia64: flush icache at set_pte
|
2007-10-16 09:42:59 -07:00 |
|
poll.h
|
Consolidate asm/poll.h
|
2007-05-11 08:29:34 -07:00 |
|
resource.h
|
sched: SCHED_FIFO/SCHED_RR watchdog timer
|
2008-01-25 21:08:27 +01:00 |
|
rtc.h
|
x86: fix RTC lockdep warning: potential hardirq recursion
|
2008-02-04 16:48:10 +01:00 |
|
sections.h
|
[PATCH] add __[start|end]_rodata sections to asm-generic/sections.h
|
2006-07-01 09:56:03 -07:00 |
|
siginfo.h
|
[PATCH] consolidate SIGEV_PAD_SIZE
|
2005-05-01 08:59:08 -07:00 |
|
signal.h
|
Add standard include guard to asm-generic/signal and use compiler.h
|
2006-04-27 06:57:23 +01:00 |
|
statfs.h
|
Linux-2.6.12-rc2
|
2005-04-16 15:20:36 -07:00 |
|
termios.h
|
Define termios_1 functions for powerpc, s390, avr32 and frv
|
2007-09-12 09:08:05 -07:00 |
|
tlb.h
|
asm-generic/tlb.h: remove <linux/quicklist.h>
|
2008-02-04 16:48:00 +01:00 |
|
topology.h
|
[PATCH] x86/x86_64: pcibus_to_node
|
2005-06-23 09:45:08 -07:00 |
|
uaccess.h
|
Linux-2.6.12-rc2
|
2005-04-16 15:20:36 -07:00 |
|
unaligned.h
|
use __val in __get_unaligned
|
2007-07-31 15:39:42 -07:00 |
|
vmlinux.lds.h
|
x86: add testcases for RODATA and NX protections/attributes
|
2008-01-30 13:34:08 +01:00 |
|
xor.h
|
Linux-2.6.12-rc2
|
2005-04-16 15:20:36 -07:00 |