android_kernel_sony_sdm845/drivers/android
Repository files (latest commit first)
Filename Latest commit message Latest commit date
Arnd Bergmann 0b29147bf6 UPSTREAM: android: binder: fix type mismatch warning
Allowing binder to expose the 64-bit API on 32-bit kernels caused a
build warning:

drivers/android/binder.c: In function 'binder_transaction_buffer_release':
drivers/android/binder.c:2220:15: error: cast to pointer from integer of different size [-Werror=int-to-pointer-cast]
    fd_array = (u32 *)(parent_buffer + fda->parent_offset);
               ^
drivers/android/binder.c: In function 'binder_translate_fd_array':
drivers/android/binder.c:2445:13: error: cast to pointer from integer of different size [-Werror=int-to-pointer-cast]
  fd_array = (u32 *)(parent_buffer + fda->parent_offset);
             ^
drivers/android/binder.c: In function 'binder_fixup_parent':
drivers/android/binder.c:2511:18: error: cast to pointer from integer of different size [-Werror=int-to-pointer-cast]

This adds extra type casts to avoid the warning.

However, there is another problem with the Kconfig option: turning
it on or off creates two incompatible ABI versions, a kernel that
has this enabled cannot run user space that was built without it
or vice versa. A better solution might be to leave the option hidden
until the binder code is fixed to deal with both ABI versions.

Change-Id: Id09185a6f86905926699e92a2b30201b8a5e83e5
Fixes: e8d2ed7db7c3 ("Revert "staging: Fix build issues with new binder API"")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
(cherry picked from commit 1c363eaece2752c5f8b1b874cb4ae435de06aa66)
Git-commit: e312c3fce3
Git-repo: https://android.googlesource.com/kernel/common
Signed-off-by: Kyle Yan <kyan@codeaurora.org>
2017-11-30 13:28:34 -08:00
..
binder.c UPSTREAM: android: binder: fix type mismatch warning 2017-11-30 13:28:34 -08:00
binder_alloc.c FROMLIST: android: binder: Fix null ptr dereference in debug msg 2017-10-30 11:36:23 -07:00
binder_alloc.h FROMLIST: android: binder: Don't get mm from task 2017-09-21 18:53:05 +00:00
binder_alloc_selftest.c FROMLIST: android: binder: Add global lru shrinker to binder 2017-08-31 17:06:14 -07:00
binder_trace.h ANDROID: binder: Add tracing for binder priority inheritance. 2017-10-05 10:03:07 +02:00
Kconfig FROMLIST: android: binder: Add allocator selftest 2017-08-31 17:06:00 -07:00
Makefile FROMLIST: android: binder: Add allocator selftest 2017-08-31 17:06:00 -07:00