Jin Yao
61415418cd
perf annotate: Fix broken arrow at row 0 connecting jmp instruction to its target
commit 80f62589fa52f530cffc50e78c0b5a2ae572d61e upstream.
When the jump instruction is displayed at the row 0 in annotate view,
the arrow is broken. An example:
16.86 │ ┌──je 82
0.01 │ movsd (%rsp),%xmm0
│ movsd 0x8(%rsp),%xmm4
│ movsd 0x8(%rsp),%xmm1
│ movsd (%rsp),%xmm3
│ divsd %xmm4,%xmm0
│ divsd %xmm3,%xmm1
│ movsd (%rsp),%xmm2
│ addsd %xmm1,%xmm0
│ addsd %xmm2,%xmm0
│ movsd %xmm0,(%rsp)
│82: sub $0x1,%ebx
83.03 │ ↑ jne 38
│ add $0x10,%rsp
│ xor %eax,%eax
│ pop %rbx
│ ← retq
The patch increments the row number before checking with 0.
Signed-off-by: Yao Jin <yao.jin@linux.intel.com>
Tested-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Andi Kleen <ak@linux.intel.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Kan Liang <kan.liang@intel.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Fixes: 944e1abed9 ("perf ui browser: Add method to draw up/down arrow line")
Link: http://lkml.kernel.org/r/1496901704-30275-1-git-send-email-yao.jin@linux.intel.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
2017-07-27 15:08:06 -07:00 |
| .. |
|
browsers
|
perf hists browser: Fix column indentation on --hierarchy
|
2016-11-09 11:45:58 -03:00 |
|
gtk
|
perf hists: Add support for header span
|
2016-08-23 15:37:33 -03:00 |
|
stdio
|
perf hists: Make hists__fprintf_headers function global
|
2016-09-22 13:08:59 -03:00 |
|
tui
|
perf tools: Remove needless includes from cache.h
|
2016-07-12 15:19:58 -03:00 |
|
browser.c
|
perf annotate: Fix broken arrow at row 0 connecting jmp instruction to its target
|
2017-07-27 15:08:06 -07:00 |
|
browser.h
|
perf annotate: Rename 'colors.code' to 'colors.jump_arrows'
|
2016-01-26 11:52:46 -03:00 |
|
Build
|
perf build: Add slang objects building
|
2015-02-12 11:48:13 -03:00 |
|
helpline.c
|
perf tools: Remove needless includes from cache.h
|
2016-07-12 15:19:58 -03:00 |
|
helpline.h
|
perf ui/helpline: Introduce ui_helpline__vshow()
|
2012-12-09 08:46:04 -03:00 |
|
hist.c
|
perf diff: Fix segfault on 'perf diff -o N' option
|
2017-02-14 15:25:42 -08:00 |
|
keysyms.h
|
perf hists browser: Add option for runtime switching perf data file
|
2013-02-06 18:09:24 -03:00 |
|
libslang.h
|
perf ui browser: Introduce ui_browser__printf()
|
2015-08-12 10:27:05 -03:00 |
|
progress.c
|
perf ui progress: Per progress bar state
|
2013-10-23 15:40:38 -03:00 |
|
progress.h
|
perf tools: Remove EOL whitespaces
|
2015-01-21 13:24:31 -03:00 |
|
setup.c
|
perf ui stdio: Add way to setup the color output mode selection
|
2016-07-12 00:00:39 -03:00 |
|
ui.h
|
perf ui stdio: Add way to setup the color output mode selection
|
2016-07-12 00:00:39 -03:00 |
|
util.c
|
perf evsel: Introduce perf_evsel__open_strerror method
|
2013-01-24 16:40:09 -03:00 |
|
util.h
|
perf ui: Introduce struct perf_error_ops
|
2012-06-19 13:06:18 -03:00 |