Dmitry Torokhov
c46c4af7a1
Input: uinput - avoid FF flush when destroying device
commit e8b95728f724797f958912fd9b765a695595d3a6 upstream.
Normally, when input device supporting force feedback effects is being
destroyed, we try to "flush" currently playing effects, so that the
physical device does not continue vibrating (or executing other effects).
Unfortunately this does not work well for uinput as flushing of the effects
deadlocks with the destroy action:
- if device is being destroyed because the file descriptor is being closed,
then there is noone to even service FF requests;
- if device is being destroyed because userspace sent UI_DEV_DESTROY,
while theoretically it could be possible to service FF requests,
userspace is unlikely to do so (they'd need to make sure FF handling
happens on a separate thread) even if kernel solves the issue with FF
ioctls deadlocking with UI_DEV_DESTROY ioctl on udev->mutex.
To avoid lockups like the one below, let's install a custom input device
flush handler, and avoid trying to flush force feedback effects when we
destroying the device, and instead rely on uinput to shut off the device
properly.
NMI watchdog: Watchdog detected hard LOCKUP on cpu 3
...
<<EOE>> [<ffffffff817a0307>] _raw_spin_lock_irqsave+0x37/0x40
[<ffffffff810e633d>] complete+0x1d/0x50
[<ffffffffa00ba08c>] uinput_request_done+0x3c/0x40 [uinput]
[<ffffffffa00ba587>] uinput_request_submit.part.7+0x47/0xb0 [uinput]
[<ffffffffa00bb62b>] uinput_dev_erase_effect+0x5b/0x76 [uinput]
[<ffffffff815d91ad>] erase_effect+0xad/0xf0
[<ffffffff815d929d>] flush_effects+0x4d/0x90
[<ffffffff815d4cc0>] input_flush_device+0x40/0x60
[<ffffffff815daf1c>] evdev_cleanup+0xac/0xc0
[<ffffffff815daf5b>] evdev_disconnect+0x2b/0x60
[<ffffffff815d74ac>] __input_unregister_device+0xac/0x150
[<ffffffff815d75f7>] input_unregister_device+0x47/0x70
[<ffffffffa00bac45>] uinput_destroy_device+0xb5/0xc0 [uinput]
[<ffffffffa00bb2de>] uinput_ioctl_handler.isra.9+0x65e/0x740 [uinput]
[<ffffffff811231ab>] ? do_futex+0x12b/0xad0
[<ffffffffa00bb3f8>] uinput_ioctl+0x18/0x20 [uinput]
[<ffffffff81241248>] do_vfs_ioctl+0x298/0x480
[<ffffffff81337553>] ? security_file_ioctl+0x43/0x60
[<ffffffff812414a9>] SyS_ioctl+0x79/0x90
[<ffffffff817a04ee>] entry_SYSCALL_64_fastpath+0x12/0x71
Reported-by: Rodrigo Rivas Costa <rodrigorivascosta@gmail.com>
Reported-by: Clément VUCHENER <clement.vuchener@gmail.com>
Fixes: https://bugzilla.kernel.org/show_bug.cgi?id=193741
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
2021-01-23 15:38:17 +01:00 |
| .. |
|
acpi
|
ACPICA: Introduce ACPI_ACCESS_BYTE_WIDTH() macro
|
2020-03-11 07:53:05 +01:00 |
|
asm-generic
|
vmlinux.lds.h: Add PGO and AutoFDO input sections
|
2021-01-17 13:57:54 +01:00 |
|
clocksource
|
|
|
|
crypto
|
crypto: af_alg - fix use-after-free in af_alg_accept() due to bh_lock_sock()
|
2020-07-09 09:35:55 +02:00 |
|
drm
|
drm: mst: Fix query_payload ack reply struct
|
2020-01-04 13:39:00 +01:00 |
|
dt-bindings
|
dt-bindings: reset: meson8b: fix duplicate reset IDs
|
2020-01-23 08:19:38 +01:00 |
|
keys
|
KEYS: user: Align the payload buffer
|
2019-02-27 10:07:00 +01:00 |
|
kvm
|
arm/arm64: KVM: Add PSCI version selection API
|
2018-05-09 09:50:19 +02:00 |
|
linux
|
Input: uinput - avoid FF flush when destroying device
|
2021-01-23 15:38:17 +01:00 |
|
math-emu
|
math-emu/soft-fp.h: (_FP_ROUND_ZERO) cast 0 to void to fix warning
|
2019-12-21 10:41:02 +01:00 |
|
media
|
media: v4l2-device.h: Explicitly compare grp{id,mask} to zero in v4l2_device macros
|
2020-02-28 15:42:24 +01:00 |
|
memory
|
|
|
|
misc
|
|
|
|
net
|
net: sched: prevent invalid Scell_log shift count
|
2021-01-12 19:49:02 +01:00 |
|
pcmcia
|
|
|
|
ras
|
|
|
|
rdma
|
IB/cma: Fix reference count leak when no ipv4 addresses are set
|
2020-06-03 08:16:33 +02:00 |
|
rxrpc
|
|
|
|
scsi
|
scsi: libiscsi: Fix NOP race condition
|
2020-12-02 08:31:26 +01:00 |
|
soc
|
irqchip/eznps: Fix build error for !ARC700 builds
|
2020-09-23 08:46:10 +02:00 |
|
sound
|
ALSA: compress: fix partial_drain completion state
|
2020-07-22 09:10:45 +02:00 |
|
target
|
target: add XCOPY target/segment desc sense codes
|
2021-01-17 13:57:53 +01:00 |
|
trace
|
scsi: target: core: Add CONTROL field for trace events
|
2020-10-29 09:05:43 +01:00 |
|
uapi
|
uapi: move constants from <linux/kernel.h> to <linux/const.h>
|
2021-01-09 13:35:49 +01:00 |
|
video
|
udlfb: set optimal write delay
|
2018-09-09 20:01:25 +02:00 |
|
xen
|
xen/xenbus: Count pending messages for each watch
|
2021-01-09 13:35:50 +01:00 |
|
Kbuild
|
|
|