Deepa Dinamani
7abb7f747b
sock: Make sock->sk_stamp thread-safe ...
[ Upstream commit 3a0ed3e9619738067214871e9cb826fa23b2ddb9 ]
Al Viro mentioned (Message-ID
<20170626041334.GZ10672@ZenIV.linux.org.uk>)
that there is probably a race condition
lurking in accesses of sk_stamp on 32-bit machines.
sock->sk_stamp is of type ktime_t which is always an s64.
On a 32 bit architecture, we might run into situations of
unsafe access as the access to the field becomes non atomic.
Use seqlocks for synchronization.
This allows us to avoid using spinlocks for readers as
readers do not need mutual exclusion.
Another approach to solve this is to require sk_lock for all
modifications of the timestamps. The current approach allows
for timestamps to have their own lock: sk_stamp_lock.
This allows for the patch to not compete with already
existing critical sections, and side effects are limited
to the paths in the patch.
The addition of the new field maintains the data locality
optimizations from
commit 9115e8cd2a0c ("net: reorganize struct sock for better data
locality")
Note that all the instances of the sk_stamp accesses
are either through the ioctl or the syscall recvmsg.
Signed-off-by: Deepa Dinamani <deepa.kernel@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2019-01-09 16:16:41 +01:00
Bluetooth: Fix connection if directed advertising and privacy is used
2018-04-20 08:21:07 +02:00
s390/iucv: do not use arrays as argument
2015-09-21 16:03:04 -07:00
netfilter: nat: Revert "netfilter: nat: convert nat bysrc hash to rhashtable"
2017-11-18 11:22:24 +01:00
netfilter: ipv6: nf_defrag: reduce struct net memory waste
2018-08-24 13:12:26 +02:00
NFC: Fix the number of pipes
2018-09-29 03:07:30 -07:00
sock: struct proto hash function may error
2016-02-11 03:54:14 -05:00
sctp: set frag_point in sctp_setsockopt_maxseg correctly
2018-02-25 11:05:41 +01:00
net/sched: act_tunnel_key: fix NULL dereference when 'goto chain' is used
2018-08-24 13:12:37 +02:00
6lowpan: add 802.15.4 short addr slaac
2016-06-15 20:41:22 -07:00
net_sched: convert tcf_exts from list to pointer array
2016-08-17 19:27:51 -04:00
ipv6: reorder ip6_route_dev_notifier after ipv6_dev_notf
2017-05-14 14:00:21 +02:00
ieee802154: af_ieee802154: fix typo in comment.
2015-09-17 13:20:05 +02:00
rxrpc: Rewrite the data and ack handling code
2016-09-08 11:10:12 +01:00
af_unix: split 'u->readlock' into two: 'iolock' and 'bindlock'
2016-09-04 13:29:29 -07:00
vsock: split dwork to avoid reinitializations
2018-08-22 07:47:13 +02:00
ipv4: Make neigh lookup keys for loopback/point-to-point devices be INADDR_ANY
2018-01-31 12:55:55 +01:00
ax25: Stop using sock->sk_protinfo.
2015-06-28 16:55:44 -07:00
bonding: 3ad: apply ad_actor settings changes immediately
2016-02-09 04:45:49 -05:00
bonding: convert num_grat_arp to the new bonding option API
2015-07-27 01:05:24 -07:00
bonding: avoid possible dead-lock
2018-10-18 09:13:21 +02:00
net: un-inline sk_busy_loop()
2015-11-18 16:17:38 -05:00
calipso: Add a label cache.
2016-06-27 15:06:17 -04:00
cfg80211: make RATE_INFO_BW_20 the default
2018-04-13 19:47:49 +02:00
ieee802154: add netns support
2016-07-08 12:20:57 +02:00
csum: Update csum_block_add to use rotate instead of byteswap
2016-03-13 15:01:00 -04:00
netlabel: out of bound access in cipso_v4_validate()
2017-02-18 15:11:41 +01:00
cls_cgroup: get sk_classid only from full sockets
2016-04-19 20:09:25 -04:00
codel: split into multiple files
2016-04-25 16:44:27 -04:00
codel: split into multiple files
2016-04-25 16:44:27 -04:00
net_sched: fq_codel: cache skb->truesize into skb->cb
2016-06-25 12:19:35 -04:00
packet: compat support for sock_fprog
2016-06-09 23:41:03 -07:00
devlink: remove unused priv_size
2016-08-26 11:55:18 -07:00
netfilter: Pass net into okfn
2015-09-17 17:18:37 -07:00
net: dsa: add port fast ageing
2016-09-23 08:38:50 -04:00
ipv4: add reference counting to metrics
2017-06-07 12:07:46 +02:00
net: add dst_cache support
2016-02-16 20:21:48 -05:00
net/dst: Utility functions to build dst_metadata without supplying an skb
2016-09-10 20:53:55 -07:00
ipv4, ipv6: Pass net into __ip_local_out and __ip6_local_out
2015-10-08 04:27:02 -07:00
net/ethoc: support big-endian register layout
2015-09-23 15:33:15 -07:00
net: Add l3mdev rule
2016-06-08 11:36:02 -07:00
net: flow: Remove FLOWI_FLAG_L3MDEV_SRC flag
2016-09-10 23:12:53 -07:00
rps: flow_dissector: Add the const for the parameter of flow_keys_have_l4
2016-09-01 16:51:08 -07:00
fou: Add encap ops for IPv6 tunnels
2016-05-20 18:03:16 -04:00
fq.h: Port memory limit mechanism from fq_codel
2016-09-30 13:29:21 +02:00
fq.h: Port memory limit mechanism from fq_codel
2016-09-30 13:29:21 +02:00
net: sched: do not acquire qdisc spinlock in qdisc/class stats dump
2016-06-07 16:37:14 -07:00
Revert "genl: Add genlmsg_new_unicast() for unicast message allocation"
2016-02-18 11:42:19 -05:00
net: Remove deprecated tunnel specific UDP offload functions
2016-06-17 20:23:32 -07:00
Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net
2016-08-18 01:17:32 -04:00
gro_cell: add napi_disable in gro_cells_destroy
2019-01-09 16:16:41 +01:00
gtp: #define #define _GTP_H_ and not #define _GTP_H
2016-07-25 17:55:43 -07:00
net: add a hardware buffer management helper API
2016-03-14 12:19:46 -04:00
net: snmp: kill STATS_BH macros
2016-04-27 22:48:25 -04:00
mac80211: add support for radiotap timestamp field
2016-09-12 11:45:45 +02:00
mac802154: constify ieee802154_llsec_ops structure
2016-01-04 20:40:41 +01:00
IPv6: fix DESYNC_FACTOR
2016-10-14 10:59:15 -04:00
ila: Add generic ILA translation facility
2015-12-15 23:25:20 -05:00
ipv6: remove unused in6_addr struct
2016-03-22 15:45:44 -04:00
tcp/dccp: do not touch listener sk_refcnt under synflood
2016-04-04 22:11:20 -04:00
ip4ip6: Support for GSO/GRO
2016-05-20 18:03:17 -04:00
tcp: increase ICSK_CA_PRIV_SIZE from 64 bytes to 88
2016-09-21 00:23:01 -04:00
ipv6: suppress sparse warnings in IP6_ECN_set_ce()
2016-08-13 15:08:00 -07:00
ip: add helpers to process in-order fragments faster.
2018-10-18 09:13:26 +02:00
tcp/dccp: do not touch listener sk_refcnt under synflood
2016-04-04 22:11:20 -04:00
inet: make sure to grab rcu_read_lock before using ireq->ireq_opt
2018-10-18 09:13:23 +02:00
soreuseport: initialise timewait reuseport field
2018-05-16 10:08:41 +02:00
inet: tcp: fix inetpeer_set_addr_v4()
2015-12-16 00:14:12 -05:00
inet: frags: remove some helpers
2018-10-18 09:13:24 +02:00
ipv6: Pass proto to csum_ipv6_magic as __u8 instead of unsigned short
2016-03-13 23:55:13 -04:00
ipv6: fix sparse warning on rt6i_node
2017-09-20 08:19:53 +02:00
net: ipv6: Compare lwstate in detecting duplicate nexthops
2017-07-21 07:42:19 +02:00
ip6_tunnel: Clear IP6CB in ip6tunnel_xmit()
2016-11-02 15:18:36 -04:00
net: ipv4: update fnhe_pmtu when first hop's MTU changes
2018-10-18 09:13:22 +02:00
ip_tunnel: add collect_md mode to IPIP tunnel
2016-09-17 10:13:07 -04:00
ipvs: update real-server binding of outgoing connections in SIP-pe
2016-06-06 09:47:25 +09:00
inet: frags: remove some helpers
2018-10-18 09:13:24 +02:00
wext: handle NULL extra data in iwe_stream_add_point better
2017-08-11 08:49:34 -07:00
kcm: Use stream parser
2016-08-17 19:36:23 -04:00
net: ipv4: Do not drop to make_route if oif is l3mdev
2016-10-13 12:05:26 -04:00
llc: use refcount_inc_not_zero() for llc_sap_find()
2018-08-22 07:47:13 +02:00
llc: properly handle dev_queue_xmit() return value
2018-05-30 07:50:39 +02:00
lwtunnel: valid encap attr check should return 0 when lwtunnel is disabled
2017-02-18 15:11:42 +01:00
mac80211: round IEEE80211_TX_STATUS_HEADROOM up to multiple of 4
2018-05-30 07:50:28 +02:00
ieee802154: cleanup WARN_ON for fc fetch
2016-07-08 13:23:12 +02:00
openvswitch: use mpls_hdr
2016-10-03 02:00:22 -04:00
mpls: multipath route support
2015-10-23 06:26:42 -07:00
net/ncsi: Introduce ncsi_stop_dev()
2016-10-04 02:11:51 -04:00
6lowpan: introduce 6lowpan-nd
2016-06-15 20:41:23 -07:00
neighbour: Avoid writing before skb->head in neigh_hh_output()
2018-12-17 09:38:31 +01:00
netfilter: ipv6: nf_defrag: reduce struct net memory waste
2018-08-24 13:12:26 +02:00
neigh: Send a notification when DELAY_PROBE_TIME changes
2016-07-05 09:06:29 -07:00
netlabel: Implement CALIPSO config functions for SMACK.
2016-06-27 15:06:18 -04:00
netlink: fix nla_put_{u8,u16,u32} for KASAN
2017-10-12 11:51:25 +02:00
net: wrap sock->sk_cgrp_prioidx and ->sk_classid inside a struct
2015-12-08 22:02:33 -05:00
net: fix rtnh_ok()
2018-05-16 10:08:41 +02:00
ieee802154: add netns support
2016-07-08 12:20:57 +02:00
net: ping: make ping_v6_sendmsg static
2016-03-23 22:09:58 -04:00
net/sched: pkt_cls: change tc actions order to be as the user sets
2016-09-28 05:02:44 -04:00
net: sched: convert qdisc linked list to hashtable
2016-08-10 17:19:02 -07:00
pptp: Refactor the struct and macros of PPTP codes
2016-08-15 10:55:53 -07:00
udp: Remove udp_offloads
2016-04-07 16:53:30 -04:00
sock: struct proto hash function may error
2016-02-11 03:54:14 -05:00
net_sched: red: Avoid illegal values
2018-02-25 11:05:48 +01:00
regulatory: add NUL to request alpha2
2018-05-30 07:50:30 +02:00
inet: reqsk_alloc() needs to take care of dead listeners
2016-04-04 22:11:19 -04:00
ipv4: lock mtu in fnhe when received PMTU < net.ipv4.route.min_pmtu
2018-05-30 07:50:36 +02:00
net: rtnetlink: add support for the IFLA_STATS_LINK_XSTATS_SLAVE attribute
2016-06-30 06:15:04 -04:00
sch_netem: fix skb leak in netem_enqueue()
2018-03-31 18:11:33 +02:00
unix: correctly track in-flight fds in sending process user_struct
2016-02-08 10:30:42 -05:00
slip: Check if rstate is initialized before uncompressing
2018-04-20 08:21:07 +02:00
net: snmp: fix 64bit stats on 32bit arches
2016-04-28 11:49:45 -04:00
sock: Make sock->sk_stamp thread-safe
2019-01-09 16:16:41 +01:00
soreuseport: fix NULL ptr dereference SO_REUSEPORT after bind
2016-01-19 14:44:23 -05:00
kcm: Remove TCP specific references from kcm and strparser
2016-08-28 23:32:41 -04:00
switchdev: remove FIB offload infrastructure
2016-09-28 04:48:00 -04:00
tcp: remove DELAYED ACK events in DCTCP
2018-08-24 13:12:39 +02:00
inet: remove BUG_ON() in twsk_destructor()
2015-07-09 15:12:20 -07:00
ipv6: add new struct ipcm6_cookie
2016-05-03 16:08:14 -04:00
net: tso: add support for IPv6
2015-10-26 22:24:22 -07:00
udp: must lock the socket in udp_disconnect()
2016-10-20 14:45:52 -04:00
vxlan: Add new UDP encapsulation offload type for VXLAN-GPE
2016-06-17 20:23:32 -07:00
udplite: fix partial checksum initialization
2018-03-11 16:21:32 +01:00
vxlan: fix hlist corruption
2017-07-21 07:42:18 +02:00
net: x25: fix one potential use-after-free issue
2018-04-13 19:48:00 +02:00
xfrm: fix stack access out of bounds with CONFIG_XFRM_SUB_POLICY
2017-07-05 14:40:28 +02:00
7abb7f747b