Herbert Xu
04d462a6f4
crypto: af_alg - fix use-after-free in af_alg_accept() due to bh_lock_sock() ...
commit 34c86f4c4a7be3b3e35aa48bd18299d4c756064d upstream.
The locking in af_alg_release_parent is broken as the BH socket
lock can only be taken if there is a code-path to handle the case
where the lock is owned by process-context. Instead of adding
such handling, we can fix this by changing the ref counts to
atomic_t.
This patch also modifies the main refcnt to include both normal
and nokey sockets. This way we don't have to fudge the nokey
ref count when a socket changes from nokey to normal.
Credits go to Mauricio Faria de Oliveira who diagnosed this bug
and sent a patch for it:
https://lore.kernel.org/linux-crypto/20200605161657.535043-1-mfo@canonical.com/
Reported-by: Brian Moyles <bmoyles@netflix.com>
Reported-by: Mauricio Faria de Oliveira <mfo@canonical.com>
Fixes: 37f96694cf73 ("crypto: af_alg - Use bh_lock_sock in...")
Cc: <stable@vger.kernel.org>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2020-07-09 09:35:55 +02:00
crypto: hash - introduce crypto_hash_alg_has_setkey()
2018-02-17 13:21:15 +01:00
crypto: create generic version of ablk_helper
2013-09-24 06:02:24 +10:00
crypto: aead - Add chunk size
2016-07-18 17:35:38 +08:00
crypto: doc - add akcipher API
2016-02-17 04:07:53 +08:00
crypto: engine - move crypto engine to its own header
2016-09-07 21:08:26 +08:00
crypto: authenc - Export key parsing helper function
2013-10-16 20:56:25 +08:00
crypto: blowfish - split generic and common c code
2011-09-22 21:25:25 +10:00
crypto: cast5/cast6 - move lookup tables to shared module
2012-12-06 17:16:26 +08:00
crypto: cast5/cast6 - move lookup tables to shared module
2012-12-06 17:16:26 +08:00
crypto: cast5/cast6 - move lookup tables to shared module
2012-12-06 17:16:26 +08:00
random: replace non-blocking pool with a Chacha20-based CRNG
2016-07-03 00:57:23 -04:00
crypto: cryptd - Add helpers to check whether a tfm is queued
2016-06-23 18:29:52 +08:00
crypto: api - Use dedicated workqueue for crypto subsystem
2009-02-19 14:33:40 +08:00
crypto: des_3des - add x86-64 assembly implementation
2014-06-20 21:27:58 +08:00
crypto: dh - Add DH software implementation
2016-06-23 18:29:56 +08:00
crypto: drbg - prevent invalid SG mappings
2016-11-30 19:46:44 +08:00
crypto: ecdh - Add ECDH software support
2016-06-23 18:29:57 +08:00
crypto: engine - permit to enqueue ashash_request
2016-09-07 21:08:27 +08:00
Update broken web addresses in the kernel.
2010-10-18 11:03:14 +02:00
crypto: ghash-generic - move common definitions to a new header file
2016-10-02 22:26:40 +08:00
crypto: hash - prevent using keyed hashes without setting key
2018-02-25 11:05:44 +01:00
keys, trusted: select hash algorithm for TPM2 chips
2015-12-20 15:27:12 +02:00
crypto: af_alg - fix use-after-free in af_alg_accept() due to bh_lock_sock()
2020-07-09 09:35:55 +02:00
crypto: ecdh - Add ECDH software support
2016-06-23 18:29:57 +08:00
crypto: lrw - add interface for parallelized cipher implementions
2011-11-09 11:50:31 +08:00
crypto: mcryptd - protect the per-CPU queue with a lock
2017-12-29 17:42:58 +01:00
crypto: hash - add zero length message hash for shax and md5
2015-12-22 20:43:35 +08:00
crypto: null - Remove default null blkcipher
2016-07-18 17:35:44 +08:00
crypto: padlock - Move padlock.h into include/crypto
2011-01-07 14:52:00 +11:00
crypto: pcrypt - Add pcrypt crypto parallelization wrapper
2010-01-07 15:57:19 +11:00
PKCS#7: Make trust determination dependent on contents of trust keyring
2016-04-06 16:14:24 +01:00
crypto: poly1305 - remove ->setkey() method
2018-02-17 13:21:15 +01:00
KEYS: Move the point of trust determination to __key_link()
2016-04-11 22:43:43 +01:00
crypto: doc - Fix typo in crypto-API.xml
2015-06-04 15:05:08 +08:00
crypto: scatterwalk - Inline start/map/done
2016-07-18 17:35:50 +08:00
crypto: serpent-sse2 - add lrw support
2011-11-21 16:13:24 +08:00
crypto: hash - add zero length message hash for shax and md5
2015-12-22 20:43:35 +08:00
crypto: sha1 - implement base layer for SHA-1
2015-04-10 21:39:39 +08:00
crypto: sha3 - Add SHA-3 hash algorithm
2016-06-20 19:25:01 +08:00
crypto: sha256 - implement base layer for SHA-256
2015-04-10 21:39:39 +08:00
crypto: sha512 - implement base layer for SHA-512
2015-04-10 21:39:39 +08:00
crypto: skcipher - Add comment for skcipher_alg->base
2016-07-19 15:42:42 +08:00
crypto: twofish-x86_64-3way - add lrw support
2011-11-09 11:53:32 +08:00
crypto: xts - consolidate sanity check for keys
2016-02-17 04:07:51 +08:00
04d462a6f4