Steve Muckle
fa7a13e71d
sched/fair: Fix vruntime_normalized() for remote non-migration wakeup ...
commit d0cdb3ce8834332d918fc9c8ff74f8a169ec9abe upstream.
When a task which previously ran on a given CPU is remotely queued to
wake up on that same CPU, there is a period where the task's state is
TASK_WAKING and its vruntime is not normalized. This is not accounted
for in vruntime_normalized() which will cause an error in the task's
vruntime if it is switched from the fair class during this time.
For example if it is boosted to RT priority via rt_mutex_setprio(),
rq->min_vruntime will not be subtracted from the task's vruntime but
it will be added again when the task returns to the fair class. The
task's vruntime will have been erroneously doubled and the effective
priority of the task will be reduced.
Note this will also lead to inflation of all vruntimes since the doubled
vruntime value will become the rq's min_vruntime when other tasks leave
the rq. This leads to repeated doubling of the vruntime and priority
penalty.
Fix this by recognizing a WAKING task's vruntime as normalized only if
sched_remote_wakeup is true. This indicates a migration, in which case
the vruntime would have been normalized in migrate_task_rq_fair().
Based on a similar patch from John Dias <joaodias@google.com>.
Suggested-by: Peter Zijlstra <peterz@infradead.org>
Tested-by: Dietmar Eggemann <dietmar.eggemann@arm.com>
Signed-off-by: Steve Muckle <smuckle@google.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Cc: Chris Redpath <Chris.Redpath@arm.com>
Cc: John Dias <joaodias@google.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Miguel de Dios <migueldedios@google.com>
Cc: Morten Rasmussen <Morten.Rasmussen@arm.com>
Cc: Patrick Bellasi <Patrick.Bellasi@arm.com>
Cc: Paul Turner <pjt@google.com>
Cc: Quentin Perret <quentin.perret@arm.com>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Todd Kjos <tkjos@google.com>
Cc: kernel-team@android.com
Fixes: b5179ac70dhttp://lkml.kernel.org/r/20180831224217.169476-1-smuckle@google.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2018-09-29 03:07:34 -07:00
bpf: fix references to free_bpf_prog_info() in comments
2018-08-03 07:55:23 +02:00
config: android: enable CONFIG_SECCOMP
2016-10-11 15:06:32 -07:00
kdb: make "mdr" command repeat
2018-05-30 07:50:51 +02:00
perf/core: Force USER_DS when recording user stack data
2018-09-26 08:36:37 +02:00
gcov: support GCC 7.1
2017-09-02 07:07:53 +02:00
genirq: Make force irq threading setup more robust
2018-08-09 12:17:57 +02:00
livepatch/module: make TAINT_LIVEPATCH module-specific
2016-08-26 14:42:08 +02:00
locking/osq_lock: Fix osq_lock queue corruption
2018-09-19 22:47:11 +02:00
PM / sleep: wakeup: Fix build error caused by missing SRCU support
2018-09-09 20:01:23 +02:00
printk/tracing: Do not trace printk_nmi_enter()
2018-09-09 20:01:25 +02:00
rcu: Call touch_nmi_watchdog() while printing stall warnings
2018-05-30 07:50:50 +02:00
sched/fair: Fix vruntime_normalized() for remote non-migration wakeup
2018-09-29 03:07:34 -07:00
timers: Clear timer_base::must_forward_clk with timer_base::lock held
2018-09-19 22:47:13 +02:00
ring-buffer: Allow for rescheduling when removing pages
2018-09-29 03:07:32 -07:00
kernel/acct.c: fix the acct->needcheck check in check_free_space()
2018-01-10 09:29:51 +01:00
kernel/async.c: revert "async: simplify lowest_in_progress()"
2018-02-17 13:21:18 +01:00
audit: return on memory error to avoid null pointer dereference
2018-05-30 07:50:49 +02:00
Merge branch 'stable-4.8' of git://git.infradead.org/users/pcmoore/audit
2016-07-29 17:54:17 -07:00
audit: cleanup prune_tree_thread
2016-04-04 09:46:47 -04:00
audit: fix use-after-free in audit_add_watch
2018-09-26 08:36:37 +02:00
audit: allow not equal op for audit by executable
2018-08-03 07:55:25 +02:00
audit: allow not equal op for audit by executable
2018-08-03 07:55:25 +02:00
ptrace: Capture the ptracer's creds not PT_PTRACE_CAP
2017-01-06 10:40:13 +01:00
cgroup: fix error return value from cgroup_subtree_control()
2017-08-11 08:49:28 -07:00
cgroup/pids: remove spurious suspicious RCU usage warning
2017-03-26 13:05:58 +02:00
cpu/hotplug: Non-SMP machines do not make use of booted_once
2018-08-15 18:14:55 +02:00
sched/cpuset/pm: Fix cpuset vs. suspend-resume bugs
2017-10-12 11:51:25 +02:00
cred: Reject inodes with invalid ids in set_create_file_as()
2016-06-30 18:05:09 -05:00
kernel/exit.c: avoid undefined behaviour when calling wait4()
2018-05-19 10:27:01 +02:00
kernel/extable.c: mark core_kernel_text notrace
2017-07-21 07:42:21 +02:00
kthread: Fix use-after-free if kthread fork fails
2018-09-19 22:47:10 +02:00
freezer, oom: check TIF_MEMDIE on the correct task
2016-07-28 16:07:41 -07:00
futex: futex_wake_op, fix sign_extend32 sign bits
2018-05-19 10:27:00 +02:00
kernel: make groups_sort calling a responsibility group_info allocators
2018-01-10 09:29:52 +01:00
hung_task: allow hung_task_panic when hung_task_warnings is 0
2016-10-11 15:06:33 -07:00
jump_label: Invoke jump_label_test() via early_initcall()
2017-12-14 09:28:24 +01:00
kallsyms: add support for relative offsets in kallsyms address table
2016-03-15 16:55:16 -07:00
kcov: ensure irq code sees a valid area
2018-08-03 07:55:12 +02:00
kexec: allow architectures to override boot mapping
2016-08-02 19:35:27 -04:00
objtool, x86: Add several functions and files to the objtool whitelist
2018-06-05 10:28:57 +02:00
kexec: fix double-free when failing to relocate the purgatory
2016-09-01 17:52:01 -07:00
kprobes: Make list and blacklist root user read only
2018-09-05 09:20:10 +02:00
kexec: add a kexec_crash_loaded() function
2016-08-02 19:35:30 -04:00
kthread, tracing: Don't expose half-written comm when creating kthreads
2018-08-03 07:55:12 +02:00
kernel/watchdog.c: move hardlockup detector to separate file
2017-06-17 06:41:57 +02:00
Fix: Disable sys_membarrier when nohz_full is enabled
2017-03-12 06:41:45 +01:00
mm: Fix devm_memremap_pages() collision handling
2018-02-28 10:18:34 +01:00
module: extend 'rodata=off' boot cmdline parameter to module mappings
2018-04-08 12:12:52 +02:00
KEYS: Move the point of trust determination to __key_link()
2016-04-11 22:43:43 +01:00
padata: free correct variable
2017-05-20 14:28:40 +02:00
kernel/panic.c: add missing \n
2017-07-05 14:40:24 +02:00
pidns: disable pid allocation if pid_ns_prepare_proc() is failed in alloc_pid()
2018-04-13 19:47:53 +02:00
pid_ns: Sleep in TASK_INTERRUPTIBLE in zap_pid_ns_processes
2017-05-25 15:44:38 +02:00
profile: Convert to hotplug state machine
2016-07-15 10:41:42 +02:00
ptrace: Properly initialize ptracer_cred on fork
2017-06-14 15:05:54 +02:00
kernel/relay.c: limit kmalloc size to KMALLOC_MAX_SIZE
2018-05-30 07:50:29 +02:00
resource: fix integer overflow at reallocation
2018-04-24 09:34:09 +02:00
seccomp: Move speculation migitation control to arch code
2018-05-22 16:58:02 +02:00
kernel/signal.c: avoid undefined behaviour in kill_something_info
2018-05-30 07:50:18 +02:00
cpu/hotplug: Fix SMT supported evaluation
2018-08-15 18:14:53 +02:00
kthread/smpboot: do not park in kthread_create_on_cpu()
2016-10-11 15:06:33 -07:00
Mark HI and TASKLET softirq synchronous
2018-08-15 18:14:42 +02:00
stacktrace, lockdep: Fix address, newline ugliness
2017-02-14 15:25:42 -08:00
stop_machine: Use raw spinlocks
2018-08-03 07:55:24 +02:00
sys: don't hold uts_sem while accessing userspace memory
2018-09-09 20:01:24 +02:00
x86/pkeys: Fix pkeys build breakage for some non-x86 arches
2016-09-13 14:41:36 +02:00
sched/sysctl: Check user input value of sysctl_sched_time_avg
2018-09-05 09:20:04 +02:00
kernel/sysctl_binary.c: use generic UUID library
2016-05-20 17:58:30 -07:00
task_work: use READ_ONCE/lockless_dereference, avoid pi_lock if !task_works
2016-08-02 19:35:02 -04:00
taskstats: fix the length of cgroupstats_cmd_get_policy
2016-11-03 16:55:58 -04:00
torture: Convert torture_shutdown() to hrtimer
2016-08-22 10:01:49 -07:00
tracepoint: Do not warn on ENOMEM
2018-05-09 09:50:20 +02:00
kernel/ucount.c: mark user_header with kmemleak_ignore()
2017-06-17 06:41:51 +02:00
kernel: make groups_sort calling a responsibility group_info allocators
2018-01-10 09:29:52 +01:00
smp: Add function to execute a function synchronously on a CPU
2016-09-05 13:52:39 +02:00
userns: move user access out of the mutex
2018-09-09 20:01:24 +02:00
Merge branch 'nsfs-ioctls' into HEAD
2016-09-22 20:00:36 -05:00
sys: don't hold uts_sem while accessing userspace memory
2018-09-09 20:01:24 +02:00
kernel/watchdog: prevent false hardlockup on overloaded system
2017-06-17 06:41:57 +02:00
kernel/watchdog: prevent false hardlockup on overloaded system
2017-06-17 06:41:57 +02:00
workqueue: use put_device() instead of kfree()
2018-05-30 07:50:36 +02:00
workqueue: Fix NULL pointer dereference
2017-11-15 15:53:17 +01:00
fa7a13e71d