Ping-Ke Shih
4ee618ad88
rtlwifi: fix memory leak in rtl92c_set_fw_rsvdpagepkt() ...
[ Upstream commit 5174f1e41074b5186608badc2e89441d021e8c08 ]
This leak was found by testing the EDIMAX EW-7612 on Raspberry Pi 3B+ with
Linux 5.4-rc5 (multi_v7_defconfig + rtlwifi + kmemleak) and noticed a
single memory leak during probe:
unreferenced object 0xec13ee40 (size 176):
comm "kworker/u8:1", pid 36, jiffies 4294939321 (age 5580.790s)
hex dump (first 32 bytes):
00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
backtrace:
[<fc1bbb3e>] __netdev_alloc_skb+0x9c/0x164
[<863dfa6e>] rtl92c_set_fw_rsvdpagepkt+0x254/0x340 [rtl8192c_common]
[<9572be0d>] rtl92cu_set_hw_reg+0xf48/0xfa4 [rtl8192cu]
[<116df4d8>] rtl_op_bss_info_changed+0x234/0x96c [rtlwifi]
[<8933575f>] ieee80211_bss_info_change_notify+0xb8/0x264 [mac80211]
[<d4061e86>] ieee80211_assoc_success+0x934/0x1798 [mac80211]
[<e55adb56>] ieee80211_rx_mgmt_assoc_resp+0x174/0x314 [mac80211]
[<5974629e>] ieee80211_sta_rx_queued_mgmt+0x3f4/0x7f0 [mac80211]
[<d91091c6>] ieee80211_iface_work+0x208/0x318 [mac80211]
[<ac5fcae4>] process_one_work+0x22c/0x564
[<f5e6d3b6>] worker_thread+0x44/0x5d8
[<82c7b073>] kthread+0x150/0x154
[<b43e1b7d>] ret_from_fork+0x14/0x2c
[<794dff30>] 0x0
It is because 8192cu doesn't implement usb_cmd_send_packet(), and this
patch just frees the skb within the function to resolve memleak problem
by now. Since 8192cu doesn't turn on fwctrl_lps that needs to download
command packet for firmware via the function, applying this patch doesn't
affect driver behavior.
Reported-by: Stefan Wahren <wahrenst@gmx.net>
Signed-off-by: Ping-Ke Shih <pkshih@realtek.com>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
2020-01-04 13:39:35 +01:00
ACPI: PM: Avoid attaching ACPI PM domain to certain devices
2019-12-21 10:42:06 +01:00
ANDROID: binder: synchronize_rcu() when using POLLFREE.
2019-10-07 18:53:19 +02:00
libata: Ensure ata_port probe has completed before detach
2020-01-04 13:39:30 +01:00
atm: zatm: Fix empty body Clang warnings
2019-11-28 18:28:32 +01:00
drivers/base/platform.c: kmemleak ignore a known leak
2019-12-05 15:35:04 +01:00
rsxx: add missed destroy_workqueue calls in remove
2019-12-21 10:40:49 +01:00
Bluetooth: Fix invalid-free in bcsp_close()
2019-11-28 18:29:02 +01:00
cdrom: Fix race condition in cdrom_sysctl_register
2019-04-05 22:29:12 +02:00
hwrng: omap3-rom - Call clk_disable_unprepare() on exit only if not idled
2020-01-04 13:39:15 +01:00
clk: sunxi-ng: h3/h5: Fix CSI_MCLK parent
2019-12-21 10:41:20 +01:00
clocksource/drivers/exynos_mct: Increase priority over ARM arch timer
2019-08-04 09:33:22 +02:00
cpufreq: Add NULL checks to show() and store() methods of cpufreq
2019-11-28 18:29:03 +01:00
cpuidle: Do not unset the driver if it is there already
2019-12-21 10:42:04 +01:00
crypto: ccp - fix uninitialized list head
2019-12-21 10:41:40 +01:00
PM / devfreq: Lock devfreq in trans_stat_show
2019-12-21 10:42:05 +01:00
dmaengine: coh901318: Remove unused variable
2019-12-21 10:41:06 +01:00
dma-buf: Fix memory leak in sync_file_merge()
2019-12-21 10:42:32 +01:00
EDAC/altera: Use the proper type for the IRQ status bits
2019-10-05 12:30:20 +02:00
extcon: sm5502: Reset registers during initialization
2020-01-04 13:39:22 +01:00
firmware: qcom: scm: Ensure 'a0' status code is treated as signed
2019-12-21 10:42:17 +01:00
gpio: max77620: Fixup debounce delays
2019-11-28 18:28:05 +01:00
drm/gma500: fix memory disclosures due to uninitialized bytes
2020-01-04 13:39:27 +01:00
HID: core: check whether Usage Page item is after Usage ID items
2019-12-05 15:35:31 +01:00
hwmon: (ina3221) Fix INA3221_CONFIG_MODE macros
2019-11-25 09:53:51 +01:00
coresight: etm4x: Fix input validation for sysfs.
2019-12-21 10:41:33 +01:00
i2c: imx: don't print error message on probe defer
2019-12-21 10:41:11 +01:00
x86/cpu: Sanitize FAM6_ATOM naming
2019-05-14 19:19:34 +02:00
iio: adc: max1027: Reset the device at probe time
2020-01-04 13:39:25 +01:00
IB/iser: bound protection_sg size by data_sg size
2020-01-04 13:39:09 +01:00
Input: goodix - add upside-down quirk for Teclast X89 tablet
2019-12-21 10:41:32 +01:00
iommu/amd: Fix NULL dereference bug in match_hid_uid
2019-12-05 15:35:15 +01:00
irqchip/gic-v3-its: Fix LPI release for Multi-MSI devices
2019-10-05 12:30:10 +02:00
staging: gigaset: add endpoint-type sanity check
2019-12-21 10:41:50 +01:00
leds: leds-lp5562 allow firmware files up to the maximum length
2019-10-05 12:30:17 +02:00
macintosh/windfarm_smu_sat: Fix debug output
2019-11-28 18:28:30 +01:00
mailbox: handle failed named mailbox channel request
2019-08-04 09:33:41 +02:00
dm btree: increase rebalance threshold in __rebalance2()
2019-12-21 10:42:32 +01:00
media: ti-vpe: vpe: Make sure YUYV is set as default format
2020-01-04 13:39:21 +01:00
memory: tegra: Fix integer overflow on tick value calculation
2019-05-25 18:26:49 +02:00
memstick: jmb38x_ms: Fix an error handling path in 'jmb38x_ms_probe()'
2019-10-29 09:15:25 +01:00
mfd: max8997: Enale irq-wakeup unconditionally
2019-11-28 18:28:38 +01:00
altera-stapl: check for a null key before strcasecmp'ing it
2019-12-21 10:41:09 +01:00
mmc: host: omap_hsmmc: add code for special init of wl1251 to get rid of pandora_wl1251_init_card
2019-12-21 10:42:07 +01:00
mtd: spear_smi: Fix Write Burst mode
2019-12-21 10:41:56 +01:00
rtlwifi: fix memory leak in rtl92c_set_fw_rsvdpagepkt()
2020-01-04 13:39:35 +01:00
NFC: nxp-nci: Fix NULL pointer dereference after I2C communication error
2019-12-21 10:40:48 +01:00
ntb: intel: fix return value for ndev_vec_mask()
2019-11-28 18:28:52 +01:00
libnvdimm/pfn: fix fsdax-mode namespace info-block zero-fields
2019-08-04 09:33:29 +02:00
nvme: host: core: fix precedence of ternary operator
2019-12-21 10:42:21 +01:00
nvmem: core: return error code instead of NULL from nvmem_device_get
2019-11-25 09:52:16 +01:00
of: make PowerMac cache node search conditional on CONFIG_PPC_PMAC
2019-11-25 09:52:08 +01:00
parisc: Disable HP HSC-PCI Cards to prevent kernel crash
2019-10-05 12:30:31 +02:00
parport: Fix mem leak in parport_register_dev_model
2019-07-10 09:55:29 +02:00
PCI/MSI: Fix incorrect MSI-X masking on resume
2019-12-21 10:42:29 +01:00
drivers/perf: arm_pmu: Fix failure path in PM notifier
2019-08-06 18:29:41 +02:00
phy: phy-twl4030-usb: fix denied runtime access
2019-11-25 09:52:50 +01:00
pinctrl: sh-pfc: sh7734: Fix duplicate TCLK1_B
2020-01-04 13:39:31 +01:00
platform/x86: hp-wmi: Fix ACPI errors caused by too small buffer
2019-12-05 15:35:33 +01:00
PM / AVS: SmartReflex: NULL check before some freeing functions is not needed
2019-12-05 15:34:17 +01:00
x86/cpu: Sanitize FAM6_ATOM naming
2019-05-14 19:19:34 +02:00
drivers/pps/pps.c: clear offset flags in PPS_SETPARAMS ioctl
2019-08-04 09:33:45 +02:00
pwm: Clear chip_data in pwm_put()
2019-12-05 15:35:23 +01:00
drivers/rapidio/devices/rio_mport_cdev.c: NUL terminate some strings
2019-08-06 18:29:38 +02:00
regulator: max8907: Fix the usage of uninitialized variable in max8907_regulator_probe()
2020-01-04 13:39:15 +01:00
reset: Fix potential use-after-free in __of_reset_control_get()
2019-11-25 09:53:42 +01:00
rtc: max8997: Fix the returned value in case of error in 'max8997_rtc_read_alarm()'
2019-12-21 10:41:03 +01:00
scsi: zfcp: trace channel log even for FCP command responses
2019-12-21 10:42:10 +01:00
scsi: iscsi: Fix a potential deadlock in the timeout handler
2019-12-21 10:42:33 +01:00
soc: mediatek: pwrap: Zero initialize rdata in pwrap_init_cipher
2019-06-22 08:17:15 +02:00
spi: img-spfi: fix potential double release
2020-01-04 13:39:34 +01:00
ssb: Fix possible NULL pointer dereference in ssb_host_pcmcia_exit
2019-05-31 06:48:12 -07:00
staging: rtl8188eu: fix possible null dereference
2020-01-04 13:39:05 +01:00
scsi: target: core: Do not overwrite CDB byte 1
2019-11-10 11:23:18 +01:00
thermal: Fix deadlock in thermal thermal_zone_device_check
2019-12-21 10:41:43 +01:00
thunderbolt: Use 32-bit writes when writing ring producer/consumer
2019-11-06 12:18:14 +01:00
tty: vt: keyboard: reject invalid keycodes
2019-12-21 10:41:36 +01:00
usb: usbfs: Suppress problematic bind and unbind uevents.
2020-01-04 13:39:24 +01:00
vfio/pci: call irq_bypass_unregister_producer() before freeing irq
2019-12-21 10:42:31 +01:00
vhost: make sure log_num < in_num
2019-09-16 08:19:34 +02:00
video/hdmi: Fix AVI bar unpack
2019-12-21 10:42:08 +01:00
drivers/virt/fsl_hypervisor.c: prevent integer overflow in ioctl
2019-05-16 19:43:47 +02:00
virtio-balloon: fix managed page counts when migrating pages between zones
2019-12-21 10:41:57 +01:00
w1: fix the resume command API
2019-05-31 06:48:15 -07:00
watchdog: meson: Fix the wrong value of left time
2019-12-05 15:34:10 +01:00
xen/pciback: Check dev_data before using it
2019-12-05 15:34:29 +01:00
4ee618ad88