Eric Dumazet
346da62cc1
dccp: do not send reset to already closed sockets
Andrey reported following warning while fuzzing with syzkaller
WARNING: CPU: 1 PID: 21072 at net/dccp/proto.c:83 dccp_set_state+0x229/0x290
Kernel panic - not syncing: panic_on_warn set ...
CPU: 1 PID: 21072 Comm: syz-executor Not tainted 4.9.0-rc1+ #293
Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS Bochs 01/01/2011
ffff88003d4c7738 ffffffff81b474f4 0000000000000003 dffffc0000000000
ffffffff844f8b00 ffff88003d4c7804 ffff88003d4c7800 ffffffff8140c06a
0000000041b58ab3 ffffffff8479ab7d ffffffff8140beae ffffffff8140cd00
Call Trace:
[< inline >] __dump_stack lib/dump_stack.c:15
[<ffffffff81b474f4>] dump_stack+0xb3/0x10f lib/dump_stack.c:51
[<ffffffff8140c06a>] panic+0x1bc/0x39d kernel/panic.c:179
[<ffffffff8111125c>] __warn+0x1cc/0x1f0 kernel/panic.c:542
[<ffffffff8111144c>] warn_slowpath_null+0x2c/0x40 kernel/panic.c:585
[<ffffffff8389e5d9>] dccp_set_state+0x229/0x290 net/dccp/proto.c:83
[<ffffffff838a0aa2>] dccp_close+0x612/0xc10 net/dccp/proto.c:1016
[<ffffffff8316bf1f>] inet_release+0xef/0x1c0 net/ipv4/af_inet.c:415
[<ffffffff82b6e89e>] sock_release+0x8e/0x1d0 net/socket.c:570
[<ffffffff82b6e9f6>] sock_close+0x16/0x20 net/socket.c:1017
[<ffffffff815256ad>] __fput+0x29d/0x720 fs/file_table.c:208
[<ffffffff81525bb5>] ____fput+0x15/0x20 fs/file_table.c:244
[<ffffffff811727d8>] task_work_run+0xf8/0x170 kernel/task_work.c:116
[< inline >] exit_task_work include/linux/task_work.h:21
[<ffffffff8111bc53>] do_exit+0x883/0x2ac0 kernel/exit.c:828
[<ffffffff811221fe>] do_group_exit+0x10e/0x340 kernel/exit.c:931
[<ffffffff81143c94>] get_signal+0x634/0x15a0 kernel/signal.c:2307
[<ffffffff81054aad>] do_signal+0x8d/0x1a30 arch/x86/kernel/signal.c:807
[<ffffffff81003a05>] exit_to_usermode_loop+0xe5/0x130
arch/x86/entry/common.c:156
[< inline >] prepare_exit_to_usermode arch/x86/entry/common.c:190
[<ffffffff81006298>] syscall_return_slowpath+0x1a8/0x1e0
arch/x86/entry/common.c:259
[<ffffffff83fc1a62>] entry_SYSCALL_64_fastpath+0xc0/0xc2
Dumping ftrace buffer:
(ftrace buffer empty)
Kernel Offset: disabled
Fix this the same way we did for TCP in commit 565b7b2d2e
("tcp: do not send reset to already closed sockets")
Signed-off-by: Eric Dumazet <edumazet@google.com>
Reported-by: Andrey Konovalov <andreyknvl@google.com>
Tested-by: Andrey Konovalov <andreyknvl@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
|
2016-11-03 16:16:51 -04:00 |
| .. |
|
ccids
|
dccp: re-enable debug macro
|
2014-02-16 23:45:00 -05:00 |
|
ackvec.c
|
dccp: drop null test before destroy functions
|
2015-09-15 16:49:43 -07:00 |
|
ackvec.h
|
net: dccp: Remove extern from function prototypes
|
2013-10-19 19:12:11 -04:00 |
|
ccid.c
|
dccp: drop null test before destroy functions
|
2015-09-15 16:49:43 -07:00 |
|
ccid.h
|
net: dccp: Remove extern from function prototypes
|
2013-10-19 19:12:11 -04:00 |
|
dccp.h
|
net: snmp: kill STATS_BH macros
|
2016-04-27 22:48:25 -04:00 |
|
diag.c
|
sock_diag: specify info_size per inet protocol
|
2015-06-15 19:49:22 -07:00 |
|
feat.c
|
dccp: kerneldoc warning fixes
|
2014-11-18 15:26:31 -05:00 |
|
feat.h
|
net: dccp: Remove extern from function prototypes
|
2013-10-19 19:12:11 -04:00 |
|
input.c
|
dccp: do not assume DCCP code is non preemptible
|
2016-05-02 17:02:25 -04:00 |
|
ipv4.c
|
dccp: do not release listeners too soon
|
2016-11-03 16:16:50 -04:00 |
|
ipv6.c
|
dccp: do not release listeners too soon
|
2016-11-03 16:16:50 -04:00 |
|
ipv6.h
|
inet: includes a sock_common in request_sock
|
2013-10-10 00:08:07 -04:00 |
|
Kconfig
|
net/dccp: remove depends on CONFIG_EXPERIMENTAL
|
2013-01-11 11:39:34 -08:00 |
|
Makefile
|
dccp: Policy-based packet dequeueing infrastructure
|
2010-12-07 13:47:12 +01:00 |
|
minisocks.c
|
dccp: rename DCCP_INC_STATS_BH()
|
2016-04-27 22:48:22 -04:00 |
|
options.c
|
dccp: do not assume DCCP code is non preemptible
|
2016-05-02 17:02:25 -04:00 |
|
output.c
|
net: Generalise wq_has_sleeper helper
|
2015-11-30 14:47:33 -05:00 |
|
probe.c
|
Use 64-bit timekeeping
|
2015-11-01 17:01:16 -05:00 |
|
proto.c
|
dccp: do not send reset to already closed sockets
|
2016-11-03 16:16:51 -04:00 |
|
qpolicy.c
|
dccp qpolicy: Parameter checking of cmsg qpolicy parameters
|
2010-12-07 13:47:12 +01:00 |
|
sysctl.c
|
dccp: make the request_retries minimum is 1
|
2014-05-14 15:34:16 -04:00 |
|
timer.c
|
net: rename NET_{ADD|INC}_STATS_BH()
|
2016-04-27 22:48:24 -04:00 |