Jesper Juhl
0d46c0079a
USB: Remove pointless conditional in drivers/usb/serial/io_ti.c::edge_shutdown() ...
Coverity scan found (CID: 1708) this in
drivers/usb/serial/io_ti.c::edge_shutdown() :
...
2797 for (i=0; i < serial->num_ports; ++i) {
2798 edge_port = usb_get_serial_port_data(serial->port[i]);
2799 edge_remove_sysfs_attrs(edge_port->port);
2800 if (edge_port) {
2801 edge_buf_free(edge_port->ep_out_buf);
2802 kfree(edge_port);
2803 }
2804 usb_set_serial_port_data(serial->port[i], NULL);
2805 }
...
It's complaining that we dereference 'edge_port' in line 2799 which
makes the test of that pointer against NULL in 2800 pointless, since if
edge_port was actually NULL we'd have crashed already before reaching
line 2800.
Reading the edge_open() function it seems to me that the pointer
returned by usb_get_serial_port_data(serial->port[i]) and stored in
'edge_port' can never actually be NULL here, so the test is entirely
superfluous (even if it could be NULL it would be pointless here,
ignoring the then possible crash in that case, since both
edge_buf_free() and kfree() can handle being passed NULL pointers.
This patch removes the pointless conditional (and also makes a few
tiny style corrections now that I was in the area anyway).
Signed-off-by: Jesper Juhl <jesper.juhl@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2007-07-19 17:46:05 -07:00
USB: serial: aircable: clean up urb->status usage
2007-07-12 16:34:31 -07:00
USB: serial: airprime: clean up urb->status usage
2007-07-12 16:34:32 -07:00
USB: serial: ark3116.c: Mixed fixups
2007-07-12 16:34:37 -07:00
USB: serial: belkin_sa: Various needed fixes
2007-07-12 16:34:37 -07:00
USB serial: add dynamic id support to usb-serial core
2007-02-07 15:44:33 -08:00
[PATCH] USB Serial: rename ChangeLog.old
2005-11-17 11:29:52 -08:00
[PATCH] tty: switch to ktermios
2006-12-08 08:28:57 -08:00
USB: CP2101 New Device IDs
2007-04-27 13:28:42 -07:00
USB: serial: cyberjack: clean up urb->status usage
2007-07-12 16:34:32 -07:00
USB: serial: cypress_m8: clean up urb->status usage
2007-07-12 16:34:32 -07:00
[PATCH] USB: cypress_m8: add support for the Nokia ca42-version 2 cable
2006-03-20 14:50:00 -08:00
USB: serial: digi_acceleport: clean up urb->status usage
2007-07-12 16:34:32 -07:00
USB: serial: empeg: clean up urb->status usage
2007-07-12 16:34:32 -07:00
USB: kmemdup() cleanup in drivers/usb/
2006-12-01 14:23:27 -08:00
USB: ftdi_sio: fix oops due to processing workarounds too early
2007-07-12 16:34:40 -07:00
USB: ftdio_sio: New IPlus device ID
2007-06-25 23:38:06 -07:00
USB serial: add driver pointer to all usb-serial drivers
2007-02-07 15:44:34 -08:00
USB: serial: garmin_gps: clean up urb->status usage
2007-07-12 16:34:32 -07:00
USB: serial: generic: clean up urb->status usage
2007-07-12 16:34:33 -07:00
USB serial: add driver pointer to all usb-serial drivers
2007-02-07 15:44:34 -08:00
USB: io_*: remove bogus termios no change checks
2007-07-12 16:34:41 -07:00
USB: io_edgeport: Convert to generic boolean
2007-04-27 13:28:36 -07:00
[PATCH] USB: mark various usb tables const
2006-01-04 13:51:40 -08:00
USB: io_ti: Digi EdgePort update for new devices
2007-07-12 16:29:48 -07:00
USB serial: add driver pointer to all usb-serial drivers
2007-02-07 15:44:34 -08:00
USB: Remove pointless conditional in drivers/usb/serial/io_ti.c::edge_shutdown()
2007-07-19 17:46:05 -07:00
USB: io_ti: Digi EdgePort update for new devices
2007-07-12 16:29:48 -07:00
USB: serial: ipaq: clean up urb->status usage
2007-07-12 16:34:33 -07:00
USB: serial: ipw: clean up urb->status usage
2007-07-12 16:34:33 -07:00
USB: serial: ir_usb: Clean up the worst of it, remove exciting 'crash on open' feature
2007-07-12 16:34:37 -07:00
USB: oti6858 usb-serial driver (in Nokia CA-42 cable)
2007-07-12 16:29:47 -07:00
USB: serial: keyspan: clean up urb->status usage
2007-07-12 16:34:35 -07:00
USB Serial Keyspan: add support for USA-49WG & USA-28XG
2007-07-12 16:29:45 -07:00
USB: serial: keyspan_pda: clean up urb->status usage
2007-07-12 16:34:35 -07:00
USB Serial Keyspan: add support for USA-49WG & USA-28XG
2007-07-12 16:29:45 -07:00
USB: serial: kl5kusb105: clean up urb->status usage
2007-07-12 16:34:35 -07:00
USB: serial: kobil_sct: clean up urb->status usage
2007-07-12 16:34:35 -07:00
USB: oti6858 usb-serial driver (in Nokia CA-42 cable)
2007-07-12 16:29:47 -07:00
USB: serial: mct_u232: clean up urb->status usage
2007-07-12 16:34:35 -07:00
USB: RTS/CTS handshaking support, DTR fixes for MCT U232 serial adapter
2007-07-12 16:29:48 -07:00
USB: mos7720, mos7840: remove redundant urb check
2007-07-19 17:46:04 -07:00
USB: mos7720, mos7840: remove redundant urb check
2007-07-19 17:46:04 -07:00
USB: serial: navman: clean up urb->status usage
2007-07-12 16:34:35 -07:00
USB: serial: omninet: clean up urb->status usage
2007-07-12 16:34:35 -07:00
USB: serial: option: clean up urb->status usage
2007-07-12 16:34:36 -07:00
USB: serial: oti6858: clean up urb->status usage
2007-07-12 16:34:36 -07:00
USB: oti6858 usb-serial driver (in Nokia CA-42 cable)
2007-07-12 16:29:47 -07:00
USB: pl2303: remove bogus checks and fix speed support to use tty_get_baud_rate()
2007-07-12 16:34:41 -07:00
USB: PL2303: Willcom WS002IN Support.
2007-02-16 15:32:17 -08:00
USB: serial: safe_serial: clean up urb->status usage
2007-07-12 16:34:36 -07:00
USB: sierra: Add new devices
2007-07-19 17:46:03 -07:00
USB: serial: ti_usb_3410_5052: clean up urb->status usage
2007-07-12 16:34:36 -07:00
usb-serial: ti_usb, TI ez430 development tool ID
2006-12-01 14:23:30 -08:00
synchronization in usb_serial_put
2007-07-12 16:34:31 -07:00
USB: add driver for the USB debug devices
2006-12-01 14:25:52 -08:00
USB: visor and whiteheat: remove bogus termios change checks
2007-07-12 16:34:41 -07:00
USB: remove duplicate device id from visor
2007-02-07 15:44:40 -08:00
USB: visor and whiteheat: remove bogus termios change checks
2007-07-12 16:34:41 -07:00
USB: whiteheat: Convert to generic boolean
2007-04-27 13:28:39 -07:00
0d46c0079a