Naveen N. Rao
253278f2b5
recordmcount: Fix spurious mcount entries on powerpc ...
[ Upstream commit 80e5302e4bc85a6b685b7668c36c6487b5f90e9a ]
An impending change to enable HAVE_C_RECORDMCOUNT on powerpc leads to
warnings such as the following:
# modprobe kprobe_example
ftrace-powerpc: Not expected bl: opcode is 3c4c0001
WARNING: CPU: 0 PID: 227 at kernel/trace/ftrace.c:2001 ftrace_bug+0x90/0x318
Modules linked in:
CPU: 0 PID: 227 Comm: modprobe Not tainted 5.2.0-rc6-00678-g1c329100b942 #2
NIP: c000000000264318 LR: c00000000025d694 CTR: c000000000f5cd30
REGS: c000000001f2b7b0 TRAP: 0700 Not tainted (5.2.0-rc6-00678-g1c329100b942)
MSR: 900000010282b033 <SF,HV,VEC,VSX,EE,FP,ME,IR,DR,RI,LE,TM[E]> CR: 28228222 XER: 00000000
CFAR: c0000000002642fc IRQMASK: 0
<snip>
NIP [c000000000264318] ftrace_bug+0x90/0x318
LR [c00000000025d694] ftrace_process_locs+0x4f4/0x5e0
Call Trace:
[c000000001f2ba40] [0000000000000004] 0x4 (unreliable)
[c000000001f2bad0] [c00000000025d694] ftrace_process_locs+0x4f4/0x5e0
[c000000001f2bb90] [c00000000020ff10] load_module+0x25b0/0x30c0
[c000000001f2bd00] [c000000000210cb0] sys_finit_module+0xc0/0x130
[c000000001f2be20] [c00000000000bda4] system_call+0x5c/0x70
Instruction dump:
419e0018 2f83ffff 419e00bc 2f83ffea 409e00cc 4800001c 0fe00000 3c62ff96
39000001 39400000 386386d0 480000c4 <0fe00000> 3ce20003 39000001 3c62ff96
---[ end trace 4c438d5cebf78381 ]---
ftrace failed to modify
[<c0080000012a0008>] 0xc0080000012a0008
actual: 01:00:4c:3c
Initializing ftrace call sites
ftrace record flags: 2000000
(0)
expected tramp: c00000000006af4c
Looking at the relocation records in __mcount_loc shows a few spurious
entries:
RELOCATION RECORDS FOR [__mcount_loc]:
OFFSET TYPE VALUE
0000000000000000 R_PPC64_ADDR64 .text.unlikely+0x0000000000000008
0000000000000008 R_PPC64_ADDR64 .text.unlikely+0x0000000000000014
0000000000000010 R_PPC64_ADDR64 .text.unlikely+0x0000000000000060
0000000000000018 R_PPC64_ADDR64 .text.unlikely+0x00000000000000b4
0000000000000020 R_PPC64_ADDR64 .init.text+0x0000000000000008
0000000000000028 R_PPC64_ADDR64 .init.text+0x0000000000000014
The first entry in each section is incorrect. Looking at the
relocation records, the spurious entries correspond to the
R_PPC64_ENTRY records:
RELOCATION RECORDS FOR [.text.unlikely]:
OFFSET TYPE VALUE
0000000000000000 R_PPC64_REL64 .TOC.-0x0000000000000008
0000000000000008 R_PPC64_ENTRY *ABS*
0000000000000014 R_PPC64_REL24 _mcount
<snip>
The problem is that we are not validating the return value from
get_mcountsym() in sift_rel_mcount(). With this entry, mcountsym is 0,
but Elf_r_sym(relp) also ends up being 0. Fix this by ensuring
mcountsym is valid before processing the entry.
Signed-off-by: Naveen N. Rao <naveen.n.rao@linux.vnet.ibm.com>
Acked-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
Tested-by: Satheesh Rajendran <sathnaga@linux.vnet.ibm.com>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Signed-off-by: Sasha Levin <sashal@kernel.org>
2019-08-04 09:33:38 +02:00
fixdep: faster CONFIG_ search
2016-08-24 22:34:19 +02:00
fs: stream_open - opener for stream-like files so that read and write can run simultaneously without deadlock
2019-06-11 12:22:49 +02:00
scripts/dtc: dt_to_config - kernel config options for a devicetree
2016-07-22 14:48:16 -05:00
gcc-plugins: Fix build failures under Darwin host
2019-06-11 12:22:43 +02:00
scripts/gdb/linux/tasks.py: fix get_thread_info
2018-01-23 19:57:08 +01:00
kbuild: Regenerate genksyms lexer
2016-08-25 20:03:51 +02:00
kconfig/[mn]conf: handle backspace (^H) key
2019-05-04 08:49:10 +02:00
modpost: file2alias: check prototype of handler
2019-04-27 09:34:41 +02:00
builddeb: Fix header package regarding dtc source links
2018-05-30 07:50:39 +02:00
selinux: explicitly declare the role "base_r"
2015-07-13 13:32:00 -04:00
ftrace/scripts: Add helper script to bisect function tracing problem functions
2016-09-21 13:56:55 -04:00
KEYS: Reserve an extra certificate symbol for inserting without recompiling
2016-02-26 15:30:20 +00:00
kbuild: make scripts/adjust_autoksyms.sh robust against timestamp races
2018-05-30 07:50:37 +02:00
PM / tools: scripts: AnalyzeSuspend v4.2
2016-07-15 23:34:14 +02:00
ASN.1: fix open failure check on headername
2016-04-06 14:06:48 +01:00
scripts/bloat-o-meter: fix SIGPIPE
2016-11-11 08:12:37 -08:00
kbuild: Make scripts executable
2014-08-20 16:03:45 +02:00
DocBook: Use a fixed encoding for output
2015-09-28 01:31:48 -06:00
scripts: add check_extable.sh script.
2015-04-13 21:03:02 +09:30
checkkconfigsymbols: use arglist instead of cmd string
2016-08-28 11:08:34 +02:00
checkpatch: silence perl 5.26.0 unescaped left brace warnings
2017-07-21 07:42:21 +02:00
scripts/checkstack.pl: Fix arm64 wrong or unknown architecture
2019-07-10 09:55:31 +02:00
x86/asm/entry: Move the arch/x86/syscalls/ definitions to arch/x86/entry/syscalls/
2015-06-04 07:37:37 +02:00
coccinelle: fix parallel build with CHECK=scripts/coccicheck
2017-12-14 09:28:22 +01:00
const_structs.checkpatch: add frequently used from Julia Lawall's list
2016-10-11 15:06:30 -07:00
scripts/decode_stacktrace.sh: prefix addr2line with $CROSS_COMPILE
2019-07-10 09:55:43 +02:00
kbuild: make missing $DEPMOD a Warning instead of an Error
2018-09-15 09:43:01 +02:00
vfs,ext2: remove CONFIG_EXT2_FS_XIP and rename CONFIG_FS_XIP to CONFIG_FS_DAX
2015-02-16 17:56:04 -08:00
docproc: print a comment about autogeneration for rst output
2016-05-14 09:56:56 -06:00
kbuild: Make scripts executable
2014-08-20 16:03:45 +02:00
KEYS: Remove unnecessary header #inclusions from extract-cert.c
2015-09-25 16:31:45 +01:00
scripts/extract-ikconfig: Support LZ4-compressed images.
2015-04-15 14:01:12 +02:00
KEYS: Provide a script to extract a module signature
2015-10-21 15:18:36 +01:00
KEYS: Use the symbol value for list size, updated by scripts/insert-sys-cert
2016-02-26 15:32:05 +00:00
[media] extract_xc3028.pl: move it to scripts/dir
2016-07-17 14:08:12 -03:00
scripts/faddr2line: improve on base path filtering a bit
2016-09-19 14:49:08 -07:00
kbuild: Make scripts executable
2014-08-20 16:03:45 +02:00
kbuild: Make scripts executable
2014-08-20 16:03:45 +02:00
gcc-plugins: abort builds cleanly when not supported
2016-08-08 17:49:05 -07:00
kbuild: Make scripts executable
2014-08-20 16:03:45 +02:00
kbuild: Make scripts executable
2014-08-20 16:03:45 +02:00
scripts/has-stack-protector: add -fno-PIE
2016-11-09 22:28:05 +01:00
initramfs: Escape colons in depfile
2016-09-23 10:35:32 +02:00
[media] doc-rst: move DVB avulse docs to Documentation/media
2016-07-17 14:02:45 -03:00
get_maintainer: quiet noisy implicit -f vcs_file_exists checking
2016-08-26 17:39:34 -07:00
CRIS: Fix headers_install
2014-12-20 00:01:12 +01:00
headers_check: don't warn about c++ guards
2016-05-24 14:12:48 +10:00
Merge branch 'kbuild' of git://git.kernel.org/pub/scm/linux/kernel/git/mmarek/kbuild
2014-10-14 09:22:26 +02:00
KEYS: Reserve an extra certificate symbol for inserting without recompiling
2016-02-26 15:30:20 +00:00
ARM: 8553/1: kallsyms: remove --page-offset command line option
2016-04-07 21:57:16 +01:00
kbuild: simplify ld-option implementation
2019-05-02 09:31:59 +02:00
scripts/kernel-doc: Don't fail with status != 0 if error encountered with -none
2018-02-25 11:05:47 +01:00
scripts/kernel-doc: Adding cross-reference links to html documentation.
2015-08-16 22:11:16 -06:00
ld-version: Drop the 4th and 5th version components
2016-05-13 14:02:05 +02:00
scripts/Lindent: handle missing indent gracefully
2015-09-04 16:54:41 -07:00
kbuild: allow architectures to use thin archives instead of ld -r
2016-09-09 10:31:19 +02:00
GCC plugin infrastructure
2016-06-07 22:57:10 +02:00
kbuild: Remove stale asm-generic wrappers
2016-07-07 15:58:45 +02:00
kbuild: Add support to generate LLVM assembly files
2018-11-23 08:20:35 +01:00
Shared library support
2016-06-07 22:57:10 +02:00
dtbsinstall: don't move target directory out of the way
2016-01-28 11:40:32 +01:00
Kbuild: suppress packed-not-aligned warning for default setting only
2018-12-08 13:05:04 +01:00
kbuild: include $(src)/Makefile rather than $(obj)/Makefile
2015-04-02 16:42:08 +02:00
gcc-plugins: Add latent_entropy plugin
2016-10-10 14:51:44 -07:00
kbuild: collect shorthands into scripts/Kbuild.include
2014-11-26 14:36:52 +01:00
kbuild: Add __cc-option macro
2018-11-23 08:20:35 +01:00
kasan: don't emit builtin calls when sanitization is off
2018-08-17 20:59:29 +02:00
kbuild: fix asm-offset generation to work with clang
2018-11-23 08:20:35 +01:00
modsign: Abort modules_install when signing fails
2015-08-07 16:26:13 +01:00
kbuild: add arch specific post-link Makefile
2016-09-09 10:47:00 +02:00
modsign: lookup lines ending in .ko in .mod files
2014-08-27 21:54:11 +09:30
Kbuild: enable -Wmaybe-uninitialized warning for "make W=1"
2016-11-11 08:45:08 -08:00
kbuild: Make scripts executable
2014-08-20 16:03:45 +02:00
kbuild: Make scripts executable
2014-08-20 16:03:45 +02:00
mksysmap: Add h8300 local symbol pattern
2015-06-23 13:35:47 +09:00
objtool, modules: Discard objtool annotation sections for modules
2018-01-17 09:38:58 +01:00
kallsyms: add support for relative offsets in kallsyms address table
2016-03-15 16:55:16 -07:00
kbuild: Make scripts executable
2014-08-20 16:03:45 +02:00
scripts: add "prune-kernel" script to clean up old kernel images
2016-02-09 10:09:52 -08:00
nmi_backtrace: generate one-line reports for idle cpus
2016-10-07 18:46:30 -07:00
recordmcount: Fix spurious mcount entries on powerpc
2019-08-04 09:33:38 +02:00
nmi_backtrace: generate one-line reports for idle cpus
2016-10-07 18:46:30 -07:00
kbuild: setlocalversion: print error to STDERR
2016-06-20 17:37:45 +02:00
modsign: Make sign-file determine the format of the X.509 cert
2016-06-14 13:18:33 +01:00
parisc: Use generic extable search and sort routines
2016-03-23 16:00:46 +01:00
scripts/sortextable: suppress warning: `relocs_size' may be used uninitialized
2014-10-14 02:18:23 +02:00
spelling.txt: "modeled" is spelt correctly
2016-10-07 18:46:30 -07:00
scripts: add stackdelta script
2015-08-28 17:04:40 +02:00
scripts: add stackusage script
2015-08-28 17:04:40 +02:00
tags: honor COMPILED_SOURCE with apart output directory
2018-04-13 19:48:21 +02:00
unifdef: use memcpy instead of strncpy
2018-12-08 13:05:05 +01:00
ver_linux: rename ver_linux.awk to ver_linux
2016-08-31 13:59:31 +02:00
xen: build infrastructure for generating hypercall depending symbols
2015-03-16 14:49:13 +00:00
kbuild: Make scripts executable
2014-08-20 16:03:45 +02:00
253278f2b5