Andiry Xu
c2d7b49f42
USB: xHCI: prevent infinite loop when processing MSE event ...
When a xHC host is unable to handle isochronous transfer in the
interval, it reports a Missed Service Error event and skips some tds.
Currently xhci driver handles MSE event in the following ways:
1. When encounter a MSE event, set ep->skip flag, update event ring
dequeue pointer and return.
2. When encounter the next event on this ep, the driver will run the
do-while loop, fetch td from ep's td_list to find the td
corresponding to this event. All tds missed are marked as short
transfer(-EXDEV).
The do-while loop will end in two ways:
1. If the td pointed by the event trb is found;
2. If the ep ring's td_list is empty.
However, if a buggy HW reports some unpredicted event (for example, an
overrun event following a MSE event while the ep ring is actually not
empty), the driver will never find the td, and it will loop until the
td_list is empty.
Unfortunately, the spinlock is dropped when give back a urb in the
do-while loop. During the spinlock released period, the class driver
may still submit urbs and add tds to the td_list. This may cause
disaster, since the td_list will never be empty and the loop never ends,
and the system hangs.
To fix this, count the number of TDs on the ep ring before skipping TDs,
and quit the loop when skipped that number of tds. This guarantees the
do-while loop will end after certain number of cycles, and driver will
not be trapped in an infinite loop.
Signed-off-by: Andiry Xu <andiry.xu@amd.com>
Signed-off-by: Sarah Sharp <sarah.a.sharp@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2011-09-19 17:15:47 -07:00
treewide: Convert uses of struct resource to resource_size(ptr)
2011-06-10 14:55:36 +02:00
Merge branch 'master' into for-next
2011-07-11 14:15:55 +02:00
USB: EHCI: Support controllers with big endian capability regs
2011-05-03 11:43:21 -07:00
USB: ehci-au1xxx: fix suspend callback
2011-05-06 18:16:39 -07:00
treewide: Convert uses of struct resource to resource_size(ptr)
2011-06-10 14:55:36 +02:00
USB: EHCI: Support controllers with big endian capability regs
2011-05-03 11:43:21 -07:00
treewide: Convert uses of struct resource to resource_size(ptr)
2011-06-10 14:55:36 +02:00
USB: ehci-fsl: add MPC5121E specific suspend and resume
2011-05-02 16:59:36 -07:00
treewide: Convert uses of struct resource to resource_size(ptr)
2011-06-10 14:55:36 +02:00
Merge branch 'usb-next' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb-2.6
2011-07-25 23:08:32 -07:00
USB: EHCI: Do not rely on PORT_SUSPEND to stop USB resuming in ehci_bus_resume().
2011-08-22 13:38:52 -07:00
treewide: Convert uses of struct resource to resource_size(ptr)
2011-06-10 14:55:36 +02:00
USB: Mark EHCI LPM functions as __maybe_unused
2011-02-17 10:47:55 -08:00
USB: EHCI: AMD periodic frame list table quirk
2010-11-16 13:36:40 -08:00
ehci-msm : use ehci_setup
2011-07-08 14:51:29 -07:00
usb/ehci-mxc: add missing inclusion of mach/hardware.h
2011-08-08 12:34:45 -07:00
treewide: Convert uses of struct resource to resource_size(ptr)
2011-06-10 14:55:36 +02:00
usb: host: ehci-omap: fix .remove and failure handling path of .probe(v1)
2011-08-01 22:06:48 +03:00
USB: EHCI: Support controllers with big endian capability regs
2011-05-03 11:43:21 -07:00
Intel xhci: Support EHCI/xHCI port switching.
2011-05-27 12:07:36 -07:00
treewide: Convert uses of struct resource to resource_size(ptr)
2011-06-10 14:55:36 +02:00
treewide: Convert uses of struct resource to resource_size(ptr)
2011-06-10 14:55:36 +02:00
USB: EHCI: Support controllers with big endian capability regs
2011-05-03 11:43:21 -07:00
EHCI: fix direction handling for interrupt data toggles
2011-07-19 11:25:45 -07:00
usb: s5p-ehci: fix a NULL pointer deference
2011-08-22 13:38:52 -07:00
USB: EHCI: Allow users to override 80% max periodic bandwidth
2011-07-08 14:51:33 -07:00
USB: EHCI: Support controllers with big endian capability regs
2011-05-03 11:43:21 -07:00
USB: EHCI: Support controllers with big endian capability regs
2011-05-03 11:43:21 -07:00
USB: EHCI: Allow users to override 80% max periodic bandwidth
2011-07-08 14:51:33 -07:00
USB: EHCI: Support controllers with big endian capability regs
2011-05-03 11:43:21 -07:00
USB: EHCI: Support controllers with big endian capability regs
2011-05-03 11:43:21 -07:00
treewide: Convert uses of struct resource to resource_size(ptr)
2011-06-10 14:55:36 +02:00
treewide: Convert uses of struct resource to resource_size(ptr)
2011-06-10 14:55:36 +02:00
EHCI: fix direction handling for interrupt data toggles
2011-07-19 11:25:45 -07:00
USB: make hcd.h public (drivers dependency)
2010-05-20 13:21:30 -07:00
treewide: Convert uses of struct resource to resource_size(ptr)
2011-06-10 14:55:36 +02:00
USB: make hcd.h public (drivers dependency)
2010-05-20 13:21:30 -07:00
USB: make hcd.h public (drivers dependency)
2010-05-20 13:21:30 -07:00
USB: make hcd.h public (drivers dependency)
2010-05-20 13:21:30 -07:00
fix comment/printk typos concerning "already"
2010-07-11 21:45:40 +02:00
Fix common misspellings
2011-03-31 11:26:23 -03:00
Fix common misspellings
2011-03-31 11:26:23 -03:00
USB: ehci-fsl: Fix 'have_sysif_regs' detection
2011-01-22 18:38:58 -08:00
USB: convert usb_hcd bitfields into atomic flags
2010-08-10 14:35:37 -07:00
treewide: fix a few typos in comments
2011-05-10 10:16:21 +02:00
Fix common misspellings
2011-03-31 11:26:23 -03:00
USB: imx21-hcd accept arbitary transfer buffer alignement.
2010-10-22 10:22:03 -07:00
USB: remove remaining usages of hcd->state from usbcore and fix regression
2011-05-19 16:34:04 -07:00
Fix common misspellings
2011-03-31 11:26:23 -03:00
sanitize <linux/prefetch.h> usage
2011-05-20 12:50:29 -07:00
USB: host: Remove dead CONFIG_ARCH_KARO
2010-08-10 14:35:40 -07:00
usb/isp1760: Added missing call to usb_hcd_check_unlink_urb() during unlink
2011-08-08 12:34:48 -07:00
usb/isp1760: Improve urb queueing, get rid of BUG():s in normal code paths
2011-05-02 17:03:50 -07:00
dt/usb: Eliminate users of of_platform_{,un}register_driver
2011-02-28 13:22:45 -07:00
USB: UHCI: Support big endian GRUSBHC HC
2011-05-19 16:45:32 -07:00
USB: Add EHCI and OHCH glue for OCTEON II SOCs.
2010-10-29 19:08:44 +01:00
usb: Configure octeon2 glue logic for proper uSOF cycle period.
2011-05-03 10:09:32 -07:00
treewide: Convert uses of struct resource to resource_size(ptr)
2011-06-10 14:55:36 +02:00
USB: ohci-au1xxx: fix warning "__BIG_ENDIAN" is not defined
2011-04-13 15:44:03 -07:00
treewide: Convert uses of struct resource to resource_size(ptr)
2011-06-10 14:55:36 +02:00
treewide: Convert uses of struct resource to resource_size(ptr)
2011-06-10 14:55:36 +02:00
llseek: automatically add .llseek fop
2010-10-15 15:53:27 +02:00
USB: change maintainership of ohci-hcd and ehci-hcd
2011-06-15 17:44:56 -07:00
USB 3.0 Hub Changes
2011-03-13 18:07:11 -07:00
USB: ohci-jz4740: Fix spelling in MODULE_ALIAS
2010-11-11 07:14:07 -08:00
treewide: Convert uses of struct resource to resource_size(ptr)
2011-06-10 14:55:36 +02:00
usb: host: omap: ehci and ohci simplification
2011-03-01 17:02:49 +02:00
OHCI: fix regression caused by nVidia shutdown workaround
2011-05-17 11:20:23 -07:00
i2c: Add support for custom probe function
2010-08-11 18:20:56 +02:00
treewide: Convert uses of struct resource to resource_size(ptr)
2011-06-10 14:55:36 +02:00
treewide: Convert uses of struct resource to resource_size(ptr)
2011-06-10 14:55:36 +02:00
drivers/usb/host/ohci-pxa27x.c: add missing clk_put
2011-06-07 09:07:47 -07:00
USB host: Move AMD PLL quirk to pci-quirks.c
2011-03-01 16:01:45 -05:00
USB: ohci-s3c2410: return proper error if clk_get fails
2011-05-06 18:16:40 -07:00
treewide: Convert uses of struct resource to resource_size(ptr)
2011-06-10 14:55:36 +02:00
usb: update email address in ohci-sh and r8a66597-hcd
2011-07-08 14:57:12 -07:00
treewide: Convert uses of struct resource to resource_size(ptr)
2011-06-10 14:55:36 +02:00
USB host: Adding USB ehci & ohci support for spear platform
2010-11-16 13:53:29 -08:00
Update my e-mail address
2011-07-07 15:18:01 +02:00
treewide: Convert uses of struct resource to resource_size(ptr)
2011-06-10 14:55:36 +02:00
Merge branch 'remove' of master.kernel.org:/home/rmk/linux-2.6-arm
2011-03-16 19:05:40 -07:00
treewide: Convert uses of struct resource to resource_size(ptr)
2011-06-10 14:55:36 +02:00
usb/host/pci-quirks.c: correct annotation of `ehci_dmi_nohandoff_table'
2011-08-08 14:00:14 -07:00
Intel xhci: Support EHCI/xHCI port switching.
2011-05-27 12:07:36 -07:00
Merge branch 'usb-next' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb-2.6
2011-07-25 23:08:32 -07:00
usb: r8a66597-hcd: add function for external controller
2011-07-08 14:57:11 -07:00
Merge branch 'usb-next' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb-2.6
2011-05-23 12:33:02 -07:00
pcmcia: Convert pcmcia_device_id declarations to const
2011-05-06 07:46:22 +02:00
usb: u132-hcd: Drop __TIME__ usage
2011-04-13 16:36:06 -07:00
USB: UHCI: Add support for big endian descriptors
2011-05-19 16:43:20 -07:00
treewide: Convert uses of struct resource to resource_size(ptr)
2011-06-10 14:55:36 +02:00
Merge branch 'usb-next' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb-2.6
2011-05-23 12:33:02 -07:00
USB: UHCI: Add support for big endian descriptors
2011-05-19 16:43:20 -07:00
USB: UHCI: Wrap I/O register accesses
2011-05-06 18:24:01 -07:00
USB: UHCI: Move PCI specific functions to uhci-pci.c
2011-05-06 18:24:00 -07:00
USB: UHCI: Add support for big endian descriptors
2011-05-19 16:43:20 -07:00
Merge 3.0-rc2 into usb-linus as it's needed by some USB patches
2011-06-14 06:51:23 -07:00
xHCI: prolong host controller halt time limit
2011-03-13 18:07:09 -07:00
USB: xhci: Set change bit when warm reset change is set.
2011-09-19 17:15:46 -07:00
Merge branch 'usb-next' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb-2.6
2011-07-25 23:08:32 -07:00
xhci: Add reset on resume quirk for asrock p67 host
2011-06-17 11:28:19 -07:00
USB: xHCI: prevent infinite loop when processing MSE event
2011-09-19 17:15:47 -07:00
xhci: Remove TDs from TD lists when URBs are canceled.
2011-08-09 14:49:25 -07:00
Merge branch 'usb-next' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb-2.6
2011-07-25 23:08:32 -07:00
c2d7b49f42