Jason Wang
f663dd9aaf
net: core: explicitly select a txq before doing l2 forwarding ...
Currently, the tx queue were selected implicitly in ndo_dfwd_start_xmit(). The
will cause several issues:
- NETIF_F_LLTX were removed for macvlan, so txq lock were done for macvlan
instead of lower device which misses the necessary txq synchronization for
lower device such as txq stopping or frozen required by dev watchdog or
control path.
- dev_hard_start_xmit() was called with NULL txq which bypasses the net device
watchdog.
- dev_hard_start_xmit() does not check txq everywhere which will lead a crash
when tso is disabled for lower device.
Fix this by explicitly introducing a new param for .ndo_select_queue() for just
selecting queues in the case of l2 forwarding offload. netdev_pick_tx() was also
extended to accept this parameter and dev_queue_xmit_accel() was used to do l2
forwarding transmission.
With this fixes, NETIF_F_LLTX could be preserved for macvlan and there's no need
to check txq against NULL in dev_hard_start_xmit(). Also there's no need to keep
a dedicated ndo_dfwd_start_xmit() and we can just reuse the code of
dev_queue_xmit() to do the transmission.
In the future, it was also required for macvtap l2 forwarding support since it
provides a necessary synchronization method.
Cc: John Fastabend <john.r.fastabend@intel.com>
Cc: Neil Horman <nhorman@tuxdriver.com>
Cc: e1000-devel@lists.sourceforge.net
Signed-off-by: Jason Wang <jasowang@redhat.com>
Acked-by: Neil Horman <nhorman@tuxdriver.com>
Acked-by: John Fastabend <john.r.fastabend@intel.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
2014-01-10 13:23:08 -05:00
net_sched: Provide default walker function for actions
2013-12-05 19:28:42 -05:00
net_sched: act: Dont increment refcnt on replace
2013-12-27 12:50:00 -05:00
net_sched: act: Dont increment refcnt on replace
2013-12-27 12:50:00 -05:00
net_sched: act: Dont increment refcnt on replace
2013-12-27 12:50:00 -05:00
net_sched: Use default action walker methods
2013-12-05 19:28:43 -05:00
net_sched: act: Dont increment refcnt on replace
2013-12-27 12:50:00 -05:00
net_sched: act: Dont increment refcnt on replace
2013-12-27 12:50:00 -05:00
net_sched: act: Dont increment refcnt on replace
2013-12-27 12:50:00 -05:00
net_sched: act: Dont increment refcnt on replace
2013-12-27 12:50:00 -05:00
net_sched: act: Dont increment refcnt on replace
2013-12-27 12:50:00 -05:00
net_cls: remove duplicated include from cls_api.c
2013-04-07 17:12:01 -04:00
qdisc: basic classifier - remove unnecessary initialization
2013-09-30 15:47:43 -04:00
net: sched: cls_bpf: add BPF-based classifier
2013-10-29 17:33:17 -04:00
cgroup: cls: remove unnecessary task_cls_classid
2013-10-08 16:27:34 -04:00
netlink: rename ssk to sk in struct netlink_skb_params
2013-04-19 14:57:56 -04:00
pkt_sched: fix error return code in fw_change_attrs()
2013-04-19 17:34:53 -04:00
pkt_sched: namespace aware act_mirred
2013-01-14 15:09:36 -05:00
pkt_sched: namespace aware act_mirred
2013-01-14 15:09:36 -05:00
pkt_sched: namespace aware act_mirred
2013-01-14 15:09:36 -05:00
pkt_sched: namespace aware act_mirred
2013-01-14 15:09:36 -05:00
net: em_canid: Ematch rule to match CAN frames according to their identifiers
2012-07-04 13:07:05 +02:00
net_sched: cleanups
2011-01-19 23:31:12 -08:00
em_ipset: use dev_net() accessor
2013-10-18 16:23:06 -04:00
qdisc: meta return ENOMEM on alloc failure
2013-09-30 15:47:43 -04:00
net_sched: cleanups
2011-01-19 23:31:12 -08:00
net_sched: cleanups
2011-01-19 23:31:12 -08:00
net_sched: cleanups
2011-01-19 23:31:12 -08:00
net: Convert net_ratelimit uses to net_<level>_ratelimited
2012-05-15 13:45:03 -04:00
net: sched: cls_bpf: add BPF-based classifier
2013-10-29 17:33:17 -04:00
net: sched: cls_bpf: add BPF-based classifier
2013-10-29 17:33:17 -04:00
net_sched: increment drop counters in qdisc_tree_decrease_qlen()
2013-10-08 16:27:33 -04:00
net_sched: info leak in atm_tc_dump_class()
2013-07-31 15:04:19 -07:00
net_sched: Fix stack info leak in cbq_dump_wrr().
2013-07-30 00:16:21 -07:00
treewide: Add __GFP_NOWARN to k.alloc calls with v.alloc fallbacks
2013-08-20 13:06:40 +02:00
fq_codel: should use qdisc backlog as threshold
2012-05-16 15:30:26 -04:00
net_sched: add 64bit rate estimators
2013-06-11 02:51:03 -07:00
net: sched: factorize code (qdisc_drop())
2012-05-04 11:50:05 -04:00
pkt_sched: Stop using NLA_PUT*().
2012-04-01 18:11:37 -04:00
pkt_sched: fq: fix pacing for small frames
2013-11-15 21:01:52 -05:00
net: fq_codel: Fix off-by-one error
2013-03-29 15:32:23 -04:00
net: core: explicitly select a txq before doing l2 forwarding
2014-01-10 13:23:08 -05:00
net_sched: gred: actually perform idling in WRED mode
2012-09-13 16:10:13 -04:00
net_sched: add 64bit rate estimators
2013-06-11 02:51:03 -07:00
net: sched: htb: fix the calculation of quantum
2013-12-11 15:08:41 -05:00
net_sched: factorize qdisc stats handling
2011-01-10 16:07:54 -08:00
qdisc: allow setting default queuing discipline
2013-08-31 00:32:32 -04:00
qdisc: allow setting default queuing discipline
2013-08-31 00:32:32 -04:00
pkt_sched: Stop using NLA_PUT*().
2012-04-01 18:11:37 -04:00
netem: fix gemodel loss generator
2013-11-30 12:49:29 -05:00
net_sched: sch_plug: plug_qdisc_ops is static
2012-02-13 16:04:40 -05:00
pkt_sched: Stop using NLA_PUT*().
2012-04-01 18:11:37 -04:00
pkt_sched: sch_qfq: remove a source of high packet delay/jitter
2013-07-18 13:02:00 -07:00
pkt_sched: Stop using NLA_PUT*().
2012-04-01 18:11:37 -04:00
sch_sfb: Fix missing NULL check
2012-07-12 08:33:18 -07:00
pkt_sched: Stop using NLA_PUT*().
2012-04-01 18:11:37 -04:00
sch_tbf: use do_div() for 64-bit divide
2013-12-11 22:53:26 -05:00
sch_teql: Convert over to dev_neigh_lookup_skb().
2012-07-05 01:09:06 -07:00
f663dd9aaf