Davide Caratti
079e02e675
net/sched: act_pedit: fix WARN() in the traffic path
[ Upstream commit f67169fef8dbcc1ac6a6a109ecaad0d3b259002c ]
when configuring act_pedit rules, the number of keys is validated only on
addition of a new entry. This is not sufficient to avoid hitting a WARN()
in the traffic path: for example, it is possible to replace a valid entry
with a new one having 0 extended keys, thus causing splats in dmesg like:
pedit BUG: index 42
WARNING: CPU: 2 PID: 4054 at net/sched/act_pedit.c:410 tcf_pedit_act+0xc84/0x1200 [act_pedit]
[...]
RIP: 0010:tcf_pedit_act+0xc84/0x1200 [act_pedit]
Code: 89 fa 48 c1 ea 03 0f b6 04 02 84 c0 74 08 3c 03 0f 8e ac 00 00 00 48 8b 44 24 10 48 c7 c7 a0 c4 e4 c0 8b 70 18 e8 1c 30 95 ea <0f> 0b e9 a0 fa ff ff e8 00 03 f5 ea e9 14 f4 ff ff 48 89 58 40 e9
RSP: 0018:ffff888077c9f320 EFLAGS: 00010286
RAX: 0000000000000000 RBX: 0000000000000000 RCX: ffffffffac2983a2
RDX: 0000000000000001 RSI: 0000000000000008 RDI: ffff888053927bec
RBP: dffffc0000000000 R08: ffffed100a726209 R09: ffffed100a726209
R10: 0000000000000001 R11: ffffed100a726208 R12: ffff88804beea780
R13: ffff888079a77400 R14: ffff88804beea780 R15: ffff888027ab2000
FS: 00007fdeec9bd740(0000) GS:ffff888053900000(0000) knlGS:0000000000000000
CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 00007ffdb3dfd000 CR3: 000000004adb4006 CR4: 00000000001606e0
Call Trace:
tcf_action_exec+0x105/0x3f0
tcf_classify+0xf2/0x410
__dev_queue_xmit+0xcbf/0x2ae0
ip_finish_output2+0x711/0x1fb0
ip_output+0x1bf/0x4b0
ip_send_skb+0x37/0xa0
raw_sendmsg+0x180c/0x2430
sock_sendmsg+0xdb/0x110
__sys_sendto+0x257/0x2b0
__x64_sys_sendto+0xdd/0x1b0
do_syscall_64+0xa5/0x4e0
entry_SYSCALL_64_after_hwframe+0x49/0xbe
RIP: 0033:0x7fdeeb72e993
Code: 48 8b 0d e0 74 2c 00 f7 d8 64 89 01 48 83 c8 ff c3 66 0f 1f 44 00 00 83 3d 0d d6 2c 00 00 75 13 49 89 ca b8 2c 00 00 00 0f 05 <48> 3d 01 f0 ff ff 73 34 c3 48 83 ec 08 e8 4b cc 00 00 48 89 04 24
RSP: 002b:00007ffdb3de8a18 EFLAGS: 00000246 ORIG_RAX: 000000000000002c
RAX: ffffffffffffffda RBX: 000055c81972b700 RCX: 00007fdeeb72e993
RDX: 0000000000000040 RSI: 000055c81972b700 RDI: 0000000000000003
RBP: 00007ffdb3dea130 R08: 000055c819728510 R09: 0000000000000010
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000040
R13: 000055c81972b6c0 R14: 000055c81972969c R15: 0000000000000080
Fix this moving the check on 'nkeys' earlier in tcf_pedit_init(), so that
attempts to install rules having 0 keys are always rejected with -EINVAL.
Fixes: 1da177e4c3 ("Linux-2.6.12-rc2")
Signed-off-by: Davide Caratti <dcaratti@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
2019-11-28 18:28:04 +01:00 |
| .. |
|
6lowpan
|
6lowpan: iphc: reset mac_header after decompress to fix panic
|
2018-10-03 17:01:42 -07:00 |
|
9p
|
9p/virtio: Add cleanup path in p9_virtio_init
|
2019-08-04 09:33:28 +02:00 |
|
802
|
|
|
|
8021q
|
vlan: disable SIOCSHWTSTAMP in container
|
2019-05-16 19:43:46 +02:00 |
|
appletalk
|
appletalk: enforce CAP_NET_RAW for raw sockets
|
2019-10-05 12:30:15 +02:00 |
|
atm
|
net: atm: Fix potential Spectre v1 vulnerabilities
|
2019-04-27 09:34:40 +02:00 |
|
ax25
|
ax25: enforce CAP_NET_RAW for raw sockets
|
2019-10-05 12:30:15 +02:00 |
|
batman-adv
|
batman-adv: Only read OGM2 tvlv_len after buffer len check
|
2019-09-21 07:14:14 +02:00 |
|
bluetooth
|
Bluetooth: L2CAP: Detect if remote is not able to use the whole MPS
|
2019-11-25 09:53:00 +01:00 |
|
bridge
|
bridge/mdb: remove wrong use of NLM_F_MULTI
|
2019-09-21 07:14:01 +02:00 |
|
caif
|
caif: reduce stack size with KASAN
|
2019-05-08 07:19:07 +02:00 |
|
can
|
can: purge socket error queue on sock destruct
|
2019-07-10 09:55:33 +02:00 |
|
ceph
|
libceph: use kbasename() and kill ceph_file_part()
|
2019-08-11 12:22:15 +02:00 |
|
core
|
net: rtnetlink: prevent underflows in do_setvfinfo()
|
2019-11-28 18:28:02 +01:00 |
|
dcb
|
net: dcb: For wild-card lookups, use priority -1, not 0
|
2018-09-19 22:47:15 +02:00 |
|
dccp
|
inet: stop leaking jiffies on the wire
|
2019-11-10 11:23:29 +01:00 |
|
decnet
|
dn_getsockoptdecnet: move nf_{get/set}sockopt outside sock lock
|
2018-02-25 11:05:44 +01:00 |
|
dns_resolver
|
KEYS: DNS: fix parsing multiple options
|
2018-07-22 14:27:39 +02:00 |
|
dsa
|
net: dsa: fix switch tree list
|
2019-11-10 11:23:26 +01:00 |
|
ethernet
|
net: introduce device min_header_len
|
2017-02-18 15:11:43 +01:00 |
|
hsr
|
net/hsr: fix possible crash in add_timer()
|
2019-03-19 13:14:08 +01:00 |
|
ieee802154
|
ieee802154: enforce CAP_NET_RAW for raw sockets
|
2019-10-05 12:30:15 +02:00 |
|
ipv4
|
ip_gre: fix parsing gre header in ipgre_err
|
2019-11-25 09:52:23 +01:00 |
|
ipv6
|
Revert "net: sit: fix memory leak in sit_init_net()"
|
2019-10-29 09:15:26 +01:00 |
|
ipx
|
ipx: call ipxitf_put() in ioctl error path
|
2017-05-25 15:44:41 +02:00 |
|
irda
|
irda: Only insert new objects into the global database via setsockopt
|
2018-09-15 09:43:01 +02:00 |
|
iucv
|
net/iucv: Free memory obtained by kzalloc
|
2018-03-31 18:11:34 +02:00 |
|
kcm
|
kcm: switch order of device registration to fix a crash
|
2019-04-17 08:36:44 +02:00 |
|
key
|
xfrm: clean up xfrm protocol checks
|
2019-09-16 08:19:32 +02:00 |
|
l2tp
|
compat_ioctl: pppoe: fix PPPOEIOCSFWD handling
|
2019-08-11 12:22:17 +02:00 |
|
l3mdev
|
net: ipv6: Remove l3mdev_get_saddr6
|
2016-09-10 23:12:53 -07:00 |
|
lapb
|
lapb: fixed leak of control-blocks.
|
2019-06-22 08:17:22 +02:00 |
|
llc
|
llc: avoid blocking in llc_sap_close()
|
2019-11-25 09:52:18 +01:00 |
|
mac80211
|
mac80211: minstrel: fix CCK rate group streams value
|
2019-11-25 09:53:52 +01:00 |
|
mac802154
|
net: mac802154: tx: expand tailroom if necessary
|
2018-09-09 20:01:19 +02:00 |
|
mpls
|
mpls, nospec: Sanitize array index in mpls_label_ok()
|
2018-03-11 16:21:34 +01:00 |
|
ncsi
|
net/ncsi: Improve HNCDSC AEN handler
|
2016-10-20 11:23:08 -04:00 |
|
netfilter
|
ipvs: move old_secure_tcp into struct netns_ipvs
|
2019-11-12 19:15:57 +01:00 |
|
netlabel
|
netlabel: fix out-of-bounds memory accesses
|
2019-03-13 14:04:53 -07:00 |
|
netlink
|
netlink: Don't shift on 64 for ngroups
|
2018-08-09 12:17:59 +02:00 |
|
netrom
|
netrom: hold sock when setting skb->destructor
|
2019-08-04 09:33:35 +02:00 |
|
nfc
|
nfc: netlink: fix double device reference drop
|
2019-11-12 19:15:39 +01:00 |
|
openvswitch
|
net: ovs: fix return type of ndo_start_xmit function
|
2019-11-25 09:53:15 +01:00 |
|
packet
|
net/packet: fix race in tpacket_snd()
|
2019-08-25 10:51:51 +02:00 |
|
phonet
|
phonet: fix building with clang
|
2019-03-23 13:19:44 +01:00 |
|
qrtr
|
net: qrtr: Stop rx_worker before freeing node
|
2019-10-05 12:30:13 +02:00 |
|
rds
|
net/rds: Fix error handling in rds_ib_add_one()
|
2019-10-07 18:53:23 +02:00 |
|
rfkill
|
rfkill: gpio: fix memory leak in probe error path
|
2018-05-16 10:08:43 +02:00 |
|
rose
|
net: rose: fix a possible stack overflow
|
2019-04-03 06:24:14 +02:00 |
|
rxrpc
|
rxrpc: Fix send on a connected, but unbound socket
|
2019-08-04 09:33:34 +02:00 |
|
sched
|
net/sched: act_pedit: fix WARN() in the traffic path
|
2019-11-28 18:28:04 +01:00 |
|
sctp
|
inet: stop leaking jiffies on the wire
|
2019-11-10 11:23:29 +01:00 |
|
strparser
|
strparser: Fix incorrect strp->need_bytes value.
|
2018-04-29 11:32:02 +02:00 |
|
sunrpc
|
SUNRPC: Fix priority queue fairness
|
2019-11-25 09:53:19 +01:00 |
|
switchdev
|
switchdev: Execute bridge ndos only for bridge ports
|
2016-10-19 10:58:04 -04:00 |
|
tipc
|
tipc: add NULL pointer check before calling kfree_rcu
|
2019-09-21 07:14:03 +02:00 |
|
unix
|
missing barriers in some of unix_sock ->addr and ->path accesses
|
2019-03-19 13:14:10 +01:00 |
|
vmw_vsock
|
vsock/virtio: Initialize core virtio vsock before registering the driver
|
2019-05-25 18:26:44 +02:00 |
|
wimax
|
|
|
|
wireless
|
nl80211: Fix a GET_KEY reply attribute
|
2019-11-25 09:53:23 +01:00 |
|
x25
|
net/x25: fix a race in x25_bind()
|
2019-03-19 13:14:09 +01:00 |
|
xfrm
|
xfrm: clean up xfrm protocol checks
|
2019-09-16 08:19:32 +02:00 |
|
compat.c
|
sock: Make sock->sk_stamp thread-safe
|
2019-01-09 16:16:41 +01:00 |
|
Kconfig
|
|
|
|
Makefile
|
|
|
|
socket.c
|
bpf: get rid of pure_initcall dependency to enable jits
|
2019-08-25 10:51:40 +02:00 |
|
sysctl_net.c
|
Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/ebiederm/user-namespace
|
2016-10-06 09:52:23 -07:00 |