* 4.9/tmp-75d78c7:
Linux 4.9.35
brcmfmac: fix uninitialized warning in brcmf_usb_probe_phase2()
jump label: fix passing kbuild_cflags when checking for asm goto support
net: phy: fix marvell phy status reading
spi: double time out tolerance
dmaengine: bcm2835: Fix cyclic DMA period splitting
net: phy: Initialize mdio clock at probe function
rt2x00: avoid introducing a USB dependency in the rt2x00lib module
usb: gadget: f_fs: avoid out of bounds access on comp_desc
mtd: spi-nor: fix spansion quad enable
of: Add check to of_scan_flat_dt() before accessing initial_boot_params
rxrpc: Fix several cases where a padded len isn't checked in ticket decode
drm/amdgpu: adjust default display clock
drm/amdgpu/atom: fix ps allocation size for EnableDispPowerGating
drm/radeon: add a quirk for Toshiba Satellite L20-183
drm/radeon: add a PX quirk for another K53TK variant
iscsi-target: Reject immediate data underflow larger than SCSI transfer length
iscsi-target: Fix delayed logout processing greater than SECONDS_FOR_LOGOUT_COMP
target: Fix kref->refcount underflow in transport_cmd_finish_abort
arm64/vdso: Fix nsec handling for CLOCK_MONOTONIC_RAW
time: Fix CLOCK_MONOTONIC_RAW sub-nanosecond accounting
time: Fix clock->read(clock) race around clocksource changes
brcmfmac: unbind all devices upon failure in firmware callback
brcmfmac: use firmware callback upon failure to load
brcmfmac: add parameter to pass error code in firmware callback
Input: i8042 - add Fujitsu Lifebook AH544 to notimeout list
powerpc/64s: Handle data breakpoints in Radix mode
powerpc/kprobes: Pause function_graph tracing during jprobes handling
signal: Only reschedule timers on signals timers have sent
HID: Add quirk for Dell PIXART OEM mouse
cxgb4: notify uP to route ctrlq compl to rdma rspq
CIFS: Improve readdir verbosity
KVM: PPC: Book3S HV: Context-switch EBB registers properly
KVM: PPC: Book3S HV: Preserve userspace HTM state properly
KVM: s390: gaccess: fix real-space designation asce handling for gmap shadows
perf/x86/intel: Add 1G DTLB load/store miss support for SKL
lib/cmdline.c: fix get_options() overflow while parsing ranges
autofs: sanity check status reported with AUTOFS_DEV_IOCTL_FAIL
powerpc/perf: Fix oops when kthread execs user process
fs/exec.c: account for argv/envp pointers
ALSA: pcm: Don't treat NULL chmap as a fatal error
ALSA: firewire-lib: Fix stall of process context at packet error
xen-blkback: don't leak stack data via response ring
xen/blkback: fix disconnect while I/Os in flight
clk: sunxi-ng: a31: Correct lcd1-ch1 clock register offset
Revert "ANDROID: hardlockup: detect hard lockups without NMIs using secondary cpus"
Revert "ANDROID: kernel/watchdog: fix unused variable warning"
UPSTREAM: usb: gadget: f_fs: avoid out of bounds access on comp_desc
Linux 4.9.34
mm: fix new crash in unmapped_area_topdown()
Allow stack to grow up to address space limit
mm: larger stack guard gap, between vmas
alarmtimer: Rate limit periodic intervals
crypto: Work around deallocated stack frame reference gcc bug on sparc.
vTPM: Fix missing NULL check
MIPS: .its targets depend on vmlinux
MIPS: Fix bnezc/jialc return address calculation
usb: dwc3: exynos fix axius clock error path to do cleanup
usb: gadget: composite: Fix function used to free memory
alarmtimer: Prevent overflow of relative timers
genirq: Release resources in __setup_irq() error path
sched/core: Idle_task_exit() shouldn't use switch_mm_irqs_off()
iio: imu: inv_mpu6050: add accel lpf setting for chip >= MPU6500
swap: cond_resched in swap_cgroup_prepare()
mm/memory-failure.c: use compound_head() flags for huge pages
USB: gadgetfs, dummy-hcd, net2280: fix locking for callbacks
USB: gadget: fix GPF in gadgetfs
usb: xhci: ASMedia ASM1042A chipset need shorts TX quirk
usb: xhci: Fix USB 3.1 supported protocol parsing
drivers/misc/c2port/c2port-duramar2150.c: checking for NULL instead of IS_ERR()
misc: mic: double free on ioctl error path
ath10k: fix napi crash during rmmod when probe firmware fails
usb: r8a66597-hcd: decrease timeout
usb: r8a66597-hcd: select a different endpoint on timeout
USB: gadget: dummy_hcd: fix hub-descriptor removable fields
pvrusb2: reduce stack usage pvr2_eeprom_analyze()
USB: usbip: fix nonconforming hub descriptor
usb: core: fix potential memory leak in error path during hcd creation
USB: hub: fix SS max number of ports
usb: gadget: udc: renesas_usb3: lock for PN_ registers access
usb: gadget: udc: renesas_usb3: fix deadlock by spinlock
usb: gadget: udc: renesas_usb3: fix pm_runtime functions calling
IB/mlx5: Fix kernel to user leak prevention logic
iio: adc: ti_am335x_adc: allocating too much in probe
iio: proximity: as3935: recalibrate RCO after resume
iio: st_pressure: Fix data sign
staging: iio: tsl2x7x_core: Fix standard deviation calculation
staging: rtl8188eu: prevent an underflow in rtw_check_beacon_data()
mfd: omap-usb-tll: Fix inverted bit use for USB TLL mode
x86/mm/32: Set the '__vmalloc_start_set' flag in initmem_init()
serial: sh-sci: Fix late enablement of AUTORTS
serial: efm32: Fix parity management in 'efm32_uart_console_get_options()'
drm/vc4: Fix OOPSes from trying to cache a partially constructed BO.
drm/mediatek: fix mtk_hdmi_setup_vendor_specific_infoframe mistake
mac80211: don't send SMPS action frame in AP mode when not needed
mac80211: fix dropped counter in multiqueue RX
mac80211: strictly check mesh address extension mode
mac80211: fix IBSS presp allocation size
mac80211: fix packet statistics for fast-RX
mac80211: fix CSA in IBSS mode
usb: musb: dsps: keep VBUS on for host-only mode
drm/i915: Fix GVT-g PVINFO version compatibility check
drm/amdgpu: Fix overflow of watermark calcs at > 4k resolutions.
mac80211/wpa: use constant time memory comparison for MACs
mac80211: don't look at the PM bit of BAR frames
vb2: Fix an off by one error in 'vb2_plane_vaddr'
cpufreq: conservative: Allow down_threshold to take values from 1 to 10
ila_xlat: add missing hash secret initialization
can: gs_usb: fix memory leak in gs_cmd_reset()
configfs: Fix race between create_link and configfs_rmdir
fs: pass on flags in compat_writev
ANDROID: sdcardfs: remove dead function open_flags_to_access_mode()
ANDROID: android-base.cfg: split out arm64-specific configs
Linux 4.9.33
sparc64: make string buffers large enough
drm/i915: Always recompute watermarks when distrust_bios_wm is set, v2.
drm/i915: Workaround VLV/CHV DSI scanline counter hardware fail
s390/kvm: do not rely on the ILC on kvm host protection fauls
xtensa: don't use linux IRQ #0
RDMA/qedr: Return max inline data in QP query result
RDMA/qedr: Don't spam dmesg if QP is in error state
RDMA/qedr: Don't reset QP when queues aren't flushed
RDMA/qedr: Fix and simplify memory leak in PD alloc
RDMA/qedr: Dispatch port active event from qedr_add
netfilter: nft_log: restrict the log prefix length to 127
netfilter: nf_tables: fix set->nelems counting with no NLM_F_EXCL
tipc: fix nametbl_lock soft lockup at node/link events
tipc: add subscription refcount to avoid invalid delete
tipc: fix connection refcount error
tipc: ignore requests when the connection state is not CONNECTED
ARCv2: smp-boot: wake_flag polling by non-Masters needs to be uncached
ARC: smp-boot: Decouple Non masters waiting API from jump to entry point
vhost/vsock: handle vhost_vq_init_access() error
kernel/watchdog: prevent false hardlockup on overloaded system
kernel/watchdog.c: move shared definitions to nmi.h
kernel/watchdog.c: move hardlockup detector to separate file
userfaultfd: fix SIGBUS resulting from false rwsem wakeups
proc: add a schedule point in proc_pid_readdir()
frv: add missing atomic64 operations
frv: add atomic64_add_unless()
romfs: use different way to generate fsid for BLOCK or MTD
mn10300: fix build error of missing fpu_save()
usb: musb: Fix external abort on non-linefetch for musb_irq_work()
sctp: sctp_addr_id2transport should verify the addr before looking up assoc
sctp: sctp gso should set feature with NETIF_F_SG when calling skb_segment
bnxt_en: Fix RTNL lock usage on bnxt_get_port_module_status().
bnxt_en: Fix RTNL lock usage on bnxt_update_link().
bnxt_en: Enhance autoneg support.
bnxt_en: Fix bnxt_reset() in the slow path task.
net-next: ethernet: mediatek: change the compatible string
r8152: avoid start_xmit to schedule napi when napi is disabled
r8152: fix rtl8152_post_reset function
r8152: re-schedule napi for tx
r8152: check rx after napi is enabled
r8152: avoid start_xmit to call napi_schedule during autosuspend
nvmet-rdma: Fix missing dma sync to nvme data structures
nfs: Fix "Don't increment lock sequence ID after NFS4ERR_MOVED"
ravb: unmap descriptors when freeing rings
drm/ast: Fixed system hanged if disable P2A
drm/nouveau: Fix drm poll_helper handling
drm/nouveau: Don't enabling polling twice on runtime resume
drm/nouveau: Handle fbcon suspend/resume in seperate worker
drm/nouveau: Rename acpi_work to hpd_work
drm/nouveau: Intercept ACPI_VIDEO_NOTIFY_PROBE
gtp: add genl family modules alias
net: phy: micrel: add support for KSZ8795
parisc, parport_gsc: Fixes for printk continuation lines
net/mlx5: Return EOPNOTSUPP when failing to get steering name-space
net/mlx5: E-Switch, Err when retrieving steering name-space fails
drm/i915: Check for NULL i915_vma in intel_unpin_fb_obj()
net: adaptec: starfire: add checks for dma mapping errors
pinctrl: berlin-bg4ct: fix the value for "sd1a" of pin SCRD0_CRD_PRES
drm: Don't race connector registration
drm: prevent double-(un)registration for connectors
cec: fix wrong last_la determination
pinctrl: baytrail: Rectify debounce support (part 2)
gianfar: synchronize DMA API usage by free_skb_rx_queue w/ gfar_new_page
net/mlx4_core: Avoid command timeouts during VF driver device shutdown
drm/nouveau/fence/g84-: protect against concurrent access to semaphore buffers
drm/nouveau: prevent userspace from deleting client object
ipv6: fix flow labels when the traffic class is non-0
FS-Cache: Initialise stores_lock in netfs cookie
fscache: Clear outstanding writes when disabling a cookie
fscache: Fix dead object requeue
net: fix ndo_features_check/ndo_fix_features comment ordering
net: phy: Fix PHY module checks and NULL deref in phy_attach_direct()
net: phy: Fix lack of reference count on PHY driver
ethtool: do not vzalloc(0) on registers dump
log2: make order_base_2() behave correctly on const input value zero
kasan: respect /proc/sys/kernel/traceoff_on_warning
shmem: fix sleeping from atomic context
jump label: pass kbuild_cflags when checking for asm goto support
PM / runtime: Avoid false-positive warnings from might_sleep_if()
ARM: defconfigs: make NF_CT_PROTO_SCTP and NF_CT_PROTO_UDPLITE built-in
ipv6: Fix IPv6 packet loss in scenarios involving roaming + snooping switches
vfio/spapr_tce: Set window when adding additional groups to container
ipv6: addrconf: fix generation of new temporary addresses
net: thunderx: Fix PHY autoneg for SGMII QLM mode
kernel/ucount.c: mark user_header with kmemleak_ignore()
powerpc/powernv: Properly set "host-ipi" on IPIs
i2c: piix4: Fix request_region size
i2c: piix4: Request the SMBUS semaphore inside the mutex
sierra_net: Add support for IPv6 and Dual-Stack Link Sense Indications
sierra_net: Skip validating irrelevant fields for IDLE LSIs
net: hns: Fix the device being used for dma mapping during TX
NET: mkiss: Fix panic
ibmvnic: Initialize completion variables before starting work
ibmvnic: Call napi_disable instead of napi_enable in failure path
NET: Fix /proc/net/arp for AX.25
gfs2: Use rhashtable walk interface in glock_hash_walk
tipc: Fix tipc_sk_reinit race conditions
ipv6: Inhibit IPv4-mapped src address on the wire.
ipv6: Handle IPv4-mapped src to in6addr_any dst.
tcp: tcp_probe: use spin_lock_bh()
net: xilinx_emaclite: fix receive buffer overflow
net: xilinx_emaclite: fix freezes due to unordered I/O
ibmvnic: Fix endian error when requesting device capabilities
ibmvnic: Fix endian errors in error reporting output
netfilter: nf_conntrack_sip: fix wrong memory initialisation
partitions/msdos: FreeBSD UFS2 file systems are not recognized
drm/i915: Prevent the system suspend complete optimization
PCI/PM: Add needs_resume flag to avoid suspend complete optimization
usb: gadget: f_fs: Fix possibe deadlock
FROMLIST: Remove the redundant skb->dev initialization in ip6_fragment
FROMLIST: bpf: Remove duplicate tcp_filter hook in ipv6
FROMLIST: ipv6: Initial skb->dev and skb->protocol in ip6_output
FROMLIST: bpf: cgroup skb progs cannot access ld_abs/ind
ANDROID: uid_sys_stats: check previous uid_entry before call find_or_register_uid
Conflicts:
drivers/usb/gadget/function/f_fs.c
kernel/watchdog.c
Change-Id: Ib91e6121cace8bcdc4dd8b1727792dd5bb6f1535
Signed-off-by: Kyle Yan <kyan@codeaurora.org>
-----BEGIN PGP SIGNATURE-----
iQIzBAABCAAdFiEEZH8oZUiU471FcZm+ONu9yGCSaT4FAllN9TgACgkQONu9yGCS
aT4MZhAAv4d43UJkriI3sSdMqhbI2KreInwx5uxMwKGkizMEvfatSCqNSJn+HKG+
VwuVErCOqq1eneF+MW3t0hqFtI2Hcq/5DxwHEl3Xs+7Qsv7F0F+B2/ilba/52XYQ
ShwGm96bOjHDcDLdeeiHAui09ReH3iwtUKw2rwd6WTS+KMcNTF/e9eZeWniZ5DVE
okbt++23tyxzm/3f0O8XLXnEYhpQ5zSJRltGnpVZf9FadHD3zFeGb4zWLRVsNfpO
dpfGmKgYQr0aLeW4uSRCvkrye8htBbQkH+NOAhpY6SZLIJK1qeXwtAjxOmREfTal
urV4YbGiGDpkPw3JDjBMV1OuHLp4jp5km475od1wXmMKlUjTQVGdAMh0ak6/o0UZ
GoTKozoZ7vhsukKnLdzfCWN0yShuUyOHnBb63nDi8zs75nYSlwLESlZBRvdXJN1+
vZKsgebxyp2GHaOEndU27sVvtIV134LWwso/t4O+bG9RcY4nvz7rr+LwsjuXh5AF
X/or/IeD3GC8n7/nXn53a2An25IU8u8EwYcMicygmhHAyKQCtfU5L0bHVMkRwbsC
RjYRKCpKbjCryR7SD2aJ+ly2EuhBBZrZnpFIyPNZy0FPbH0kDGDh3YkAN5Qlj6kc
HlcSR/4jg4KnZe16xAKXR1u4d9/DNcYseYKRMvwBd993P5TH7lU=
=0xi/
-----END PGP SIGNATURE-----
Merge 4.9.34 into android-4.9
Changes in 4.9.34
fs: pass on flags in compat_writev
configfs: Fix race between create_link and configfs_rmdir
can: gs_usb: fix memory leak in gs_cmd_reset()
ila_xlat: add missing hash secret initialization
cpufreq: conservative: Allow down_threshold to take values from 1 to 10
vb2: Fix an off by one error in 'vb2_plane_vaddr'
mac80211: don't look at the PM bit of BAR frames
mac80211/wpa: use constant time memory comparison for MACs
drm/amdgpu: Fix overflow of watermark calcs at > 4k resolutions.
drm/i915: Fix GVT-g PVINFO version compatibility check
usb: musb: dsps: keep VBUS on for host-only mode
mac80211: fix CSA in IBSS mode
mac80211: fix packet statistics for fast-RX
mac80211: fix IBSS presp allocation size
mac80211: strictly check mesh address extension mode
mac80211: fix dropped counter in multiqueue RX
mac80211: don't send SMPS action frame in AP mode when not needed
drm/mediatek: fix mtk_hdmi_setup_vendor_specific_infoframe mistake
drm/vc4: Fix OOPSes from trying to cache a partially constructed BO.
serial: efm32: Fix parity management in 'efm32_uart_console_get_options()'
serial: sh-sci: Fix late enablement of AUTORTS
x86/mm/32: Set the '__vmalloc_start_set' flag in initmem_init()
mfd: omap-usb-tll: Fix inverted bit use for USB TLL mode
staging: rtl8188eu: prevent an underflow in rtw_check_beacon_data()
staging: iio: tsl2x7x_core: Fix standard deviation calculation
iio: st_pressure: Fix data sign
iio: proximity: as3935: recalibrate RCO after resume
iio: adc: ti_am335x_adc: allocating too much in probe
IB/mlx5: Fix kernel to user leak prevention logic
usb: gadget: udc: renesas_usb3: fix pm_runtime functions calling
usb: gadget: udc: renesas_usb3: fix deadlock by spinlock
usb: gadget: udc: renesas_usb3: lock for PN_ registers access
USB: hub: fix SS max number of ports
usb: core: fix potential memory leak in error path during hcd creation
USB: usbip: fix nonconforming hub descriptor
pvrusb2: reduce stack usage pvr2_eeprom_analyze()
USB: gadget: dummy_hcd: fix hub-descriptor removable fields
usb: r8a66597-hcd: select a different endpoint on timeout
usb: r8a66597-hcd: decrease timeout
ath10k: fix napi crash during rmmod when probe firmware fails
misc: mic: double free on ioctl error path
drivers/misc/c2port/c2port-duramar2150.c: checking for NULL instead of IS_ERR()
usb: xhci: Fix USB 3.1 supported protocol parsing
usb: xhci: ASMedia ASM1042A chipset need shorts TX quirk
USB: gadget: fix GPF in gadgetfs
USB: gadgetfs, dummy-hcd, net2280: fix locking for callbacks
mm/memory-failure.c: use compound_head() flags for huge pages
swap: cond_resched in swap_cgroup_prepare()
iio: imu: inv_mpu6050: add accel lpf setting for chip >= MPU6500
sched/core: Idle_task_exit() shouldn't use switch_mm_irqs_off()
genirq: Release resources in __setup_irq() error path
alarmtimer: Prevent overflow of relative timers
usb: gadget: composite: Fix function used to free memory
usb: dwc3: exynos fix axius clock error path to do cleanup
MIPS: Fix bnezc/jialc return address calculation
MIPS: .its targets depend on vmlinux
vTPM: Fix missing NULL check
crypto: Work around deallocated stack frame reference gcc bug on sparc.
alarmtimer: Rate limit periodic intervals
mm: larger stack guard gap, between vmas
Allow stack to grow up to address space limit
mm: fix new crash in unmapped_area_topdown()
Linux 4.9.34
Signed-off-by: Greg Kroah-Hartman <gregkh@google.com>
commit 93491ced3c87c94b12220dbac0527e1356702179 upstream.
Add define for the maximum number of ports on a SuperSpeed hub as per
USB 3.1 spec Table 10-5, and use it when verifying the retrieved hub
descriptor.
This specifically avoids benign attempts to update the DeviceRemovable
mask for non-existing ports (should we get that far).
Fixes: dbe79bbe9d ("USB 3.0 Hub Changes")
Acked-by: Alan Stern <stern@rowland.harvard.edu>
Signed-off-by: Johan Hovold <johan@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Johan Hovoldauthored and Greg Kroah-Hartmancommited 2017-06-24 07:11:15 +02:00
BADD(Basic Audio Device Definition) is a subset of UAC3
specifications. It defines standard profiles which provide
specific attributes of class descriptors. BADD audio device
provides profile id and BADD supporting host will infer
attributes from profile-id.
Currently USB Audio Host driver has support for UAC1
and UAC2 devices. To handle BADD 3.0 devices, AudioControl
and AudioStreaming Interfaces have to be properly parsed.
The Host has to derive all class-specific information based
on the profile ID that the device exposes. Add support for
parsing the AudioStreaming interfaces exposed by the device.
Change-Id: I726bbb735708fe8e395011c7228a73d5f65c092d
Signed-off-by: Ajay Agarwal <ajaya@codeaurora.org>
Signed-off-by: Hemant Kumar <hemantk@codeaurora.org>
Ajay Agarwalauthored and Hemant Kumarcommited 2017-05-15 14:29:10 -07:00
This change adds USB GSI function driver which provides USB RMNET/RNDIS/
ECM/MBIM/DPL related functionalities with GSI hardware accelerated path.
This snapshot is taken as of msm-4.4 commit 4195f84bde61 ("qcom-charger:
smb2: add support of PMFALCON").
It removes usage of debug.h and related functionality used for debugging
purpose. IPC logging based debug functionality shall be added later.
Change-Id: Ia6915c76deb084ebb789ae33c509e835502cfcf1
Signed-off-by: Mayank Rana <mrana@codeaurora.org>
Move the entire contents of linux/usb/f_accessory.h header to uapi,
it only contains a userspace interface.
Change-Id: Ieb5547da449588ae554988a201c0e6b4e3afc531
Signed-off-by: Colin Cross <ccross@android.com>
Colin Crossauthored and Dmitry Shmidtcommited 2017-01-19 13:33:05 -08:00
Move the most of linux/usb/f_mtp.h header to uapi. Move the only
remaining structure definition into f_mtp.c, the only place that
uses it.
Change-Id: I952c1a9dc15c36bf295a0eb4d74b6b1ad912ed03
Signed-off-by: Colin Cross <ccross@android.com>
Colin Crossauthored and Dmitry Shmidtcommited 2017-01-19 13:33:04 -08:00
f_gsi compilation is failing with below error:
fatal error: linux/usb/usb_ctrl_qti.h: No such file or directory
Hence add missing usb_ctrl_qti.h to resolve above error while
compiling f_gsi.c file.
This file's snapshot is taken from msm-3.18 kernel as
'commit 24b986908cc1 ("power: qpnp-fg: stop IMA transactions
during FG shutdown")'.
CRs-Fixed: 1001469
Change-Id: Ib7dce6b2ae1670554a29847e4381e71ba7b75edf
Signed-off-by: Mayank Rana <mrana@codeaurora.org>
Move the entire contents of linux/usb/f_accessory.h header to uapi,
it only contains a userspace interface.
Change-Id: Ieb5547da449588ae554988a201c0e6b4e3afc531
Signed-off-by: Colin Cross <ccross@android.com>
Colin Crossauthored and Amit Pundircommited 2016-10-24 23:41:21 +08:00
Move the most of linux/usb/f_mtp.h header to uapi. Move the only
remaining structure definition into f_mtp.c, the only place that
uses it.
Change-Id: I952c1a9dc15c36bf295a0eb4d74b6b1ad912ed03
Signed-off-by: Colin Cross <ccross@android.com>
Colin Crossauthored and Amit Pundircommited 2016-10-24 23:41:21 +08:00
Introduces a new FunctionFS descriptor flag named
FUNCTIONFS_CONFIG0_SETUP.
When this flag is enabled, FunctionFS userspace drivers can process
non-standard control requests in configuration 0.
Signed-off-by: Felix Hädicke <felixhaedicke@web.de>
Signed-off-by: Felipe Balbi <felipe.balbi@linux.intel.com>
Felix Hädickeauthored and Felipe Balbicommited 2016-08-25 12:13:17 +03:00
Introduces a new FunctionFS descriptor flag named
FUNCTIONFS_ALL_CTRL_RECIP. When this flag is enabled, control requests,
which are not explicitly directed to an interface or endpoint, can be
handled.
This allows FunctionFS userspace drivers to process non-standard
control requests.
Signed-off-by: Felix Hädicke <felixhaedicke@web.de>
Signed-off-by: Felipe Balbi <felipe.balbi@linux.intel.com>
Felix Hädickeauthored and Felipe Balbicommited 2016-08-25 12:13:17 +03:00
This adds the feature selectors from Table 9-8
Signed-off-by: Oliver Neukum <oneukum@suse.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Oliver Neukumauthored and Greg Kroah-Hartmancommited 2016-04-19 04:33:15 +09:00
This takes the definitions of requests from chapter 9.3.1
of the USB Power Delivery spec.
Signed-off-by: Oliver Neukum <oneukum@suse.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Oliver Neukumauthored and Greg Kroah-Hartmancommited 2016-04-19 04:33:15 +09:00
Adding the descriptors of chapter 9.2 of the Power Delivery spec.
Signed-off-by: Oliver Neukum <oneukum@suse.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Oliver Neukumauthored and Greg Kroah-Hartmancommited 2016-04-19 04:33:15 +09:00
The wFunctionalitySupport field should be __le16.
Signed-off-by: John Youn <johnyoun@synopsys.com>
Signed-off-by: Felipe Balbi <felipe.balbi@linux.intel.com>
John Younauthored and Felipe Balbicommited 2016-03-29 13:26:04 +03:00
A host is required to use the GetStatus command, with wIndex set to the
OTG status selector(F000H) to request the Host request flag from the
peripheral.
Acked-by: Peter Chen <peter.chen@freescale.com>
Signed-off-by: Li Jun <jun.li@nxp.com>
Signed-off-by: Felipe Balbi <balbi@kernel.org>
Li Junauthored and Felipe Balbicommited 2016-03-04 15:14:35 +02:00
The SuperspeedPlus Device Capability Descriptor has a variable size
depending on the number of sublink speed attributes.
This patch adds a macro to calculate that size. The macro takes one
argument, the Sublink Speed Attribute Count (SSAC) as reported by the
descriptor in bmAttributes[4:0].
See USB 3.1 9.6.2.5, Table 9-19.
Signed-off-by: John Youn <johnyoun@synopsys.com>
Signed-off-by: Felipe Balbi <balbi@kernel.org>
John Younauthored and Felipe Balbicommited 2016-03-04 15:14:22 +02:00
USB 3.1 devices that support precision time measurement have an
additional PTM cabaility descriptor as part of the full BOS descriptor
Look for this descriptor while parsing the BOS descriptor, and store it in
struct usb_hub_bos if it exists.
Signed-off-by: Mathias Nyman <mathias.nyman@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Mathias Nymanauthored and Greg Kroah-Hartmancommited 2016-02-14 17:03:23 -08:00
USB3.1 specifies a SuperSpeedPlus Isoc endpoint companion descriptor
which is returned as part of the devices complete configuration
descriptor.
It contains number of bytes per service interval which is needed when
reserving bus time in the schedule for transfers over 48K bytes per
service interval.
If bmAttributes bit 7 is set in the old SuperSpeed Endpoint Companion
descriptor, it will be ollowed by the new SuperSpeedPlus Isoc Endpoint
Companion descriptor.
Signed-off-by: Mathias Nyman <mathias.nyman@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Mathias Nymanauthored and Greg Kroah-Hartmancommited 2016-02-14 17:03:23 -08:00
These ioctls provide support for the USBTMC-USB488 control requests
for REN_CONTROL, GO_TO_LOCAL and LOCAL_LOCKOUT
Signed-off-by: Dave Penkler <dpenkler@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Dave Penklerauthored and Greg Kroah-Hartmancommited 2016-02-03 13:54:06 -08:00
This is a convenience function to obtain an instrument's
capabilities from its file descriptor without having to access sysfs
from the user program.
Signed-off-by: Dave Penkler <dpenkler@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Dave Penklerauthored and Greg Kroah-Hartmancommited 2016-02-03 13:54:06 -08:00
Background:
When performing a read on an instrument that is executing a function
that runs longer than the USB timeout the instrument may hang and
require a device reset to recover. The READ_STATUS_BYTE operation
always returns even when the instrument is busy permitting to poll
for the appropriate condition. This capability is referred to in
instrument application notes on synchronizing acquisitions for other
platforms.
Signed-off-by: Dave Penkler <dpenkler@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Dave Penklerauthored and Greg Kroah-Hartmancommited 2016-02-03 13:54:06 -08:00
usb 3.1 extend the hub get-port-status request by adding different
request types. the new request types return 4 additional bytes called
extended port status, these bytes are returned after the regular
portstatus and portchange values.
The extended port status contains a speed ID for the currently used
sublink speed. A table of supported Speed IDs with details about the link
is provided by the hub in the device descriptor BOS SuperSpeedPlus
device capability Sublink Speed Attributes.
Support this new request. Ask for the extended port status after port
reset if hub supports USB 3.1. If link is running at SuperSpeedPlus
set the device speed to USB_SPEED_SUPER_PLUS
Signed-off-by: Mathias Nyman <mathias.nyman@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Mathias Nymanauthored and Greg Kroah-Hartmancommited 2016-01-24 20:16:52 -08:00
Add a new USB_SPEED_SUPER_PLUS device speed, and make sure usb core can
handle the new speed.
In most cases the behaviour is the same as with USB_SPEED_SUPER SuperSpeed
devices. In a few places we add a "Plus" string to inform the user of the
new speed.
Signed-off-by: Mathias Nyman <mathias.nyman@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Mathias Nymanauthored and Greg Kroah-Hartmancommited 2016-01-24 20:16:52 -08:00
UVC 1.5 devices report a bInterfaceProtocol value set to 1 in their
interface descriptors. The uvcvideo driver only matches on
bInterfaceProtocol 0, preventing those devices from being detected.
More changes to the driver are needed for full UVC 1.5 compatibility.
However, at least the UVC 1.5 Microsoft Surface Pro 3 cameras have been
reported to work out of the box with the driver with an updated match
table.
Enable UVC 1.5 support in the match table to support the devices that
can work with the current driver implementation. Devices that can't will
fail, but that's hardly a regression as they're currently not detected
at all anyway.
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
Laurent Pinchartauthored and Mauro Carvalho Chehabcommited 2015-11-19 11:13:19 -02:00
Here is the big USB patchset for 4.4-rc1.
As usual, most of the changes are in the gadget subsystem, and we
removed a host controller for a device that is no longer in existance,
and probably never was even made public. There is also other minor
driver updates and new device ids, full details in the changelog.
All of these have been in linux-next for a while.
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2
iEYEABECAAYFAlY6gVMACgkQMUfUDdst+ynLZgCePfhiDuwriaX7osq90HDu8JOc
pTEAn2dBdw2VMPToUlxccR963YSfgu2A
=mMgp
-----END PGP SIGNATURE-----
Merge tag 'usb-4.4-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb
Pull USB updates from Greg KH:
"Here is the big USB patchset for 4.4-rc1.
As usual, most of the changes are in the gadget subsystem, and we
removed a host controller for a device that is no longer in existance,
and probably never was even made public. There is also other minor
driver updates and new device ids, full details in the changelog.
All of these have been in linux-next for a while"
* tag 'usb-4.4-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb: (233 commits)
USB: core: Codestyle fix in urb.c
usb: misc: usb3503: Use i2c_add_driver helper macro
usb: host: lpc32xx: don't unregister phy device
usb: host: lpc32xx: balance clk enable/disable on removal
usb: host: lpc32xx: fix warnings caused by enabling unprepared clock
uwb: drp: Use setup_timer
uwb: neh: Use setup_timer
uwb: rsv: Use setup_timer
USB: qcserial: add Sierra Wireless MC74xx/EM74xx
usb: chipidea: otg: don't wait vbus drops below BSV when starts host
chipidea: ci_hdrc_pci: use PCI_VDEVICE() instead of PCI_DEVICE()
doc: dt-binding: ci-hdrc-usb2: split vendor specific properties
usb: chipidea: imx: add imx6ul usb support
doc: dt-binding: ci-hdrc-usb2: improve property description
usb: chipidea: imx: add usb support for imx7d
Doc: usb: ci-hdrc-usb2: Add phy-clkgate-delay-us entry
usb: chipidea: Add support for 'phy-clkgate-delay-us' property
usb: chipidea: Use extcon framework for VBUS and ID detect
usb: gadget: net2280: restore ep_cfg after defect7374 workaround
usb: dwc2: host: Fix use after free w/ simultaneous irqs
...
USB 3.1 SuperSpeedPlus device capability descriptor is returned as part
of the bos descriptor for devices that support SuperSpeedPlus protocol.
The descriptor contains more detailed information about the supported
speeds of the device. More details about the descriptor can be found in
the USB 3.1 specification section 9.6.2.5
Signed-off-by: Mathias Nyman <mathias.nyman@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Mathias Nymanauthored and Greg Kroah-Hartmancommited 2015-10-04 10:34:17 +01:00
Add USB_OTG_ADP definition for usb_otg_descriptor.bmAttributes.
Signed-off-by: Macpaul Lin <macpaul@gmail.com>
Signed-off-by: Li Jun <jun.li@freescale.com>
Acked-by: Peter Chen <peter.chen@freescale.com>
Signed-off-by: Felipe Balbi <balbi@ti.com>
Macpaul Linauthored and Felipe Balbicommited 2015-07-29 09:59:20 -05:00
OTG 2.0 introduces bcdOTG in otg descriptor to identify the OTG and EH
supplement release number with which the OTG device is compliant, this
patch adds structure usb_otg20_descriptor for OTG 2.0 and above.
Signed-off-by: Macpaul Lin <macpaul@gmail.com>
Signed-off-by: Li Jun <jun.li@freescale.com>
Reviewed-by: Roger Quadros <rogerq@ti.com>
Signed-off-by: Felipe Balbi <balbi@ti.com>
Macpaul Linauthored and Felipe Balbicommited 2015-07-29 09:59:20 -05:00
Add eventfd which notifies userspace about ep0 events and AIO completion
events. It simplifies using of FunctionFS with event loop, because now
we need to poll on single file (instead of polling on ep0 and eventfd's
supplied to AIO layer).
FunctionFS eventfd is not triggered if another eventfd is supplied to
AIO layer (in AIO request). It can be useful, for example, when we want
to handle AIO transations for chosen endpoint in separate thread.
Signed-off-by: Robert Baldyga <r.baldyga@samsung.com>
Acked-by: Michal Nazarewicz <mina86@mina86.com>
Signed-off-by: Felipe Balbi <balbi@ti.com>
Robert Baldygaauthored and Felipe Balbicommited 2015-01-27 09:34:59 -06:00
This patch introduces virtual endpoint address mapping. It separates
function logic form physical endpoint addresses making it more hardware
independent.
Following modifications changes user space API, so to enable them user
have to switch on the FUNCTIONFS_VIRTUAL_ADDR flag in descriptors.
Endpoints are now refered using virtual endpoint addresses chosen by
user in endpoint descpriptors. This applies to each context when endpoint
address can be used:
- when accessing endpoint files in FunctionFS filesystemi (in file name),
- in setup requests directed to specific endpoint (in wIndex field),
- in descriptors returned by FUNCTIONFS_ENDPOINT_DESC ioctl.
In endpoint file names the endpoint address number is formatted as
double-digit hexadecimal value ("ep%02x") which has few advantages -
it is easy to parse, allows to easly recognize endpoint direction basing
on its name (IN endpoint number starts with digit 8, and OUT with 0)
which can be useful for debugging purpose, and it makes easier to introduce
further features allowing to use each endpoint number in both directions
to have more endpoints available for function if hardware supports this
(for example we could have ep01 which is endpoint 1 with OUT direction,
and ep81 which is endpoint 1 with IN direction).
Physical endpoint address can be still obtained using ioctl named
FUNCTIONFS_ENDPOINT_REVMAP, but now it's not neccesary to handle
USB transactions properly.
Signed-off-by: Robert Baldyga <r.baldyga@samsung.com>
Acked-by: Michal Nazarewicz <mina86@mina86.com>
Signed-off-by: Felipe Balbi <balbi@ti.com>
Robert Baldygaauthored and Felipe Balbicommited 2014-09-16 09:58:21 -05:00
This patch introduces ioctl named FUNCTIONFS_ENDPOINT_DESC, which
returns endpoint descriptor to userspace. It works only if function
is active.
Signed-off-by: Robert Baldyga <r.baldyga@samsung.com>
Acked-by: Michal Nazarewicz <mina86@mina86.com>
Signed-off-by: Felipe Balbi <balbi@ti.com>
Robert Baldygaauthored and Felipe Balbicommited 2014-09-09 10:04:45 -05:00
Since commit [ac8dde11: “Add flags to descriptors block”] functionfs
supports a new, more powerful and extensible, descriptor format.
Since ffs-test is probably the first thing users of the functionfs
interface see when they start writing functionfs user space daemons,
convert it to use the new format thus promoting it.
Signed-off-by: Michal Nazarewicz <mina86@mina86.com>
Signed-off-by: Felipe Balbi <balbi@ti.com>
Michal Nazarewiczauthored and Felipe Balbicommited 2014-09-02 09:16:46 -05:00
The structure can be used with user space tools that use the new
functionfs description format, for example as follows:
static const struct {
struct usb_functionfs_descs_head_v2 header;
__le32 fs_count;
__le32 hs_count;
struct {
…
} fs_desc;
struct {
…
} hs_desc;
} descriptors = {
.header = {
.magic = cpu_to_le32(FUNCTIONFS_DESCRIPTORS_MAGIC_V2),
.length = cpu_to_le32(sizeof(descriptors)),
.flags = cpu_to_le32(FUNCTIONFS_HAS_FS_DESC |
FUNCTIONFS_HAS_HS_DESC)
},
.fs_count = cpu_to_le32(X),
.fs_desc = {
…
},
.hs_count = cpu_to_le32(Y),
.hs_desc = {
…
}
};
Signed-off-by: Michal Nazarewicz <mina86@mina86.com>
Signed-off-by: Felipe Balbi <balbi@ti.com>
Michal Nazarewiczauthored and Felipe Balbicommited 2014-09-02 09:16:46 -05:00
Surprisingly enough, while a big set of patches, the majority is
composed of cleanups (using devm_*, fixing sparse errors, moving
code around, adding const, etc).
The highlights are addition of new support for PLX USB338x devices,
and support for USB 2.0-only configurations of the DWC3 IP core.
Signed-of-by: Felipe Balbi <balbi@ti.com>
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1
iQIcBAABAgAGBQJTzTI9AAoJEIaOsuA1yqREIqcQAJbwMaDb5sp8dWst+nL1Vo8N
08bhOOM+o2KLiIBSNQh1hYtujpa06RSQMiNYZ7F/+R4Q3OAoq+uC0dD69TLEQ3Sd
1xi0UgUTAvtXo13TToRjIi0mYywrrkZ91Maqff5jZKdslOY4ZfAScpUQHyD3i1UO
JNUqpayYAnp8JJIGQ8CG1wAeJh/J8JH3O607vaknKVjds+WMkeC5ubnuV4sgVw71
8JTwxk22EkMTr2MKhHjZwcv016NMEvziinWVoTXcWN2Uwk42Dn1nhfaYWSvg7kZE
8/3t6zzdFMdoeeTEn2xXIQGTjbHW0sBS5+S+6PAon2YbjS3x40cbyLJnZ+KoVXog
iHDKAl5w53gd/7qMiv57dW+HRP0M7/m2iy/owIrY8H8DkM3uwFevaeq/G2raJKmA
frB1k95bSyypN7wVkALYv4nurP5+d7ERy9hPj/49M5giJXPpEIbgKN2qGdafaEx7
xzAI+GqYrFtmmg25+f6AQRicVczQNMCdDT8HPZ04099Z2JVY/4uOoqTl29CePMgo
OXeQ45ECMoJuRSwpF56e8h+qmsXp6WD31IhlcHseTvUvFu0Ex4SgUJhFP2UaF9WP
aOqz0w36yX/ME3VhQk9YImNqGoqEk6fYHIHhxfdDugt0n68+M56EiiwtKvd5v5BI
hCJAMBrv+WCGnJvWunVW
=aJY4
-----END PGP SIGNATURE-----
Merge tag 'usb-for-v3.17' of git://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb into usb-next
Felipe writes:
usb: patches for v3.17 merge window
Surprisingly enough, while a big set of patches, the majority is
composed of cleanups (using devm_*, fixing sparse errors, moving
code around, adding const, etc).
The highlights are addition of new support for PLX USB338x devices,
and support for USB 2.0-only configurations of the DWC3 IP core.
Signed-of-by: Felipe Balbi <balbi@ti.com>
Add support for OS descriptors. The new format of descriptors is used,
because the "flags" field is required for extensions. os_count gives
the number of OSDesc[] elements.
The format of descriptors is given in include/uapi/linux/usb/functionfs.h.
For extended properties descriptor the usb_ext_prop_desc structure covers
only a part of a descriptor, because the wPropertyNameLength is unknown
up front.
Signed-off-by: Andrzej Pietrasiewicz <andrzej.p@samsung.com>
Acked-by: Michal Nazarewicz <mina86@mina86.com>
Signed-off-by: Felipe Balbi <balbi@ti.com>
Andrzej Pietrasiewiczauthored and Felipe Balbicommited 2014-07-10 08:36:52 -05:00
Even though usb_functionfs_descs_head structure is now deprecated,
it has been used by some user space tools. Its removel in commit
[ac8dde1: “Add flags to descriptors block”] was an oversight
leading to build breakage for such tools.
Bring it back so that old user space tools can still be build
without problems on newer kernel versions.
Cc: <stable@vger.kernel.org> # 3.14
Reported-by: Lad, Prabhakar <prabhakar.csengg@gmail.com>
Reported-by: Krzysztof Opasiak <k.opasiak@samsung.com>
Signed-off-by: Michal Nazarewicz <mina86@mina86.com>
Signed-off-by: Felipe Balbi <balbi@ti.com>
Michal Nazarewiczauthored and Felipe Balbicommited 2014-06-27 10:41:29 -05:00
Commit [ac8dde11: “usb: gadget: f_fs: Add flags to descriptors block”]
which introduced a new descriptor format for FunctionFS removed the
usb_functionfs_descs_head structure, which is still used by ffs-test.
tool.
Convert ffs-test by converting it to use the new header format. For
testing kernels prior to 3.14 (when the new format was introduced) and
parsing of the legacy headers in the new kernels, provide a compilation
flag to make the tool use the old format.
Finally, include information as to when the legacy FunctionFS headers
format has been deprecated (which is also when the new one has been
introduced).
Reported-by: Lad, Prabhakar <prabhakar.csengg@gmail.com>
Signed-off-by: Michal Nazarewicz <mina86@mina86.com>
Signed-off-by: Felipe Balbi <balbi@ti.com>
Michal Nazarewiczauthored and Felipe Balbicommited 2014-06-19 08:51:35 -05:00
The file include/uapi/linux/usb/cdc-wdm.h uses a __u16 so it needs to
include types.h as well to make the build system happy.
Fixes: 3edce1cf81 ("USB: cdc-wdm: implement IOCTL_WDM_MAX_COMMAND")
Cc: stable <stable@vger.kernel.org> # 3.10+
Cc: Bjørn Mork <bjorn@mork.no>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Pull networking updates from David Miller:
"Here is my initial pull request for the networking subsystem during
this merge window:
1) Support for ESN in AH (RFC 4302) from Fan Du.
2) Add full kernel doc for ethtool command structures, from Ben
Hutchings.
3) Add BCM7xxx PHY driver, from Florian Fainelli.
4) Export computed TCP rate information in netlink socket dumps, from
Eric Dumazet.
5) Allow IPSEC SA to be dumped partially using a filter, from Nicolas
Dichtel.
6) Convert many drivers to pci_enable_msix_range(), from Alexander
Gordeev.
7) Record SKB timestamps more efficiently, from Eric Dumazet.
8) Switch to microsecond resolution for TCP round trip times, also
from Eric Dumazet.
9) Clean up and fix 6lowpan fragmentation handling by making use of
the existing inet_frag api for it's implementation.
10) Add TX grant mapping to xen-netback driver, from Zoltan Kiss.
11) Auto size SKB lengths when composing netlink messages based upon
past message sizes used, from Eric Dumazet.
12) qdisc dumps can take a long time, add a cond_resched(), From Eric
Dumazet.
13) Sanitize netpoll core and drivers wrt. SKB handling semantics.
Get rid of never-used-in-tree netpoll RX handling. From Eric W
Biederman.
14) Support inter-address-family and namespace changing in VTI tunnel
driver(s). From Steffen Klassert.
15) Add Altera TSE driver, from Vince Bridgers.
16) Optimizing csum_replace2() so that it doesn't adjust the checksum
by checksumming the entire header, from Eric Dumazet.
17) Expand BPF internal implementation for faster interpreting, more
direct translations into JIT'd code, and much cleaner uses of BPF
filtering in non-socket ocntexts. From Daniel Borkmann and Alexei
Starovoitov"
* git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next: (1976 commits)
netpoll: Use skb_irq_freeable to make zap_completion_queue safe.
net: Add a test to see if a skb is freeable in irq context
qlcnic: Fix build failure due to undefined reference to `vxlan_get_rx_port'
net: ptp: move PTP classifier in its own file
net: sxgbe: make "core_ops" static
net: sxgbe: fix logical vs bitwise operation
net: sxgbe: sxgbe_mdio_register() frees the bus
Call efx_set_channels() before efx->type->dimension_resources()
xen-netback: disable rogue vif in kthread context
net/mlx4: Set proper build dependancy with vxlan
be2net: fix build dependency on VxLAN
mac802154: make csma/cca parameters per-wpan
mac802154: allow only one WPAN to be up at any given time
net: filter: minor: fix kdoc in __sk_run_filter
netlink: don't compare the nul-termination in nla_strcmp
can: c_can: Avoid led toggling for every packet.
can: c_can: Simplify TX interrupt cleanup
can: c_can: Store dlc private
can: c_can: Reduce register access
can: c_can: Make the code readable
...
This patch adds the MBIM extended functional descriptor structure
defined in "Universal Serial Bus Communications Class Subclass
Specification for Mobile Broadband Interface Model, Revision 1.0,
Errata-1" published by USB-IF.
Signed-off-by: Ben Chan <benchan@chromium.org>
Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
Ben Chanauthored and David S. Millercommited 2014-03-20 16:57:34 -04:00
This reworks the way SuperSpeed descriptors are added and instead of
having a magic after full and high speed descriptors, it reworks the
whole descriptors block to include a flags field which lists which
descriptors are present and makes future extensions possible.
Signed-off-by: Michal Nazarewicz <mina86@mina86.com>
Signed-off-by: Felipe Balbi <balbi@ti.com>
Michal Nazarewiczauthored and Felipe Balbicommited 2014-03-05 14:40:11 -06:00
Allow userspace to pass SuperSpeed descriptors and
handle them in the driver accordingly.
This change doesn't modify existing desc_header and thereby
keeps the ABI changes backward compatible i.e. existing
userspace drivers compiled with old header (functionfs.h)
would continue to work with the updated kernel.
Signed-off-by: Manu Gautam <mgautam@codeaurora.org>
Acked-by: Michal Nazarewicz <mina86@mina86.com>
Signed-off-by: Felipe Balbi <balbi@ti.com>
Manu Gautamauthored and Felipe Balbicommited 2014-03-05 14:40:10 -06:00
The USB_MAXCHILDREN symbol is used in include/uapi/linux/usb/ch11.h, a
user-mode header, even though it is defined in include/linux/usb.h,
which is kernel-only. This causes compile-time errors when user
programs try to #include linux/usb/ch11.h.
This patch fixes the problem by moving the definition of USB_MAXCHILDREN
into ch11.h. It also gets rid of unneeded parentheses.
Signed-off-by: Alan Stern <stern@rowland.harvard.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Alan Sternauthored and Greg Kroah-Hartmancommited 2013-07-16 15:33:02 -07:00
Userspace applications need to know the maximum supported message
size.
The cdc-wdm driver translates between a character device stream
and a message based protocol. Each message is transported as a
usb control message with no further encapsulation or syncronization.
Each read or write on the character device should translate to
exactly one usb control message to ensure that message boundaries
are kept intact. That means that the userspace application must
know the maximum message size supported by the device and driver,
making this size a vital part of the cdc-wdm character device API.
CDC WDM and CDC MBIM functions export the maximum supported
message size through CDC functional descriptors. The cdc-wdm and
cdc_mbim drivers will parse these descriptors and use the value
chosen by the device. The only current way for a userspace
application to retrive the value is by duplicating the descriptor
parsing. This is an unnecessary complex task, and application
writers are likely to postpone it, using a fixed value and adding
a "todo" item.
QMI functions have no way to tell the host what message size they
support. The qmi_wwan driver use a fixed value based on protocol
recommendations and observed device behaviour. Userspace
applications must know and hard code the same value. This scheme
will break if we ever encounter a QMI device needing a device
specific message size quirk. We are currently unable to support
such a device because using a non default size would break the
implicit userspace API.
The message size is currently a hidden attribute of the cdc-wdm
userspace API. Retrieving it is unnecessarily complex, increasing
the possibility of drivers and applications using different limits.
The resulting errors are hard to debug, and can only be replicated
on identical hardware.
Exporting the maximum message size from the driver simplifies the
task for the userspace application, and creates a unified
information source independent of device and function class. It also
serves to document that the message size is part of the cdc-wdm
userspace API.
This proposed API extension has been presented for the authors of
userspace applications and libraries using the current API: libmbim,
libqmi, uqmi, oFono and ModemManager. The replies were:
Aleksander Morgado:
"We do really need max message size for MBIM; and as you say, it may be
good to have the max message size info also for QMI, so the new ioctl
seems a good addition. So +1 from my side, for what it's worth."
Dan Williams:
"Yeah, +1 here. I'd prefer the sysfs file, but the fact that that
doesn't work for fd passing pretty much kills it."
No negative replies are so far received.
Cc: Aleksander Morgado <aleksander@lanedo.com>
Cc: Dan Williams <dcbw@redhat.com>
Signed-off-by: Bjørn Mork <bjorn@mork.no>
Acked-by: Oliver Neukum <oliver@neukum.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Bjørn Morkauthored and Greg Kroah-Hartmancommited 2013-03-25 13:32:20 -07:00
Kyle Yan
commited 
Greg Kroah-Hartman
commited 
Johan Hovold
authored and
Greg Kroah-Hartman
commited 
Ajay Agarwal
authored and
Hemant Kumar
commited 
Mayank Rana
commited 
Colin Cross
authored and
Dmitry Shmidt
commited 
Amit Pundir
commited 
Felix Hädicke
authored and
Felipe Balbi
commited 
Oliver Neukum
authored and
John Youn
authored and
Li Jun
authored and
Felipe Balbi
commited 
John Youn
authored and
Mathias Nyman
authored and
Dave Penkler
authored and
Laurent Pinchart
authored and
Mauro Carvalho Chehab
commited 
Linus Torvalds
commited 
Stephen Rothwell
authored and
David S. Miller
commited 
Macpaul Lin
authored and
Felipe Balbi
commited 
Robert Baldyga
authored and
Michal Nazarewicz
authored and
Andrzej Pietrasiewicz
authored and
Bjørn Mork
authored and
Ben Chan
authored and
Manu Gautam
authored and
Alan Stern
authored and
Huang Rui
authored and