Commit graph android_kernel_sony_sdm845/drivers/net/tehuti.c
Message SHA1
drivers/net/tehuti: use proper capability check for raw IO access
Yeah, in practice they both mean "root", but Alan correctly points out
that anybody who gets to do raw IO space accesses should really be using
CAP_SYS_RAWIO rather than CAP_NET_ADMIN.

Pointed-out-by: Alan Cox <alan@lxorguk.ukuu.org.uk>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

Linus Torvalds   commited 2008-04-29 11:45:16 -07:00
6203554207
[netdrvr] tehuti: move ioctl perm check closer to function start
Noticed by davem.

Signed-off-by: Jeff Garzik <jgarzik@redhat.com>

Jeff Garzik   commited 2008-04-25 03:11:31 -04:00
f946dffed6
tehuti: check register size
Signed-off-by: Francois Romieu <romieu@fr.zoreil.com>
Signed-off-by: Jeff Garzik <jgarzik@redhat.com>

Francois Romieu   authored and   Jeff Garzik   commited 2008-04-25 02:08:09 -04:00
6131a2601f
netdev: ARRAY_SIZE() cleanups
Convert array size calculations to use ARRAY_SIZE().

Signed-off-by: Alejandro Martinez Ruiz <alex@flawedcode.org>
Signed-off-by: Jeff Garzik <jeff@garzik.org>

Alejandro Martinez Ruiz   authored and   David S. Miller   commited 2008-01-28 15:03:37 -08:00
c00acf46de
netdev: use ARRAY_SIZE() instead of sizeof(array) / ETH_GSTRING_LEN
Using ARRAY_SIZE() on arrays of the form array[][K] makes it unnecessary
to know the value of K when checking its size.

Signed-off-by: Alejandro Martinez Ruiz <alex@flawedcode.org>
Signed-off-by: Jeff Garzik <jeff@garzik.org>

Alejandro Martinez Ruiz   authored and   David S. Miller   commited 2008-01-28 15:03:36 -08:00
4c3616cdda
[TEHUTI]: Fix incorrect usage of strncat in bdx_get_drvinfo()
Fix incorrect length for strncat by replacing it with strlcat

Signed-off-by: Roel Kluin <12o3l@tiscali.nl>
Signed-off-by: David S. Miller <davem@davemloft.net>

Roel Kluin   authored and   David S. Miller   commited 2007-11-13 03:17:16 -08:00
072ee3f9bd
tehuti: possible leak in bdx_probe
If pci_enable_device fails, bdx_probe returns without freeing the
allocated pci_nic structure.

Coverity CID 1908.

Signed-off-by: Florin Malita <fmalita@gmail.com>
Signed-off-by: Jeff Garzik <jeff@garzik.org>

Florin Malita   authored and   Jeff Garzik   commited 2007-10-15 14:29:48 -04:00
bc2618f752
network drivers: sparse warning fixes
Fix some of the easy warnings in network device drivers.

Signed-off-by: Stephen Hemminger <shemminger@linux-foundation.org>
Signed-off-by: Jeff Garzik <jeff@garzik.org>

Stephen Hemminger   authored and   David S. Miller   commited 2007-10-10 16:55:27 -07:00
ddfce6bb43
[NET]: Add Tehuti network driver.
[ Ported to napi_struct changes... -DaveM ]

Signed-off-by: David S. Miller <davem@davemloft.net>

Andy Gospodarek   authored and   David S. Miller   commited 2007-10-10 16:51:34 -07:00
1a348ccc10