Commit graph android_kernel_sony_sdm845/drivers/firewire
Message SHA1
firewire: prefix modules with firewire- instead of fw-
Of course everybody immediately associates "fw-" with FireWire, not
firmware or firewall or whatever.  But "firewire-" has a nice ring to
it too.

Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
Acked-by: Kristian Hoegsberg <krh@bitplanet.net>

Stefan Richter   commited 2007-05-27 23:21:01 +02:00
9a60731d00
firewire: Add missing byteswapping for receive DMA programs.
Signed-off-by: Kristian Hoegsberg <krh@redhat.com>
Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>

Kristian Høgsberg   authored and   Stefan Richter   commited 2007-05-27 23:21:00 +02:00
ec839e43fb
missing mm.h in fw-ohci
need it for page_private(), not all targets have it pulled indirectly

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

Al Viro   authored and   Linus Torvalds   commited 2007-05-15 18:56:37 -07:00
faa2fb4e67
firewire: Convert OHCI driver to use standard goto unwinding for error handling.
Signed-off-by: Kristian Hoegsberg <krh@redhat.com>
Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>

Kristian Høgsberg   authored and   Stefan Richter   commited 2007-05-10 18:24:14 +02:00
d79406dd14
firewire: Always use parens with sizeof.
Signed-off-by: Kristian Hoegsberg <krh@redhat.com>
Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>

Kristian Høgsberg   authored and   Stefan Richter   commited 2007-05-10 18:24:14 +02:00
2d826cc5c7
firewire: Drop single buffer request support.
The SCSI layer only passes sg requests down, so drop the
use_sg == 0, request_bufflen != 0 case.

Signed-off-by: Kristian Hoegsberg <krh@redhat.com>
Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>

Kristian Høgsberg   authored and   Stefan Richter   commited 2007-05-10 18:24:14 +02:00
213d7bbd76
firewire: Add a comment to describe why we split the sg list.
Signed-off-by: Kristian Hoegsberg <krh@redhat.com>
Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>

Kristian Høgsberg, Stefan Richter   authored and   Stefan Richter   commited 2007-05-10 18:24:14 +02:00
36abb3b18e
firewire: Return SCSI_MLQUEUE_HOST_BUSY for out of memory cases in queuecommand.
Signed-off-by: Kristian Hoegsberg <krh@redhat.com>
Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>

Kristian Høgsberg   authored and   Stefan Richter   commited 2007-05-10 18:24:14 +02:00
e1b68c4dcf
firewire: Handle the last few DMA mapping error cases.
This should be the last missing checks.

Signed-off-by: Kristian Hoegsberg <krh@redhat.com>
Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>

Kristian Høgsberg   authored and   Stefan Richter   commited 2007-05-10 18:24:14 +02:00
95ffc5e314
firewire: Allocate scsi_host up front and allocate the sbp2_device as hostdata.
Avoids an extra allocation and simplifies lifetime rules for the scsi_host.

Signed-off-by: Kristian Hoegsberg <krh@redhat.com>
Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>

Kristian Høgsberg   authored and   Stefan Richter   commited 2007-05-10 18:24:14 +02:00
ad85274fb7
firewire: Provide module aliase for backwards compatibility.
This patch loads fw-sbp2 if sbp2 is still in the config file. So one can
go back and forth between releases without worry about the root
filesystem drivers.

Signed-off-by: Kristian Hoegsberg <krh@redhat.com>

Existing mkinitrd scripts still have to be adapted, unless they grok
module aliases.

Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>

Olaf Hering   authored and   Stefan Richter   commited 2007-05-10 18:24:14 +02:00
1e4c7b0dab
firewire: Add to fw-core-y instead of assigning fw-core-objs in Makefile.
Signed-off-by: Kristian Hoegsberg <krh@redhat.com>
Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>

Kristian Høgsberg   authored and   Stefan Richter   commited 2007-05-10 18:24:13 +02:00
58e313b362
firewire: Break out shared IEEE1394 constant to separate header file.
Signed-off-by: Kristian Hoegsberg <krh@redhat.com>
Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>

Kristian Høgsberg   authored and   Stefan Richter   commited 2007-05-10 18:24:13 +02:00
4c5a443e80
firewire: Uppercase most macro names.
Signed-off-by: Kristian Hoegsberg <krh@redhat.com>
Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>

Kristian Høgsberg   authored and   Stefan Richter   commited 2007-05-10 18:24:13 +02:00
a77754a75d
firewire: Coding style cleanup: no spaces after function names.
Signed-off-by: Kristian Hoegsberg <krh@redhat.com>
Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>

Kristian Høgsberg   authored and   Stefan Richter   commited 2007-05-10 18:24:13 +02:00
a98e271987
firewire: Convert card_rwsem to a regular mutex.
Signed-off-by: Kristian Hoegsberg <krh@redhat.com>
Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>

Kristian Høgsberg   authored and   Stefan Richter   commited 2007-05-10 18:24:13 +02:00
6a5033be96
firewire: Clean up comment style.
Drop filenames from file preamble, drop editor annotations and
use standard indent style for block comments.

Signed-off-by: Kristian Hoegsberg <krh@redhat.com>
Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de> (fixed typo)

Kristian Høgsberg   authored and   Stefan Richter   commited 2007-05-10 18:24:13 +02:00
c781c06d11
firewire: Use lib/ implementation of CRC ITU-T.
With the CRC ITU-T implementation available in lib/ we can use that instead.

This also fixes a bug in the topology map crc computation.

Signed-off-by: Kristian Hoegsberg <krh@redhat.com>
Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de> (fixed Kconfig)

Kristian Høgsberg   authored and   Stefan Richter   commited 2007-05-10 18:24:13 +02:00
e175569c46
firewire: Rename fw-device-cdev.c to fw-cdev.c and move header to include/linux.
Signed-off-by: Kristian Høgsberg <krh@redhat.com>
Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>

Kristian Høgsberg   authored and   Stefan Richter   commited 2007-04-30 23:08:13 +02:00
9640d3d775
firewire: Future proof the iso ioctls by adding a handle for the iso context.
Currently create context always returns 0 and the other iso
ioctls will expect user space to pass that in for subsequent ioctls.

Signed-off-by: Kristian Høgsberg <krh@redhat.com>
Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>

Kristian Høgsberg   authored and   Stefan Richter   commited 2007-04-30 23:08:13 +02:00
abaa5743e3
firewire: Add read/write and size annotations to IOC numbers.
Also, with this change, refactor ioctl dispatch code to do the
copying from and to user space as indicated by the IOC annotations.

Signed-off-by: Kristian Høgsberg <krh@redhat.com>
Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>

Kristian Høgsberg   authored and   Stefan Richter   commited 2007-04-30 23:08:13 +02:00
4f2592232e
firewire: don't use extern on public symbols
Make firewire entry points not 'extern':

drivers/firewire/fw-device.c:160:25: warning: function 'fw_device_get' with external linkage has definition
drivers/firewire/fw-device.c:167:13: warning: function 'fw_device_put' with external linkage has definition

Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>

Randy Dunlap   authored and   Stefan Richter   commited 2007-04-27 01:39:03 +02:00
0b6aa3d053
firewire: fw-device printk fix
You don't know what type is used to implement u64.

Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>

Andrew Morton   authored and   Stefan Richter   commited 2007-04-27 01:28:47 +02:00
3e1dcb00d5
firewire: Don't use subsystem rwsem, it's going away.
Signed-off-by: Kristian Høgsberg <krh@redhat.com>
Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>

Kristian Høgsberg   authored and   Stefan Richter   commited 2007-04-17 21:14:32 +02:00
dde2b95430
firewire: Do an agent reset on error recovery.
Signed-off-by: Kristian Høgsberg <krh@redhat.com>

(Reverted part which moved it from eh_abort_handler to eh_host_reset_handler)

Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>

Kristian Høgsberg   authored and   Stefan Richter   commited 2007-04-12 01:28:13 +02:00
0fc7d6e4f4
firewire: Only free ORBs that completed the initial transaction.
In some situations we can receive the ORB status write before we
have received the ORB pointer write response.  When this happens,
we assume that the fw_transaction is finished and free the ORB
struct containing the fw_transaction.

This fix make the status write logic only accept status writes
for ORBs where the initial ORB pointer write transaction finished.

Signed-off-by: Kristian Høgsberg <krh@redhat.com>
Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>

Kristian Høgsberg   authored and   Stefan Richter   commited 2007-04-12 00:18:57 +02:00
12f26aa1b1
firewire: Forward SAM status codes to the scsi stack.
Or the SAM status codes from the device sense data into the
command error code.

Signed-off-by: Kristian Høgsberg <krh@redhat.com>
Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>

Kristian Høgsberg   authored and   Stefan Richter   commited 2007-04-12 00:18:57 +02:00
fbb5423c1d
firewire: Check for CONTEXT_RUN not CONTEXT_ACTIVE when starting AT DMA context.
Doh, bad typo...

Signed-off-by: Kristian Høgsberg <krh@redhat.com>
Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>

Kristian Høgsberg   authored and   Stefan Richter   commited 2007-04-12 00:18:57 +02:00
053b30808f
firewire: Byteswap iso header so all headers are presented as be32.
Signed-off-by: Kristian Høgsberg <krh@redhat.com>
Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>

Kristian Høgsberg   authored and   Stefan Richter   commited 2007-04-12 00:18:57 +02:00
15536221d1
firewire: Fix start on cycle 0 for IT, implement start on cycle for IR.
Signed-off-by: Kristian Høgsberg <krh@redhat.com>
Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>

Kristian Høgsberg   authored and   Stefan Richter   commited 2007-03-28 21:37:54 +02:00
8a2f7d932f
firewire: Fix the range check for the queue_iso payload pointer.
Signed-off-by: Kristian Høgsberg <krh@redhat.com>
Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de> (renamed a variable)

Kristian Høgsberg   authored and   Stefan Richter   commited 2007-03-28 21:30:16 +02:00
ef370ee74b
firewire: Increase the number of config rom retries and the retry delay.
Some devices have a really long power-on cycle, and we fail to
successfully probe these if they're plugged in and then turned on.

There's really no down-side to bumping the number of retries and the
retry delay, and most devices will get picked up within the first couple
of retries anyway.

Signed-off-by: Kristian Høgsberg <krh@redhat.com>
Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>

Kristian Høgsberg   authored and   Stefan Richter   commited 2007-03-28 21:30:16 +02:00
c5dfd0a5b0
firewire: Don't set card->irm_node before we have a new valid topology.
In case the topology build fails, we want to retain the old topology
info until another reset finishes and results in a valid new tree.  If
we clear card->irm_node to NULL and the topology build fails, we end up
dereferencing a NULL pointer in a few places.

Signed-off-by: Kristian Høgsberg <krh@redhat.com>
Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>

Kristian Høgsberg   authored and   Stefan Richter   commited 2007-03-28 21:30:15 +02:00
93e4fd455c
firewire: Generalize resource tracking for cdev implementation.
Generalize the way we keep track of the various resources and
assign a unique handle to each resource.

Signed-off-by: Kristian Høgsberg <krh@redhat.com>
Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>

Kristian Høgsberg   authored and   Stefan Richter   commited 2007-03-28 21:30:15 +02:00
3964a4496e
firewire: Add ioctls to add and remove config rom descriptors.
Signed-off-by: Kristian Høgsberg <krh@redhat.com>
Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de> (fixed whitespace)

Kristian Høgsberg   authored and   Stefan Richter   commited 2007-03-28 21:30:14 +02:00
66dea3e5f6
firewire: Streamline userspace interface structs.
Make event struct layout common part include the closure and add a
union for all event types; provide a mechanism for setting the
bus reset event closure.

Shuffle struct fw_cdev_queue_iso fields around to be 64-bit safe.

Signed-off-by: Kristian Høgsberg <krh@redhat.com>
Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>

Kristian Høgsberg   authored and   Stefan Richter   commited 2007-03-28 21:30:14 +02:00
da8ecffaed
firewire: Remember to set the driver_data pointer when queueing a packet.
Signed-off-by: Kristian Høgsberg <krh@redhat.com>
Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>

Kristian Høgsberg   authored and   Stefan Richter   commited 2007-03-28 21:30:14 +02:00
20d1167311
firewire: Use device->groups for adding device attributes.
We dynamically create an attribute group for the key present on the
device in hand and point device->group to it.  This way the device
core adds the sysfs attributes for us as the device is added.

Signed-off-by: Kristian Høgsberg <krh@redhat.com>
Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>

Kristian Høgsberg   authored and   Stefan Richter   commited 2007-03-28 21:30:13 +02:00
6f2e53d513
firewire: Add phy register defines.
Signed-off-by: Marc Butler <marc@adaptivecode.com>
Signed-off-by: Kristian Høgsberg <krh@redhat.com>
Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de> (added whitespace)

Marc Butler   authored and   Stefan Richter   commited 2007-03-24 23:29:19 +01:00
ecab413359
firewire: Export GUID as sysfs attribute.
Signed-off-by: Kristian Høgsberg <krh@redhat.com>
Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>

Kristian Høgsberg   authored and   Stefan Richter   commited 2007-03-22 00:48:50 +01:00
bbd1494580
firewire: Add sysfs attributes for config rom directory values.
We export the entire config rom, so this is technically redundant,
but should make udev rules and HAL integration easier.

Signed-off-by: Kristian Høgsberg <krh@redhat.com>
Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>

Kristian Høgsberg   authored and   Stefan Richter   commited 2007-03-22 00:48:50 +01:00
7feb9cce2d
firewire: Make use of struct device_type.
The device_type struct is useful for setting attributes for a device
and overriding .release and .uevent for a group of devices.  This patch
uses it this way to clean up the sysfs code a bit.

Signed-off-by: Kristian Høgsberg <krh@redhat.com>
Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>

Kristian Høgsberg   authored and   Stefan Richter   commited 2007-03-22 00:48:49 +01:00
21351dbe4e
firewire: ROM cache is CPU-endian
Puts a stray endian annotation down.

Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>

Stefan Richter   commited 2007-03-20 23:27:19 +01:00
945ac22253
firewire: fix compiler warnings on 64bit
Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
Signed-off-by: Kristian Høgsberg <krh@redhat.com>

Stefan Richter   commited 2007-03-20 23:27:19 +01:00
d84702a5d7
firewire: add includes for sem and rw_sem
as a precaution.

Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>

Stefan Richter   commited 2007-03-20 23:27:19 +01:00
633c52dccd
firewire: Grab dev->sem when doing the update callback.
This serializes the update callback with the probe and remove callback from
the driver core and prevents remove from being called while update is
running for the same device.

Signed-off-by: Kristian Høgsberg <krh@redhat.com>
Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>

Kristian Høgsberg   authored and   Stefan Richter   commited 2007-03-20 23:27:19 +01:00
015b066f4e
firewire: rename CONFIG_FW to CONFIG_FIREWIRE
to avoid confusion with CONFIG_FW_LOADER.

Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
Acked-by: Kristian Høgsberg <krh@redhat.com>

Stefan Richter   commited 2007-03-20 23:27:19 +01:00
11f494ee25
firewire: Add ref-counting for sbp2_device and hold a ref while we have work scheduled.
Signed-off-by: Kristian Høgsberg <krh@redhat.com>
Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>

Kristian Høgsberg   authored and   Stefan Richter   commited 2007-03-15 18:27:40 +01:00
b3d6e15114
firewire: Free pending transactions on cdev release.
Signed-off-by: Kristian Høgsberg <krh@redhat.com>
Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>

Kristian Høgsberg   authored and   Stefan Richter   commited 2007-03-15 18:21:36 +01:00
7e35f7f318
firewire: Zero out sd->scsi_host if we fail to register with the SCSI stack.
Signed-off-by: Kristian Høgsberg <krh@redhat.com>
Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>

Kristian Høgsberg   authored and   Stefan Richter   commited 2007-03-15 18:21:36 +01:00
693b902176