From eeb1fca2aa3c1307642b5a17f40fdbbda81f31cc Mon Sep 17 00:00:00 2001 From: Albert Wang Date: Thu, 10 Mar 2022 13:53:02 +0800 Subject: [PATCH] usb: dwc3: Set the initial value of usb_data_enabled before use Fixes: 4b7e37cbcd65 ("usb: new attributes implementation to enable/disable usb data") Bug: 194649527 Test: build, boot Signed-off-by: Jimmy Hu Change-Id: I63f58c3df620e91367b23b405fa0e9a577313964 Signed-off-by: Albert Wang --- drivers/usb/dwc3/dwc3-msm.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/usb/dwc3/dwc3-msm.c b/drivers/usb/dwc3/dwc3-msm.c index dfab013e7688..2bbe590f8f8b 100644 --- a/drivers/usb/dwc3/dwc3-msm.c +++ b/drivers/usb/dwc3/dwc3-msm.c @@ -3986,6 +3986,9 @@ static int dwc3_msm_probe(struct platform_device *pdev) if (of_property_read_bool(node, "qcom,connector-type-uAB")) mdwc->type_c = false; + /* set the initial value */ + mdwc->usb_data_enabled = true; + mdwc->usb_psy = power_supply_get_by_name("usb"); if (!mdwc->usb_psy) { dev_warn(mdwc->dev, "Could not get usb power_supply\n"); @@ -4023,8 +4026,6 @@ static int dwc3_msm_probe(struct platform_device *pdev) dev_info(mdwc->dev, "charger detection in progress\n"); } - /* set the initial value */ - mdwc->usb_data_enabled = true; device_create_file(&pdev->dev, &dev_attr_mode); device_create_file(&pdev->dev, &dev_attr_speed); device_create_file(&pdev->dev, &dev_attr_usb_compliance_mode);