joy/android_kernel_sony_sdm845
Watch
1
Fork
You've already forked android_kernel_sony_sdm845
 0
Code Issues Pull requests Projects Releases Wiki Activity

soc: qcom: qmi: Fix inconsistent locking

Browse source 
This patch addresses the following locking error:

qmi_interface.c:1998 qmi_svc_event_notifier_register() warn:
inconsistent returns 'mutex:&temp->svc_addr_list_lock'

Bug: 77543262
Test: build & boot
Change-Id: I45ac3ac961e0b0a33bc403ea8b130691bd378075
Signed-off-by: David Lin <dtwlin@google.com>
This commit is contained in:
David Lin 2018-06-28 11:59:44 -07:00 • committed by Michael Bestas
commit b35b8b705c
1 changed files with 6 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

8
drivers/soc/qcom/qmi_interface.c
View file

@ -1974,8 +1974,10 @@ int qmi_svc_event_notifier_register(uint32_t service_id,
svc_info_arr = kmalloc_array(num_servers,
sizeof(*svc_info_arr),
GFP_KERNEL);
if (!svc_info_arr)
return -ENOMEM;
if (!svc_info_arr) {
ret = -ENOMEM;
goto out;
}
num_servers = msm_ipc_router_lookup_server_name(
&svc_name,
svc_info_arr,
@ -1993,6 +1995,8 @@ int qmi_svc_event_notifier_register(uint32_t service_id,
spin_unlock_irqrestore(&temp->nb_lock, flags);
}
}
out:
mutex_unlock(&temp->svc_addr_list_lock);
return ret;