Test concurrency value should be increased or be configurable for the user #25

Open
opened 2023-03-27 00:51:45 +07:00 by Ghost · 15 comments
Ghost commented 2023-03-27 00:51:45 +07:00 (Migrated from git.disroot.org)

Created by: pouriaksrvi

When running a batch test for all list, the tests get done sequentially and each 10 tests wait for the earlier tests to be done.
It's slow when the list is too long.
It is because number 10 is hard-coded as the number of threads in V2RayTestService class

This number should be configurable or it should be a larger number.
Tests are IO burst tasks which don't use much CPU so increasing this number won't cause a huge CPU slowdown or performance issues.
Increasing this number, only causes the tests not getting waited or locked in a queue so they all can start at the same time.
This number can be at least 50 (or unlimited if it doesn't affect CPU context switcher on slow and weak devices?)

Later we can make it configurable too.
Also, a cachedThreadPool is the alternative solution, maybe.

It is needed when the list is long.

*Created by: pouriaksrvi* When running a batch test for all list, the tests get done sequentially and each 10 tests wait for the earlier tests to be done. It's slow when the list is too long. It is because number 10 is hard-coded as the number of threads in V2RayTestService class This number should be configurable or it should be a larger number. Tests are IO burst tasks which don't use much CPU so increasing this number won't cause a huge CPU slowdown or performance issues. Increasing this number, only causes the tests not getting waited or locked in a queue so they all can start at the same time. This number can be at least 50 (or unlimited if it doesn't affect CPU context switcher on slow and weak devices?) Later we can make it configurable too. Also, a cachedThreadPool is the alternative solution, maybe. It is needed when the list is long.
Ghost commented 2023-04-02 00:34:38 +07:00 (Migrated from git.disroot.org)

Thanks for you suggestion, since i'm not a developer so i only can edit and add some codes.

Thanks for you suggestion, since i'm not a developer so i only can edit and add some codes.
Ghost commented 2023-04-02 12:19:26 +07:00 (Migrated from git.disroot.org)

Created by: pouriaksrvi

Your welcome.
I will open a push request later. I know the solution. But I'm still unsure if it is a good solution or not.

*Created by: pouriaksrvi* Your welcome. I will open a push request later. I know the solution. But I'm still unsure if it is a good solution or not.
Ghost commented 2023-05-29 17:46:23 +07:00 (Migrated from git.disroot.org)

Created by: aryanshojaei74

Hello, please update the program, some configurations are not working

*Created by: aryanshojaei74* Hello, please update the program, some configurations are not working
Ghost commented 2023-05-29 17:50:47 +07:00 (Migrated from git.disroot.org)

Hello, please update the program, some configurations are not working

which configuration type?

> Hello, please update the program, some configurations are not working which configuration type?
Ghost commented 2023-05-29 18:54:03 +07:00 (Migrated from git.disroot.org)

Created by: aryanshojaei74

vless://
@.***:443?security=reality&encryption=none&pbk=71c4m-FD5URjGQqr0NmrOmFUoUn5Z8LmGzla90Y6iT4&headerType=none&fp=chrome&type=tcp&sni=discord.com&sid=ee479df7#Aryan

On Mon, 29 May 2023, 14:20 Cuynu, @.***> wrote:

Hello, please update the program, some configurations are not working

which configuration type?

—
Reply to this email directly, view it on GitHub
https://gitlab.com/cuynu/v2rayvn/-/issues/25#issuecomment-1566957137, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AT4LSNYXNLPBIUQC4KLIOPTXIR5RDANCNFSM6AAAAAAWIKBDJM
.
You are receiving this because you commented.Message ID:
@.***>

*Created by: aryanshojaei74* vless:// ***@***.***:443?security=reality&encryption=none&pbk=71c4m-FD5URjGQqr0NmrOmFUoUn5Z8LmGzla90Y6iT4&headerType=none&fp=chrome&type=tcp&sni=discord.com&sid=ee479df7#Aryan On Mon, 29 May 2023, 14:20 Cuynu, ***@***.***> wrote: > Hello, please update the program, some configurations are not working > > which configuration type? > > — > Reply to this email directly, view it on GitHub > <https://gitlab.com/cuynu/v2rayvn/-/issues/25#issuecomment-1566957137>, or > unsubscribe > <https://github.com/notifications/unsubscribe-auth/AT4LSNYXNLPBIUQC4KLIOPTXIR5RDANCNFSM6AAAAAAWIKBDJM> > . > You are receiving this because you commented.Message ID: > ***@***.***> >
Ghost commented 2023-05-29 19:02:08 +07:00 (Migrated from git.disroot.org)

Created by: aryanshojaei74

سلام لطفا برنامه رو آپدیت کنید بعضی از تنظیمات کار نمیکنه

کدام نوع پیکربندی؟

Vless Tcp

*Created by: aryanshojaei74* > > سلام لطفا برنامه رو آپدیت کنید بعضی از تنظیمات کار نمیکنه > > کدام نوع پیکربندی؟ Vless Tcp
Ghost commented 2023-05-29 19:17:48 +07:00 (Migrated from git.disroot.org)

pbk not supported

pbk not supported
Ghost commented 2023-05-29 19:21:00 +07:00 (Migrated from git.disroot.org)

Created by: aryanshojaei74

pbk not supported

That version V2ray 1.8.5 It works. Can it be fixed in future updates? Your program is much smoother and better

*Created by: aryanshojaei74* > pbk not supported That version V2ray 1.8.5 It works. Can it be fixed in future updates? Your program is much smoother and better
Ghost commented 2023-05-30 06:23:54 +07:00 (Migrated from git.disroot.org)

Created by: pouriaksrvi

pbk not supported

That version V2ray 1.8.5 It works. Can it be fixed in future updates? Your program is much smoother and better

سلام این ریپازیتوری اصلی نیست. باید روی ریپازیتوری اصلی بگی مشکلتو. این یه فورکه با بهبودهای جزیی که اعمال کرده.

*Created by: pouriaksrvi* > > pbk not supported > > That version V2ray 1.8.5 It works. Can it be fixed in future updates? Your program is much smoother and better سلام این ریپازیتوری اصلی نیست. باید روی ریپازیتوری اصلی بگی مشکلتو. این یه فورکه با بهبودهای جزیی که اعمال کرده.
Ghost commented 2023-06-28 19:33:06 +07:00 (Migrated from git.disroot.org)

Created by: aryanshojaei74

The new version stops when you add the server and comes out of the program.
V 1.8.17

*Created by: aryanshojaei74* The new version stops when you add the server and comes out of the program. V 1.8.17
Ghost commented 2023-06-28 20:25:22 +07:00 (Migrated from git.disroot.org)

The new version stops when you add the server and comes out of the program. V 1.8.17

Revert to 1.8.16, this is known issue

> The new version stops when you add the server and comes out of the program. V 1.8.17 Revert to 1.8.16, this is known issue
Ghost commented 2023-06-28 20:52:51 +07:00 (Migrated from git.disroot.org)

Created by: aryanshojaei74

Ok

On Wed, 28 Jun 2023, 16:55 Cuynu, @.***> wrote:

The new version stops when you add the server and comes out of the
program. V 1.8.17

Revert to 1.8.16, this is known issue

—
Reply to this email directly, view it on GitHub
https://gitlab.com/cuynu/v2rayvn/-/issues/25#issuecomment-1611409250, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AT4LSN3R4IUXABW664BOCDDXNQWEZANCNFSM6AAAAAAWIKBDJM
.
You are receiving this because you commented.Message ID:
@.***>

*Created by: aryanshojaei74* Ok On Wed, 28 Jun 2023, 16:55 Cuynu, ***@***.***> wrote: > The new version stops when you add the server and comes out of the > program. V 1.8.17 > > Revert to 1.8.16, this is known issue > > — > Reply to this email directly, view it on GitHub > <https://gitlab.com/cuynu/v2rayvn/-/issues/25#issuecomment-1611409250>, or > unsubscribe > <https://github.com/notifications/unsubscribe-auth/AT4LSN3R4IUXABW664BOCDDXNQWEZANCNFSM6AAAAAAWIKBDJM> > . > You are receiving this because you commented.Message ID: > ***@***.***> >
Ghost commented 2023-07-08 03:35:39 +07:00 (Migrated from git.disroot.org)

Ok
…
On Wed, 28 Jun 2023, 16:55 Cuynu, @.> wrote: The new version stops when you add the server and comes out of the program. V 1.8.17 Revert to 1.8.16, this is known issue — Reply to this email directly, view it on GitHub <#25 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AT4LSN3R4IUXABW664BOCDDXNQWEZANCNFSM6AAAAAAWIKBDJM . You are receiving this because you commented.Message ID: @.>

fixed in 1.8.18

> Ok > […](#) > On Wed, 28 Jun 2023, 16:55 Cuynu, ***@***.***> wrote: The new version stops when you add the server and comes out of the program. V 1.8.17 Revert to 1.8.16, this is known issue — Reply to this email directly, view it on GitHub <[#25 (comment)](https://gitlab.com/cuynu/v2rayvn/-/issues/25#issuecomment-1611409250)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AT4LSN3R4IUXABW664BOCDDXNQWEZANCNFSM6AAAAAAWIKBDJM> . You are receiving this because you commented.Message ID: ***@***.***> fixed in 1.8.18
Ghost commented 2023-07-08 03:36:23 +07:00 (Migrated from git.disroot.org)

When running a batch test for all list, the tests get done sequentially and each 10 tests wait for the earlier tests to be done. It's slow when the list is too long. It is because number 10 is hard-coded as the number of threads in V2RayTestService class

This number should be configurable or it should be a larger number. Tests are IO burst tasks which don't use much CPU so increasing this number won't cause a huge CPU slowdown or performance issues. Increasing this number, only causes the tests not getting waited or locked in a queue so they all can start at the same time. This number can be at least 50 (or unlimited if it doesn't affect CPU context switcher on slow and weak devices?)

Later we can make it configurable too. Also, a cachedThreadPool is the alternative solution, maybe.

It is needed when the list is long.

thx i will try increase in next build

> When running a batch test for all list, the tests get done sequentially and each 10 tests wait for the earlier tests to be done. It's slow when the list is too long. It is because number 10 is hard-coded as the number of threads in V2RayTestService class > > This number should be configurable or it should be a larger number. Tests are IO burst tasks which don't use much CPU so increasing this number won't cause a huge CPU slowdown or performance issues. Increasing this number, only causes the tests not getting waited or locked in a queue so they all can start at the same time. This number can be at least 50 (or unlimited if it doesn't affect CPU context switcher on slow and weak devices?) > > Later we can make it configurable too. Also, a cachedThreadPool is the alternative solution, maybe. > > It is needed when the list is long. thx i will try increase in next build
Ghost commented 2023-07-08 03:58:57 +07:00 (Migrated from git.disroot.org)

Created by: aryanshojaei74

Ok, thanks for the clarification.

On Sat, 8 Jul 2023, 00:06 Cuynu, @.***> wrote:

When running a batch test for all list, the tests get done sequentially
and each 10 tests wait for the earlier tests to be done. It's slow when the
list is too long. It is because number 10 is hard-coded as the number of
threads in V2RayTestService class

This number should be configurable or it should be a larger number. Tests
are IO burst tasks which don't use much CPU so increasing this number won't
cause a huge CPU slowdown or performance issues. Increasing this number,
only causes the tests not getting waited or locked in a queue so they all
can start at the same time. This number can be at least 50 (or unlimited if
it doesn't affect CPU context switcher on slow and weak devices?)

Later we can make it configurable too. Also, a cachedThreadPool is the
alternative solution, maybe.

It is needed when the list is long.

thx i will try increase in next build

—
Reply to this email directly, view it on GitHub
https://gitlab.com/cuynu/v2rayvn/-/issues/25#issuecomment-1626059682, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AT4LSN72E2X4564PQ277Y6DXPBXNFANCNFSM6AAAAAAWIKBDJM
.
You are receiving this because you commented.Message ID:
@.***>

*Created by: aryanshojaei74* Ok, thanks for the clarification. On Sat, 8 Jul 2023, 00:06 Cuynu, ***@***.***> wrote: > When running a batch test for all list, the tests get done sequentially > and each 10 tests wait for the earlier tests to be done. It's slow when the > list is too long. It is because number 10 is hard-coded as the number of > threads in V2RayTestService class > > This number should be configurable or it should be a larger number. Tests > are IO burst tasks which don't use much CPU so increasing this number won't > cause a huge CPU slowdown or performance issues. Increasing this number, > only causes the tests not getting waited or locked in a queue so they all > can start at the same time. This number can be at least 50 (or unlimited if > it doesn't affect CPU context switcher on slow and weak devices?) > > Later we can make it configurable too. Also, a cachedThreadPool is the > alternative solution, maybe. > > It is needed when the list is long. > > thx i will try increase in next build > > — > Reply to this email directly, view it on GitHub > <https://gitlab.com/cuynu/v2rayvn/-/issues/25#issuecomment-1626059682>, or > unsubscribe > <https://github.com/notifications/unsubscribe-auth/AT4LSN72E2X4564PQ277Y6DXPBXNFANCNFSM6AAAAAAWIKBDJM> > . > You are receiving this because you commented.Message ID: > ***@***.***> >
Sign in to join this conversation.
No milestone
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
cuynu/v2rayvn#25
No description provided.