cuynu/mbbpatch_oldest_may
Watch
1
Fork
You've already forked mbbpatch_oldest_may
 0
Code Issues Pull requests Projects Releases Wiki Activity

fix: mbcpapp.sh: use ls for glob existence checking

Browse source 
In mbcpapp.sh line 78:
    if [ -f ~/mbbpatch/MBCPApp/mbapk/*.apk ]
            ^----------------------------^ SC2144 (error): -f doesn't work with globs. Use a for loop.

In mbcpapp.sh line 169:
    if [ -f ~/mbbpatch/MBCPApp/mbapk/*.apks ]
            ^-----------------------------^ SC2144 (error): -f doesn't work with globs. Use a for loop.

we do not care about the actual result,
we just need to know whether the files exist,
tis probably fine

Signed-off-by: fukiame <fukiame@proton.me>
This commit is contained in:
Hikarie Fukirei 2025-07-23 02:24:49 +07:00
commit b799b0d8f3
1 changed files with 2 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

4
MBCPApp/mbcpapp.sh
View file

@ -75,7 +75,7 @@ do
elif [ "$opt" == 'Unpack APK' ]; then
# Check if *.apk exists
if [ -f ~/mbbpatch/MBCPApp/mbapk/*.apk ]
if ls ~/mbbpatch/MBCPApp/mbapk/*.apk >/dev/null 2>&1
then
# Check if apk is unpacked or not
if [ -d ~/mbbpatch/MBCPApp/mbapk/mbapk_unpacked ]
@ -166,7 +166,7 @@ else
fi
elif [ "$opt" == 'Convert apks to apk' ]; then
if [ -f ~/mbbpatch/MBCPApp/mbapk/*.apks ]
if ls ~/mbbpatch/MBCPApp/mbapk/*.apks >/dev/null 2>&1
then
echo "Converting apks to apk..."
java -jar tools/APKEditor-1.4.3.jar m -i mbapk/*.apks