From 011ba1b8c7f8ca50026c989f33d64cd1dabd4072 Mon Sep 17 00:00:00 2001
From: fukiame <fukiame@proton.me>
Date: Wed, 23 Jul 2025 02:00:19 +0700
Subject: [PATCH] chore: mbcpapp.sh: actually use $COMMIT

appears unused despite being set

also fix some stray SC2086

also move var down after all runtime checks
---
 MBCPApp/mbcpapp.sh | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/MBCPApp/mbcpapp.sh b/MBCPApp/mbcpapp.sh
index 868d520..99fbb57 100755
--- a/MBCPApp/mbcpapp.sh
+++ b/MBCPApp/mbcpapp.sh
@@ -32,7 +32,6 @@ fi
 
 COMMIT='git rev-parse --short HEAD'
 
-
 # Check if java exists on /usr/bin/java
 echo Checking if Java exists...
 if java -version ; then
@@ -50,7 +49,7 @@ echo "Patching-tool for MB Bank app with Flutter engine (v6.4.0+)"
 echo "Original APK path must be inside [mbapk] folder !"
 echo "IMPORTANT : Script must be run on [~/mbbpatch/MBCPApp] !"
 echo -------------------------------------------------------------
-echo "Current commit :" $(git rev-parse --short HEAD) '(dev)'
+echo "Current commit : $COMMIT (dev)"
 echo "Source code : https://gitlab.com/mbcp/mbbpatch"
 echo "Made possible by Cuynu with love <3"
 echo -------------------------------------------------------------   
@@ -126,7 +125,7 @@ fi
      if [ -d ~/mbbpatch/MBCPApp/mbapk/mbapk_unpacked ]
  then
     echo "Repacking APK..."
-    echo "This app are compiled by MBCPApp Patcher on $(uname -s -r) with commit :" $(git rev-parse --short HEAD) at $(date). "That's all xD" > 'mbapk/mbapk_unpacked/assets/mbcp_info/mbcpinfo.txt'
+    echo "Compiled by MBCPApp Patcher on $(uname -s -r) with commit $COMMIT at $(date). That's all xD" > 'mbapk/mbapk_unpacked/assets/mbcp_info/mbcpinfo.txt'
     java -jar tools/apktool_2.12.0.jar b mbapk/mbapk_unpacked -o mbcpapp_apk/MBCP_Flutter_TMP.apk
     echo "Processing APK signature scheme v2/v3..."
     rm -rf 'mbcpapp_apk/MBCP_Flutter_TMP_decompile_xml'